[PATCH 1/2] docs: admin-guide: Fix min value of threads-max in kernel.rst

[PATCH 1/2] docs: admin-guide: Fix min value of threads-max in kernel.rst

[Masanari Iida]

Since following patch was merged 5.4-rc3, minimum value for
threads-max changed to 1.

kernel/sysctl.c: do not override max_threads provided by userspace
b0f53dbc4bc4c371f38b14c391095a3bb8a0bb40

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 Documentation/admin-guide/sysctl/kernel.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
index 032c7cd3cede..38e0f10d7d9f 100644
--- a/Documentation/admin-guide/sysctl/kernel.rst
+++ b/Documentation/admin-guide/sysctl/kernel.rst
@@ -1101,7 +1101,7 @@ During initialization the kernel sets this value such that even if the
 maximum number of threads is created, the thread structures occupy only
 a part (1/8th) of the available RAM pages.
 
-The minimum value that can be written to threads-max is 20.
+The minimum value that can be written to threads-max is 1.
 
 The maximum value that can be written to threads-max is given by the
 constant FUTEX_TID_MASK (0x3fffffff).
-- 
2.24.0.rc1

[PATCH 2/2] docs: admin-guide: Remove threads-max auto-tuning

[Masanari Iida]

Since following path was merged in 5.4-rc3,
auto-tuning feature in threads-max was not exist any more.
Fix the admin-guide document as is.

kernel/sysctl.c: do not override max_threads provided by userspace
b0f53dbc4bc4c371f38b14c391095a3bb8a0bb40

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 Documentation/admin-guide/sysctl/kernel.rst | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
index 38e0f10d7d9f..9035adbdff58 100644
--- a/Documentation/admin-guide/sysctl/kernel.rst
+++ b/Documentation/admin-guide/sysctl/kernel.rst
@@ -1109,10 +1109,6 @@ constant FUTEX_TID_MASK (0x3fffffff).
 If a value outside of this range is written to threads-max an error
 EINVAL occurs.
 
-The value written is checked against the available RAM pages. If the
-thread structures would occupy too much (more than 1/8th) of the
-available RAM pages threads-max is reduced accordingly.
-
 
 unknown_nmi_panic:
 ==================
-- 
2.24.0.rc1

Re: [PATCH 1/2] docs: admin-guide: Fix min value of threads-max in kernel.rst

[Michal Hocko]

On Fri 01-11-19 13:04:37, Masanari Iida wrote:
> Since following patch was merged 5.4-rc3, minimum value for
> threads-max changed to 1.
> 
> kernel/sysctl.c: do not override max_threads provided by userspace
> b0f53dbc4bc4c371f38b14c391095a3bb8a0bb40
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  Documentation/admin-guide/sysctl/kernel.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
> index 032c7cd3cede..38e0f10d7d9f 100644
> --- a/Documentation/admin-guide/sysctl/kernel.rst
> +++ b/Documentation/admin-guide/sysctl/kernel.rst
> @@ -1101,7 +1101,7 @@ During initialization the kernel sets this value such that even if the
>  maximum number of threads is created, the thread structures occupy only
>  a part (1/8th) of the available RAM pages.
>  
> -The minimum value that can be written to threads-max is 20.
> +The minimum value that can be written to threads-max is 1.
>  
>  The maximum value that can be written to threads-max is given by the
>  constant FUTEX_TID_MASK (0x3fffffff).
> -- 
> 2.24.0.rc1

-- 
Michal Hocko
SUSE Labs

Re: [PATCH 2/2] docs: admin-guide: Remove threads-max auto-tuning

[Michal Hocko]

On Fri 01-11-19 13:04:38, Masanari Iida wrote:
> Since following path was merged in 5.4-rc3,
> auto-tuning feature in threads-max was not exist any more.
> Fix the admin-guide document as is.
> 
> kernel/sysctl.c: do not override max_threads provided by userspace
> b0f53dbc4bc4c371f38b14c391095a3bb8a0bb40
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  Documentation/admin-guide/sysctl/kernel.rst | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
> index 38e0f10d7d9f..9035adbdff58 100644
> --- a/Documentation/admin-guide/sysctl/kernel.rst
> +++ b/Documentation/admin-guide/sysctl/kernel.rst
> @@ -1109,10 +1109,6 @@ constant FUTEX_TID_MASK (0x3fffffff).
>  If a value outside of this range is written to threads-max an error
>  EINVAL occurs.
>  
> -The value written is checked against the available RAM pages. If the
> -thread structures would occupy too much (more than 1/8th) of the
> -available RAM pages threads-max is reduced accordingly.
> -
>  
>  unknown_nmi_panic:
>  ==================
> -- 
> 2.24.0.rc1

-- 
Michal Hocko
SUSE Labs

Re: [PATCH 1/2] docs: admin-guide: Fix min value of threads-max in kernel.rst

[Jonathan Corbet]

On Fri,  1 Nov 2019 13:04:37 +0900
Masanari Iida <standby24x7@gmail.com> wrote:

> Since following patch was merged 5.4-rc3, minimum value for
> threads-max changed to 1.
> 
> kernel/sysctl.c: do not override max_threads provided by userspace
> b0f53dbc4bc4c371f38b14c391095a3bb8a0bb40
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>

Both patches applied, thanks.

jon