* [PATCH v2] net: ethernet: octeon_mgmt: Account for second possible VLAN header [not found] <20191107.151409.1123596566825003561.davem@davemloft.net> @ 2019-11-08 10:00 ` Sverdlin, Alexander (Nokia - DE/Ulm) 2019-11-08 19:09 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: Sverdlin, Alexander (Nokia - DE/Ulm) @ 2019-11-08 10:00 UTC (permalink / raw) To: netdev Cc: Sverdlin, Alexander (Nokia - DE/Ulm), David S . Miller , Jarod Wilson, stable From: Alexander Sverdlin <alexander.sverdlin@nokia.com> Octeon's input ring-buffer entry has 14 bits-wide size field, so to account for second possible VLAN header max_mtu must be further reduced. Fixes: 109cc16526c6d ("ethernet/cavium: use core min/max MTU checking") Cc: stable@vger.kernel.org Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> --- Changelog: v2: Added "Fixes:" tag, Cc'ed stable drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c index 0e5de88..cdd7e5d 100644 --- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c +++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c @@ -1499,7 +1499,7 @@ static int octeon_mgmt_probe(struct platform_device *pdev) netdev->ethtool_ops = &octeon_mgmt_ethtool_ops; netdev->min_mtu = 64 - OCTEON_MGMT_RX_HEADROOM; - netdev->max_mtu = 16383 - OCTEON_MGMT_RX_HEADROOM; + netdev->max_mtu = 16383 - OCTEON_MGMT_RX_HEADROOM - VLAN_HLEN; mac = of_get_mac_address(pdev->dev.of_node); -- 2.4.6 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: ethernet: octeon_mgmt: Account for second possible VLAN header 2019-11-08 10:00 ` [PATCH v2] net: ethernet: octeon_mgmt: Account for second possible VLAN header Sverdlin, Alexander (Nokia - DE/Ulm) @ 2019-11-08 19:09 ` David Miller 2019-11-08 19:19 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: David Miller @ 2019-11-08 19:09 UTC (permalink / raw) To: alexander.sverdlin; +Cc: netdev, jarod, stable From: "Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@nokia.com> Date: Fri, 8 Nov 2019 10:00:44 +0000 > From: Alexander Sverdlin <alexander.sverdlin@nokia.com> > > Octeon's input ring-buffer entry has 14 bits-wide size field, so to account > for second possible VLAN header max_mtu must be further reduced. > > Fixes: 109cc16526c6d ("ethernet/cavium: use core min/max MTU checking") > Cc: stable@vger.kernel.org > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> > --- > Changelog: > v2: Added "Fixes:" tag, Cc'ed stable Networking patches do not CC: stable, as per the Netdev FAQ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: ethernet: octeon_mgmt: Account for second possible VLAN header 2019-11-08 19:09 ` David Miller @ 2019-11-08 19:19 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2019-11-08 19:19 UTC (permalink / raw) To: alexander.sverdlin; +Cc: netdev, jarod, stable From: David Miller <davem@davemloft.net> Date: Fri, 08 Nov 2019 11:09:21 -0800 (PST) > From: "Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@nokia.com> > Date: Fri, 8 Nov 2019 10:00:44 +0000 > >> From: Alexander Sverdlin <alexander.sverdlin@nokia.com> >> >> Octeon's input ring-buffer entry has 14 bits-wide size field, so to account >> for second possible VLAN header max_mtu must be further reduced. >> >> Fixes: 109cc16526c6d ("ethernet/cavium: use core min/max MTU checking") >> Cc: stable@vger.kernel.org >> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> >> --- >> Changelog: >> v2: Added "Fixes:" tag, Cc'ed stable > > Networking patches do not CC: stable, as per the Netdev FAQ Applied with stable CC: removed, and queued up for -stable, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-08 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191107.151409.1123596566825003561.davem@davemloft.net>
2019-11-08 10:00 ` [PATCH v2] net: ethernet: octeon_mgmt: Account for second possible VLAN header Sverdlin, Alexander (Nokia - DE/Ulm)
2019-11-08 19:09 ` David Miller
2019-11-08 19:19 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).