From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix ext4_empty_dir() for directories with holes
Date: Wed, 27 Nov 2019 14:44:15 -0500 [thread overview]
Message-ID: <20191127194415.GA22921@mit.edu> (raw)
In-Reply-To: <20191127131258.1163-1-jack@suse.cz>
On Wed, Nov 27, 2019 at 02:12:58PM +0100, Jan Kara wrote:
> Function ext4_empty_dir() doesn't correctly handle directories with
> holes and crashes on bh->b_data dereference when bh is NULL....
Hi Jan,
Thanks for the patch.
However, it looks like we're still vulnerable to the first block of
the directory being NULL?
> @@ -2833,19 +2833,25 @@ bool ext4_empty_dir(struct inode *inode)
> return true;
>
> de = (struct ext4_dir_entry_2 *) bh->b_data;
^^^^^^^^^^^
- Ted
next prev parent reply other threads:[~2019-11-27 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 13:12 [PATCH] ext4: Fix ext4_empty_dir() for directories with holes Jan Kara
2019-11-27 19:44 ` Theodore Y. Ts'o [this message]
2019-11-27 19:53 ` Theodore Y. Ts'o
2019-11-27 20:00 ` Theodore Y. Ts'o
2019-12-01 15:13 ` [ext4] 3d487697d2: BUG:unable_to_handle_page_fault_for_address kernel test robot
2019-12-02 11:34 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127194415.GA22921@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).