Re: [PATCH 1/4] Btrfs: fix a race between scrub and block group removal/allocation

Re: [PATCH 1/4] Btrfs: fix a race between scrub and block group removal/allocation

[Sasha Levin]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3204 bytes --]

Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.6.11, v5.4.39, v4.19.121, v4.14.179, v4.9.222, v4.4.222.

v5.6.11: Build OK!
v5.4.39: Build failed! Errors:
    fs/btrfs/scrub.c:3291:20: error: dereferencing pointer to incomplete type ‘struct btrfs_block_group’
    fs/btrfs/scrub.c:3472:31: error: passing argument 7 of ‘scrub_stripe’ from incompatible pointer type [-Werror=incompatible-pointer-types]

v4.19.121: Build failed! Errors:
    fs/btrfs/scrub.c:3289:20: error: dereferencing pointer to incomplete type ‘struct btrfs_block_group’
    fs/btrfs/scrub.c:3470:31: error: passing argument 7 of ‘scrub_stripe’ from incompatible pointer type [-Werror=incompatible-pointer-types]

v4.14.179: Failed to apply! Possible dependencies:
    32934280967d ("Btrfs: clean up scrub is_dev_replace parameter")
    c83488afc5a7 ("btrfs: Remove fs_info from btrfs_inc_block_group_ro")

v4.9.222: Failed to apply! Possible dependencies:
    0b246afa62b0 ("btrfs: root->fs_info cleanup, add fs_info convenience variables")
    32934280967d ("Btrfs: clean up scrub is_dev_replace parameter")
    5e00f1939f6e ("btrfs: convert btrfs_inc_block_group_ro to accept fs_info")
    62d1f9fe97dd ("btrfs: remove trivial helper btrfs_find_tree_block")
    c83488afc5a7 ("btrfs: Remove fs_info from btrfs_inc_block_group_ro")
    cf8cddd38bab ("btrfs: don't abuse REQ_OP_* flags for btrfs_map_block")
    da17066c4047 ("btrfs: pull node/sector/stripe sizes out of root and into fs_info")
    de143792253e ("btrfs: struct btrfsic_state->root should be an fs_info")
    fb456252d3d9 ("btrfs: root->fs_info cleanup, use fs_info->dev_root everywhere")

v4.4.222: Failed to apply! Possible dependencies:
    0132761017e0 ("btrfs: fix string and comment grammatical issues and typos")
    09cbfeaf1a5a ("mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros")
    0b246afa62b0 ("btrfs: root->fs_info cleanup, add fs_info convenience variables")
    0e749e54244e ("dax: increase granularity of dax_clear_blocks() operations")
    32934280967d ("Btrfs: clean up scrub is_dev_replace parameter")
    4420cfd3f51c ("staging: lustre: format properly all comment blocks for LNet core")
    52db400fcd50 ("pmem, dax: clean up clear_pmem()")
    5e00f1939f6e ("btrfs: convert btrfs_inc_block_group_ro to accept fs_info")
    5fd88337d209 ("staging: lustre: fix all conditional comparison to zero in LNet layer")
    b2e0d1625e19 ("dax: fix lifetime of in-kernel dax mappings with dax_map_atomic()")
    bb7ab3b92e46 ("btrfs: Fix misspellings in comments.")
    c83488afc5a7 ("btrfs: Remove fs_info from btrfs_inc_block_group_ro")
    cf8cddd38bab ("btrfs: don't abuse REQ_OP_* flags for btrfs_map_block")
    d1a5f2b4d8a1 ("block: use DAX for partition table reads")
    de143792253e ("btrfs: struct btrfsic_state->root should be an fs_info")
    e10624f8c097 ("pmem: fail io-requests to known bad blocks")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha