* [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index [not found] <20200629235210.441709-1-paul@crapouillou.net> @ 2020-06-29 23:52 ` Paul Cercueil 2020-06-30 11:35 ` Sam Ravnborg 0 siblings, 1 reply; 2+ messages in thread From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw) To: David Airlie, Daniel Vetter, Rob Herring Cc: od, dri-devel, devicetree, linux-mips, linux-kernel, Paul Cercueil, stable plane->index is NOT the index of the color plane in a YUV frame. Actually, a YUV frame is represented by a single drm_plane, even though it contains three Y, U, V planes. Cc: stable@vger.kernel.org # v5.3 Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs") Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- Notes: v2: No change drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index a15f9a1940c6..924c8daf071a 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -386,7 +386,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane, addr = drm_fb_cma_get_gem_addr(state->fb, state, 0); width = state->src_w >> 16; height = state->src_h >> 16; - cpp = state->fb->format->cpp[plane->index]; + cpp = state->fb->format->cpp[0]; priv->dma_hwdesc->addr = addr; priv->dma_hwdesc->cmd = width * height * cpp / 4; -- 2.27.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index 2020-06-29 23:52 ` [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index Paul Cercueil @ 2020-06-30 11:35 ` Sam Ravnborg 0 siblings, 0 replies; 2+ messages in thread From: Sam Ravnborg @ 2020-06-30 11:35 UTC (permalink / raw) To: Paul Cercueil Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips, dri-devel, linux-kernel, od, stable On Tue, Jun 30, 2020 at 01:52:05AM +0200, Paul Cercueil wrote: > plane->index is NOT the index of the color plane in a YUV frame. > Actually, a YUV frame is represented by a single drm_plane, even though > it contains three Y, U, V planes. > > Cc: stable@vger.kernel.org # v5.3 > Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs") > Signed-off-by: Paul Cercueil <paul@crapouillou.net> Look correct to me. Acked-by: Sam Ravnborg <sam@ravnborg.org> As this is tagged fixes: I assume this is for drm-misc-fixes and not for drm-misc-next. If you resend could you move it as patch 1/10 so this is more obvious. Sam > --- > > Notes: > v2: No change > > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index a15f9a1940c6..924c8daf071a 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -386,7 +386,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane, > addr = drm_fb_cma_get_gem_addr(state->fb, state, 0); > width = state->src_w >> 16; > height = state->src_h >> 16; > - cpp = state->fb->format->cpp[plane->index]; > + cpp = state->fb->format->cpp[0]; > > priv->dma_hwdesc->addr = addr; > priv->dma_hwdesc->cmd = width * height * cpp / 4; > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-30 11:35 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200629235210.441709-1-paul@crapouillou.net> 2020-06-29 23:52 ` [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index Paul Cercueil 2020-06-30 11:35 ` Sam Ravnborg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).