* [PATCH 4.9 00/59] 4.9.226-rc2 review @ 2020-06-02 10:23 Greg Kroah-Hartman 2020-06-02 15:37 ` Guenter Roeck 0 siblings, 1 reply; 7+ messages in thread From: Greg Kroah-Hartman @ 2020-06-02 10:23 UTC (permalink / raw) To: linux-kernel Cc: Greg Kroah-Hartman, torvalds, akpm, linux, shuah, patches, ben.hutchings, lkft-triage, stable This is the start of the stable review cycle for the 4.9.226 release. There are 59 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 04 Jun 2020 10:16:52 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.226-rc2.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Linux 4.9.226-rc2 Benjamin Block <bblock@linux.ibm.com> scsi: zfcp: fix request object use-after-free in send path causing wrong traces Salil Mehta <salil.mehta@huawei.com> net: hns: Fixes the missing put_device in positive leg for roce reset Guoqing Jiang <gqjiang@suse.com> sc16is7xx: move label 'err_spi' to correct section Liviu Dudau <liviu@dudau.co.uk> mm/vmalloc.c: don't dereference possible NULL pointer in __vunmap() Roopa Prabhu <roopa@cumulusnetworks.com> net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags Thomas Gleixner <tglx@linutronix.de> genirq/generic_pending: Do not lose pending affinity update Pablo Neira Ayuso <pablo@netfilter.org> netfilter: nf_conntrack_pptp: fix compilation warning with W=1 build Qiushi Wu <wu000273@umn.edu> bonding: Fix reference count leak in bond_sysfs_slave_add. Qiushi Wu <wu000273@umn.edu> qlcnic: fix missing release in qlcnic_83xx_interrupt_test. Pablo Neira Ayuso <pablo@netfilter.org> netfilter: nf_conntrack_pptp: prevent buffer overflows in debug code Phil Sutter <phil@nwl.cc> netfilter: ipset: Fix subcounter update skip Michael Braun <michael-dev@fami-braun.de> netfilter: nft_reject_bridge: enable reject with bridge vlan Xin Long <lucien.xin@gmail.com> ip_vti: receive ipip packet by calling ip_tunnel_rcv Jeremy Sowden <jeremy@azazel.net> vti4: eliminated some duplicate code. Xin Long <lucien.xin@gmail.com> xfrm: fix a NULL-ptr deref in xfrm_local_error Xin Long <lucien.xin@gmail.com> xfrm: fix a warning in xfrm_policy_insert_list Xin Long <lucien.xin@gmail.com> xfrm: allow to accept packets with ipv6 NEXTHDR_HOP in xfrm_input Alexander Dahl <post@lespocky.de> x86/dma: Fix max PFN arithmetic overflow on 32 bit systems Linus Lüssing <ll@simonwunderlich.de> mac80211: mesh: fix discovery timer re-arming issue / crash Helge Deller <deller@gmx.de> parisc: Fix kernel panic in mem_init() Qiushi Wu <wu000273@umn.edu> iommu: Fix reference count leak in iommu_group_alloc. Arnd Bergmann <arnd@arndb.de> include/asm-generic/topology.h: guard cpumask_of_node() macro argument Alexander Potapenko <glider@google.com> fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info() Konstantin Khlebnikov <khlebnikov@yandex-team.ru> mm: remove VM_BUG_ON(PageSlab()) from page_mapcount() Jerry Lee <leisurelysw24@gmail.com> libceph: ignore pool overlay and cache logic on redirects Eric W. Biederman <ebiederm@xmission.com> exec: Always set cap_ambient in cap_bprm_set_creds Chris Chiu <chiu@endlessm.com> ALSA: usb-audio: mixer: volume quirk for ESS Technology Asus USB DAC Changming Liu <liu.changm@northeastern.edu> ALSA: hwdep: fix a left shifting 1 by 31 UB bug Robert Beckett <bob.beckett@collabora.com> ARM: dts/imx6q-bx50v3: Set display interface clock parents Sebastian Reichel <sebastian.reichel@collabora.co.uk> ARM: dts: imx6q-bx50v3: Add internal switch Martyn Welch <martyn.welch@collabora.co.uk> ARM: dts: imx: Correct B850v3 clock assignment Kaike Wan <kaike.wan@intel.com> IB/qib: Call kobject_put() when kobject_init_and_add() fails Russell King <rmk+kernel@armlinux.org.uk> ARM: uaccess: fix DACR mismatch with nested exceptions Russell King <rmk+kernel@armlinux.org.uk> ARM: uaccess: integrate uaccess_save and uaccess_restore Russell King <rmk+kernel@armlinux.org.uk> ARM: uaccess: consolidate uaccess asm to asm/uaccess-asm.h Stefan Agner <stefan@agner.ch> ARM: 8843/1: use unified assembler in headers Wei Yongjun <weiyongjun1@huawei.com> Input: synaptics-rmi4 - fix error return code in rmi_driver_probe() Kevin Locke <kevin@kevinlocke.name> Input: i8042 - add ThinkPad S230u to i8042 reset list Łukasz Patron <priv.luk@gmail.com> Input: xpad - add custom init packet for Xbox One S controllers Brendan Shanks <bshanks@codeweavers.com> Input: evdev - call input_flush_device() on release(), not flush() James Hilliard <james.hilliard1@gmail.com> Input: usbtouchscreen - add support for BonXeon TP Steve French <stfrench@microsoft.com> cifs: Fix null pointer check in cifs_read Masahiro Yamada <masahiroy@kernel.org> usb: gadget: legacy: fix redundant initialization warnings Lei Xue <carmark.dlut@gmail.com> cachefiles: Fix race between read_waiter and read_copier involving op->to_do Bob Peterson <rpeterso@redhat.com> gfs2: move privileged user check to gfs2_quota_lock_check Chuhong Yuan <hslester96@gmail.com> net: microchip: encx24j600: add missed kthread_stop Stephen Warren <swarren@nvidia.com> gpio: tegra: mask GPIO IRQs during IRQ shutdown Kalderon, Michal <Michal.Kalderon@cavium.com> IB/cma: Fix reference count leak when no ipv4 addresses are set Dmitry V. Levin <ldv@altlinux.org> uapi: fix linux/if_pppol2tp.h userspace compilation errors Qiushi Wu <wu000273@umn.edu> net/mlx4_core: fix a memory leak bug. Qiushi Wu <wu000273@umn.edu> net: sun: fix missing release regions in cas_init_one(). Moshe Shemesh <moshe@mellanox.com> net/mlx5: Add command entry handling completion Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> net: qrtr: Fix passing invalid reference to qrtr_local_enqueue() Moshe Shemesh <moshe@mellanox.com> net/mlx5e: Update netdev txq on completions during closure Jere Leppänen <jere.leppanen@nokia.com> sctp: Start shutdown on association restart if in SHUTDOWN-SENT state and socket is closed Roman Mashak <mrv@mojatatu.com> net sched: fix reporting the first-time use timestamp Yuqi Jin <jinyuqi@huawei.com> net: revert "net: get rid of an signed integer overflow in ip_idents_reserve()" Vadim Fedorenko <vfedorenko@novek.ru> net: ipip: fix wrong address family in init error path Eric Dumazet <edumazet@google.com> ax25: fix setsockopt(SO_BINDTODEVICE) ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/imx6q-b450v3.dts | 7 -- arch/arm/boot/dts/imx6q-b650v3.dts | 7 -- arch/arm/boot/dts/imx6q-b850v3.dts | 11 -- arch/arm/boot/dts/imx6q-bx50v3.dtsi | 77 ++++++++++++++ arch/arm/include/asm/assembler.h | 83 +-------------- arch/arm/include/asm/uaccess-asm.h | 117 +++++++++++++++++++++ arch/arm/include/asm/vfpmacros.h | 8 +- arch/arm/kernel/entry-armv.S | 11 +- arch/arm/kernel/entry-header.S | 9 +- arch/arm/lib/bitops.h | 8 +- arch/parisc/mm/init.c | 2 +- arch/x86/include/asm/dma.h | 2 +- drivers/gpio/gpio-tegra.c | 1 + drivers/infiniband/hw/qib/qib_sysfs.c | 9 +- drivers/input/evdev.c | 19 +--- drivers/input/joystick/xpad.c | 12 +++ drivers/input/rmi4/rmi_driver.c | 3 +- drivers/input/serio/i8042-x86ia64io.h | 7 ++ drivers/input/touchscreen/usbtouchscreen.c | 1 + drivers/iommu/iommu.c | 2 +- drivers/net/bonding/bond_sysfs_slave.c | 4 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 3 + drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 15 +++ drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 6 +- drivers/net/ethernet/microchip/encx24j600.c | 5 +- .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 4 +- drivers/net/ethernet/sun/cassini.c | 3 +- drivers/s390/scsi/zfcp_fsf.c | 10 +- drivers/tty/serial/sc16is7xx.c | 2 + drivers/usb/gadget/legacy/inode.c | 3 +- fs/binfmt_elf.c | 2 +- fs/cachefiles/rdwr.c | 2 +- fs/cifs/file.c | 2 +- fs/gfs2/quota.c | 3 +- fs/gfs2/quota.h | 3 +- include/asm-generic/topology.h | 2 +- include/linux/mlx5/driver.h | 1 + include/linux/mm.h | 15 ++- include/linux/netfilter/nf_conntrack_pptp.h | 2 +- include/net/act_api.h | 3 +- include/rdma/ib_addr.h | 6 +- include/uapi/linux/l2tp.h | 7 +- kernel/irq/migration.c | 26 +++-- mm/vmalloc.c | 2 +- net/ax25/af_ax25.c | 6 +- net/bridge/netfilter/nft_reject_bridge.c | 6 ++ net/ceph/osd_client.c | 4 +- net/core/rtnetlink.c | 2 +- net/ipv4/ip_vti.c | 75 +++++++------ net/ipv4/ipip.c | 2 +- net/ipv4/netfilter/nf_nat_pptp.c | 7 +- net/ipv4/route.c | 14 ++- net/mac80211/mesh_hwmp.c | 7 ++ net/netfilter/ipset/ip_set_list_set.c | 2 +- net/netfilter/nf_conntrack_pptp.c | 62 ++++++----- net/qrtr/qrtr.c | 2 +- net/sctp/sm_statefuns.c | 9 +- net/xfrm/xfrm_input.c | 2 +- net/xfrm/xfrm_output.c | 3 +- net/xfrm/xfrm_policy.c | 7 +- security/commoncap.c | 1 + sound/core/hwdep.c | 4 +- sound/usb/mixer.c | 8 ++ 65 files changed, 473 insertions(+), 283 deletions(-) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4.9 00/59] 4.9.226-rc2 review 2020-06-02 10:23 [PATCH 4.9 00/59] 4.9.226-rc2 review Greg Kroah-Hartman @ 2020-06-02 15:37 ` Guenter Roeck 2020-06-02 16:02 ` Jon Hunter ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Guenter Roeck @ 2020-06-02 15:37 UTC (permalink / raw) To: Greg Kroah-Hartman, linux-kernel Cc: torvalds, akpm, shuah, patches, ben.hutchings, lkft-triage, stable On 6/2/20 3:23 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.226 release. > There are 59 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Thu, 04 Jun 2020 10:16:52 +0000. > Anything received after that time might be too late. > Many arm builds still fail as attached. Is it really only me seeing this problem ? FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified assembler patches be applied ? $ git log --oneline v4.9..c001899a5d6 arch/arm | grep unified c001899a5d6c ARM: 8843/1: use unified assembler in headers a216376add73 ARM: 8841/1: use unified assembler in macros eb7ff9023e4f ARM: 8829/1: spinlock: use unified assembler language syntax 32fdb046ac43 ARM: 8828/1: uaccess: use unified assembler language syntax 1293c2b5d790 ARM: dts: berlin2q: add "cache-unified" to l2 node 75fea300d73a ARM: 8723/2: always assume the "unified" syntax for assembly code I am quite concerned especially about missing commit 75fea300d73a, which removes the ARM_ASM_UNIFIED configuration option. That means it is still present in v4.9.y, but the failing builds don't enable it. Given that, the build failures don't seem to be surprising. Guenter --- Build reference: v4.9.225-60-g6915714f12d0 gcc version: arm-linux-gnueabi-gcc (GCC) 9.3.0 Building arm:allmodconfig ... failed -------------- Error log: arch/arm/vfp/vfphw.S: Assembler messages: arch/arm/vfp/vfphw.S:158: Error: bad instruction `ldclne p11,cr0,[r10],#32*4' arch/arm/vfp/vfphw.S:233: Error: bad instruction `stclne p11,cr0,[r0],#32*4' make[2]: *** [arch/arm/vfp/vfphw.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [arch/arm/vfp] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [sub-make] Error 2 -------------- Building arm:s3c2410_defconfig ... failed -------------- Error log: arch/arm/lib/changebit.S: Assembler messages: arch/arm/lib/changebit.S:15: Error: bad instruction `strbne r1,[ip]' make[2]: *** [arch/arm/lib/changebit.o] Error 1 make[2]: *** Waiting for unfinished jobs.... arch/arm/lib/clear_user.S: Assembler messages: arch/arm/lib/clear_user.S:33: Error: bad instruction `strbtal r2,[r0],#1' arch/arm/lib/clear_user.S:34: Error: bad instruction `strbtle r2,[r0],#1' arch/arm/lib/clear_user.S:35: Error: bad instruction `strbtlt r2,[r0],#1' arch/arm/lib/clear_user.S:39: Error: bad instruction `strtpl r2,[r0],#4' arch/arm/lib/clear_user.S:39: Error: bad instruction `strtpl r2,[r0],#4' arch/arm/lib/clear_user.S:42: Error: bad instruction `strtpl r2,[r0],#4' arch/arm/lib/clear_user.S:44: Error: bad instruction `strbtne r2,[r0],#1' arch/arm/lib/clear_user.S:44: Error: bad instruction `strbtne r2,[r0],#1' make[2]: *** [arch/arm/lib/clear_user.o] Error 1 make[1]: *** [arch/arm/lib] Error 2 make[1]: *** Waiting for unfinished jobs.... Failed builds: arm:allmodconfig arm:s3c2410_defconfig arm:omap2plus_defconfig arm:imx_v6_v7_defconfig arm:ixp4xx_defconfig arm:u8500_defconfig arm:multi_v5_defconfig arm:omap1_defconfig arm:footbridge_defconfig arm:davinci_all_defconfig arm:mini2440_defconfig arm:axm55xx_defconfig arm:mxs_defconfig arm:keystone_defconfig arm:vexpress_defconfig arm:imx_v4_v5_defconfig arm:at91_dt_defconfig arm:s3c6400_defconfig arm:lpc32xx_defconfig arm:shmobile_defconfig arm:nhk8815_defconfig arm:bcm2835_defconfig arm:sama5_defconfig arm:orion5x_defconfig arm:exynos_defconfig arm:cm_x2xx_defconfig arm:s5pv210_defconfig arm:integrator_defconfig arm:pxa910_defconfig arm:clps711x_defconfig ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4.9 00/59] 4.9.226-rc2 review 2020-06-02 15:37 ` Guenter Roeck @ 2020-06-02 16:02 ` Jon Hunter 2020-06-02 16:04 ` Naresh Kamboju 2020-06-02 16:33 ` Sasha Levin 2 siblings, 0 replies; 7+ messages in thread From: Jon Hunter @ 2020-06-02 16:02 UTC (permalink / raw) To: Guenter Roeck, Greg Kroah-Hartman, linux-kernel Cc: torvalds, akpm, shuah, patches, ben.hutchings, lkft-triage, stable On 02/06/2020 16:37, Guenter Roeck wrote: > On 6/2/20 3:23 AM, Greg Kroah-Hartman wrote: >> This is the start of the stable review cycle for the 4.9.226 release. >> There are 59 patches in this series, all will be posted as a response >> to this one. If anyone has any issues with these being applied, please >> let me know. >> >> Responses should be made by Thu, 04 Jun 2020 10:16:52 +0000. >> Anything received after that time might be too late. >> > > Many arm builds still fail as attached. Is it really only me seeing this problem ? No I am seeing this as well. Been having some email problems today ... > FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified > assembler patches be applied ? > > $ git log --oneline v4.9..c001899a5d6 arch/arm | grep unified > c001899a5d6c ARM: 8843/1: use unified assembler in headers Bisect points to this one for me. Cheers Jon -- nvpublic ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4.9 00/59] 4.9.226-rc2 review 2020-06-02 15:37 ` Guenter Roeck 2020-06-02 16:02 ` Jon Hunter @ 2020-06-02 16:04 ` Naresh Kamboju 2020-06-02 16:33 ` Sasha Levin 2 siblings, 0 replies; 7+ messages in thread From: Naresh Kamboju @ 2020-06-02 16:04 UTC (permalink / raw) To: Guenter Roeck Cc: Greg Kroah-Hartman, open list, Linus Torvalds, Andrew Morton, Shuah Khan, patches, Ben Hutchings, lkft-triage, linux- stable, Russell King - ARM Linux + Russell King On Tue, 2 Jun 2020 at 21:07, Guenter Roeck <linux@roeck-us.net> wrote: > > On 6/2/20 3:23 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.226 release. > > There are 59 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Thu, 04 Jun 2020 10:16:52 +0000. > > Anything received after that time might be too late. > > > > Many arm builds still fail as attached. Is it really only me seeing this problem ? > We have noticed this problem. > FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified > assembler patches be applied ? This is reported on stable mailing list https://lore.kernel.org/stable/20200601203710.GR1551@shell.armlinux.org.uk/T/#t > > $ git log --oneline v4.9..c001899a5d6 arch/arm | grep unified > c001899a5d6c ARM: 8843/1: use unified assembler in headers > a216376add73 ARM: 8841/1: use unified assembler in macros > eb7ff9023e4f ARM: 8829/1: spinlock: use unified assembler language syntax > 32fdb046ac43 ARM: 8828/1: uaccess: use unified assembler language syntax > 1293c2b5d790 ARM: dts: berlin2q: add "cache-unified" to l2 node > 75fea300d73a ARM: 8723/2: always assume the "unified" syntax for assembly code > > I am quite concerned especially about missing commit 75fea300d73a, > which removes the ARM_ASM_UNIFIED configuration option. That means it is > still present in v4.9.y, but the failing builds don't enable it. Given that, > the build failures don't seem to be surprising. > > Guenter > > --- > Build reference: v4.9.225-60-g6915714f12d0 > gcc version: arm-linux-gnueabi-gcc (GCC) 9.3.0 > > Building arm:allmodconfig ... failed > -------------- > Error log: > arch/arm/vfp/vfphw.S: Assembler messages: > arch/arm/vfp/vfphw.S:158: Error: bad instruction `ldclne p11,cr0,[r10],#32*4' > arch/arm/vfp/vfphw.S:233: Error: bad instruction `stclne p11,cr0,[r0],#32*4' > make[2]: *** [arch/arm/vfp/vfphw.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [arch/arm/vfp] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [sub-make] Error 2 > -------------- > > Building arm:s3c2410_defconfig ... failed > -------------- > Error log: > arch/arm/lib/changebit.S: Assembler messages: > arch/arm/lib/changebit.S:15: Error: bad instruction `strbne r1,[ip]' > make[2]: *** [arch/arm/lib/changebit.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > arch/arm/lib/clear_user.S: Assembler messages: > arch/arm/lib/clear_user.S:33: Error: bad instruction `strbtal r2,[r0],#1' > arch/arm/lib/clear_user.S:34: Error: bad instruction `strbtle r2,[r0],#1' > arch/arm/lib/clear_user.S:35: Error: bad instruction `strbtlt r2,[r0],#1' > arch/arm/lib/clear_user.S:39: Error: bad instruction `strtpl r2,[r0],#4' > arch/arm/lib/clear_user.S:39: Error: bad instruction `strtpl r2,[r0],#4' > arch/arm/lib/clear_user.S:42: Error: bad instruction `strtpl r2,[r0],#4' > arch/arm/lib/clear_user.S:44: Error: bad instruction `strbtne r2,[r0],#1' > arch/arm/lib/clear_user.S:44: Error: bad instruction `strbtne r2,[r0],#1' > make[2]: *** [arch/arm/lib/clear_user.o] Error 1 > make[1]: *** [arch/arm/lib] Error 2 > make[1]: *** Waiting for unfinished jobs.... > > Failed builds: > arm:allmodconfig > arm:s3c2410_defconfig > arm:omap2plus_defconfig > arm:imx_v6_v7_defconfig > arm:ixp4xx_defconfig > arm:u8500_defconfig > arm:multi_v5_defconfig > arm:omap1_defconfig > arm:footbridge_defconfig > arm:davinci_all_defconfig > arm:mini2440_defconfig > arm:axm55xx_defconfig > arm:mxs_defconfig > arm:keystone_defconfig > arm:vexpress_defconfig > arm:imx_v4_v5_defconfig > arm:at91_dt_defconfig > arm:s3c6400_defconfig > arm:lpc32xx_defconfig > arm:shmobile_defconfig > arm:nhk8815_defconfig > arm:bcm2835_defconfig > arm:sama5_defconfig > arm:orion5x_defconfig > arm:exynos_defconfig > arm:cm_x2xx_defconfig > arm:s5pv210_defconfig > arm:integrator_defconfig > arm:pxa910_defconfig > arm:clps711x_defconfig ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4.9 00/59] 4.9.226-rc2 review 2020-06-02 15:37 ` Guenter Roeck 2020-06-02 16:02 ` Jon Hunter 2020-06-02 16:04 ` Naresh Kamboju @ 2020-06-02 16:33 ` Sasha Levin 2020-06-30 21:46 ` Pavel Machek 2 siblings, 1 reply; 7+ messages in thread From: Sasha Levin @ 2020-06-02 16:33 UTC (permalink / raw) To: Guenter Roeck Cc: Greg Kroah-Hartman, linux-kernel, torvalds, akpm, shuah, patches, ben.hutchings, lkft-triage, stable On Tue, Jun 02, 2020 at 08:37:26AM -0700, Guenter Roeck wrote: >On 6/2/20 3:23 AM, Greg Kroah-Hartman wrote: >> This is the start of the stable review cycle for the 4.9.226 release. >> There are 59 patches in this series, all will be posted as a response >> to this one. If anyone has any issues with these being applied, please >> let me know. >> >> Responses should be made by Thu, 04 Jun 2020 10:16:52 +0000. >> Anything received after that time might be too late. >> > >Many arm builds still fail as attached. Is it really only me seeing this problem ? > >FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified >assembler patches be applied ? We don't - I took 71f8af111010 as a dependency rather than on its own merit. >$ git log --oneline v4.9..c001899a5d6 arch/arm | grep unified >c001899a5d6c ARM: 8843/1: use unified assembler in headers >a216376add73 ARM: 8841/1: use unified assembler in macros >eb7ff9023e4f ARM: 8829/1: spinlock: use unified assembler language syntax >32fdb046ac43 ARM: 8828/1: uaccess: use unified assembler language syntax >1293c2b5d790 ARM: dts: berlin2q: add "cache-unified" to l2 node >75fea300d73a ARM: 8723/2: always assume the "unified" syntax for assembly code > >I am quite concerned especially about missing commit 75fea300d73a, >which removes the ARM_ASM_UNIFIED configuration option. That means it is >still present in v4.9.y, but the failing builds don't enable it. Given that, >the build failures don't seem to be surprising. I'm just going to drop this series from 4.9 for now, until we can figure out how to do it right. -- Thanks, Sasha ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4.9 00/59] 4.9.226-rc2 review 2020-06-02 16:33 ` Sasha Levin @ 2020-06-30 21:46 ` Pavel Machek 2020-07-01 6:55 ` Greg Kroah-Hartman 0 siblings, 1 reply; 7+ messages in thread From: Pavel Machek @ 2020-06-30 21:46 UTC (permalink / raw) To: Sasha Levin Cc: Guenter Roeck, Greg Kroah-Hartman, linux-kernel, torvalds, akpm, shuah, patches, ben.hutchings, lkft-triage, stable [-- Attachment #1: Type: text/plain, Size: 509 bytes --] Hi! > >FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified > >assembler patches be applied ? > > We don't - I took 71f8af111010 as a dependency rather than on its own > merit. Would it be possible to somehow mark patches that are "dependency" rather than "on their own"? It would make review easier... Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4.9 00/59] 4.9.226-rc2 review 2020-06-30 21:46 ` Pavel Machek @ 2020-07-01 6:55 ` Greg Kroah-Hartman 0 siblings, 0 replies; 7+ messages in thread From: Greg Kroah-Hartman @ 2020-07-01 6:55 UTC (permalink / raw) To: Pavel Machek Cc: Sasha Levin, Guenter Roeck, linux-kernel, torvalds, akpm, shuah, patches, ben.hutchings, lkft-triage, stable On Tue, Jun 30, 2020 at 11:46:34PM +0200, Pavel Machek wrote: > Hi! > > > >FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified > > >assembler patches be applied ? > > > > We don't - I took 71f8af111010 as a dependency rather than on its own > > merit. > > Would it be possible to somehow mark patches that are "dependency" > rather than "on their own"? It would make review easier... That's a lot of extra work on our part, and would make the changelog text change, which isn't always liked, sorry. greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-01 6:55 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-06-02 10:23 [PATCH 4.9 00/59] 4.9.226-rc2 review Greg Kroah-Hartman 2020-06-02 15:37 ` Guenter Roeck 2020-06-02 16:02 ` Jon Hunter 2020-06-02 16:04 ` Naresh Kamboju 2020-06-02 16:33 ` Sasha Levin 2020-06-30 21:46 ` Pavel Machek 2020-07-01 6:55 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).