* [PATCH] ALSA: hda/realtek: make bass spk volume adjustable on a yoga laptop
@ 2020-12-04 12:34 Hui Wang
2020-12-04 15:50 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Hui Wang @ 2020-12-04 12:34 UTC (permalink / raw)
To: alsa-devel, tiwai, stable
This also make the headset button work on this machine.
Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
sound/pci/hda/patch_realtek.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 8616c5624870..5a905fa1b33a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -3104,6 +3104,7 @@ static void alc_disable_headset_jack_key(struct hda_codec *codec)
case 0x10ec0215:
case 0x10ec0225:
case 0x10ec0285:
+ case 0x10ec0287:
case 0x10ec0295:
case 0x10ec0289:
case 0x10ec0299:
@@ -3130,6 +3131,7 @@ static void alc_enable_headset_jack_key(struct hda_codec *codec)
case 0x10ec0215:
case 0x10ec0225:
case 0x10ec0285:
+ case 0x10ec0287:
case 0x10ec0295:
case 0x10ec0289:
case 0x10ec0299:
@@ -8578,6 +8580,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
{0x14, 0x90170110},
{0x19, 0x04a11040},
{0x21, 0x04211020}),
+ SND_HDA_PIN_QUIRK(0x10ec0287, 0x17aa, "Lenovo", ALC285_FIXUP_THINKPAD_HEADSET_JACK,
+ {0x14, 0x90170110},
+ {0x17, 0x90170111},
+ {0x19, 0x03a11030},
+ {0x21, 0x03211020}),
SND_HDA_PIN_QUIRK(0x10ec0286, 0x1025, "Acer", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
{0x12, 0x90a60130},
{0x17, 0x90170110},
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: make bass spk volume adjustable on a yoga laptop
2020-12-04 12:34 [PATCH] ALSA: hda/realtek: make bass spk volume adjustable on a yoga laptop Hui Wang
@ 2020-12-04 15:50 ` Takashi Iwai
2020-12-05 2:37 ` Hui Wang
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2020-12-04 15:50 UTC (permalink / raw)
To: Hui Wang; +Cc: alsa-devel, stable
On Fri, 04 Dec 2020 13:34:59 +0100,
Hui Wang wrote:
>
> This also make the headset button work on this machine.
Hm, the description isn't clearly related with the code changes.
Could you elaborate a bit more? The functions you changed are used
commonly, so it needs clarification.
thanks,
Takashi
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
> sound/pci/hda/patch_realtek.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 8616c5624870..5a905fa1b33a 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -3104,6 +3104,7 @@ static void alc_disable_headset_jack_key(struct hda_codec *codec)
> case 0x10ec0215:
> case 0x10ec0225:
> case 0x10ec0285:
> + case 0x10ec0287:
> case 0x10ec0295:
> case 0x10ec0289:
> case 0x10ec0299:
> @@ -3130,6 +3131,7 @@ static void alc_enable_headset_jack_key(struct hda_codec *codec)
> case 0x10ec0215:
> case 0x10ec0225:
> case 0x10ec0285:
> + case 0x10ec0287:
> case 0x10ec0295:
> case 0x10ec0289:
> case 0x10ec0299:
> @@ -8578,6 +8580,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
> {0x14, 0x90170110},
> {0x19, 0x04a11040},
> {0x21, 0x04211020}),
> + SND_HDA_PIN_QUIRK(0x10ec0287, 0x17aa, "Lenovo", ALC285_FIXUP_THINKPAD_HEADSET_JACK,
> + {0x14, 0x90170110},
> + {0x17, 0x90170111},
> + {0x19, 0x03a11030},
> + {0x21, 0x03211020}),
> SND_HDA_PIN_QUIRK(0x10ec0286, 0x1025, "Acer", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
> {0x12, 0x90a60130},
> {0x17, 0x90170110},
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: make bass spk volume adjustable on a yoga laptop
2020-12-04 15:50 ` Takashi Iwai
@ 2020-12-05 2:37 ` Hui Wang
0 siblings, 0 replies; 3+ messages in thread
From: Hui Wang @ 2020-12-05 2:37 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, stable
On 12/4/20 11:50 PM, Takashi Iwai wrote:
> On Fri, 04 Dec 2020 13:34:59 +0100,
> Hui Wang wrote:
>> This also make the headset button work on this machine.
> Hm, the description isn't clearly related with the code changes.
> Could you elaborate a bit more? The functions you changed are used
> commonly, so it needs clarification.
>
>
> thanks,
>
> Takashi
OK, will change the description in the v2.
Thanks,
Hui.
>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>> ---
>> sound/pci/hda/patch_realtek.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 8616c5624870..5a905fa1b33a 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -3104,6 +3104,7 @@ static void alc_disable_headset_jack_key(struct hda_codec *codec)
>> case 0x10ec0215:
>> case 0x10ec0225:
>> case 0x10ec0285:
>> + case 0x10ec0287:
>> case 0x10ec0295:
>> case 0x10ec0289:
>> case 0x10ec0299:
>> @@ -3130,6 +3131,7 @@ static void alc_enable_headset_jack_key(struct hda_codec *codec)
>> case 0x10ec0215:
>> case 0x10ec0225:
>> case 0x10ec0285:
>> + case 0x10ec0287:
>> case 0x10ec0295:
>> case 0x10ec0289:
>> case 0x10ec0299:
>> @@ -8578,6 +8580,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>> {0x14, 0x90170110},
>> {0x19, 0x04a11040},
>> {0x21, 0x04211020}),
>> + SND_HDA_PIN_QUIRK(0x10ec0287, 0x17aa, "Lenovo", ALC285_FIXUP_THINKPAD_HEADSET_JACK,
>> + {0x14, 0x90170110},
>> + {0x17, 0x90170111},
>> + {0x19, 0x03a11030},
>> + {0x21, 0x03211020}),
>> SND_HDA_PIN_QUIRK(0x10ec0286, 0x1025, "Acer", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
>> {0x12, 0x90a60130},
>> {0x17, 0x90170110},
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-05 2:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-04 12:34 [PATCH] ALSA: hda/realtek: make bass spk volume adjustable on a yoga laptop Hui Wang
2020-12-04 15:50 ` Takashi Iwai
2020-12-05 2:37 ` Hui Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).