* [PATCH] io_uring: Try to merge io requests only for regular files
@ 2021-03-19 5:28 Dmitry Monakhov
2021-03-19 6:36 ` Greg KH
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dmitry Monakhov @ 2021-03-19 5:28 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-fsdevel, stable, axboe, Dmitry Monakhov
Otherwise we may endup blocking on pipe or socket.
Fixes: 6d5d5ac ("io_uring: extend async work merge")
Testcase: https://github.com/dmonakhov/liburing/commit/16d171b6ef9d68e6db66650a83d98c5c721d01f6
Signed-off-by: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
---
fs/io_uring.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 478df7e..848657c 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2183,6 +2183,9 @@ static int __io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req,
static struct async_list *io_async_list_from_req(struct io_ring_ctx *ctx,
struct io_kiocb *req)
{
+ if (!(req->flags & REQ_F_ISREG))
+ return NULL;
+
switch (req->submit.opcode) {
case IORING_OP_READV:
case IORING_OP_READ_FIXED:
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] io_uring: Try to merge io requests only for regular files
2021-03-19 5:28 [PATCH] io_uring: Try to merge io requests only for regular files Dmitry Monakhov
@ 2021-03-19 6:36 ` Greg KH
2021-03-19 10:23 ` Pavel Begunkov
2021-03-19 14:06 ` Matthew Wilcox
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-03-19 6:36 UTC (permalink / raw)
To: Dmitry Monakhov; +Cc: linux-kernel, linux-fsdevel, stable, axboe
On Fri, Mar 19, 2021 at 05:28:59AM +0000, Dmitry Monakhov wrote:
> Otherwise we may endup blocking on pipe or socket.
>
> Fixes: 6d5d5ac ("io_uring: extend async work merge")
> Testcase: https://github.com/dmonakhov/liburing/commit/16d171b6ef9d68e6db66650a83d98c5c721d01f6
> Signed-off-by: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
> ---
> fs/io_uring.c | 3 +++
> 1 file changed, 3 insertions(+)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] io_uring: Try to merge io requests only for regular files
2021-03-19 5:28 [PATCH] io_uring: Try to merge io requests only for regular files Dmitry Monakhov
2021-03-19 6:36 ` Greg KH
@ 2021-03-19 10:23 ` Pavel Begunkov
2021-03-19 14:06 ` Matthew Wilcox
2 siblings, 0 replies; 4+ messages in thread
From: Pavel Begunkov @ 2021-03-19 10:23 UTC (permalink / raw)
To: Dmitry Monakhov, linux-kernel; +Cc: linux-fsdevel, stable, axboe, io-uring
On 19/03/2021 05:28, Dmitry Monakhov wrote:
> Otherwise we may endup blocking on pipe or socket.
CC: io-uring ml
>
> Fixes: 6d5d5ac ("io_uring: extend async work merge")
> Testcase: https://github.com/dmonakhov/liburing/commit/16d171b6ef9d68e6db66650a83d98c5c721d01f6
> Signed-off-by: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
> ---
> fs/io_uring.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 478df7e..848657c 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -2183,6 +2183,9 @@ static int __io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req,
> static struct async_list *io_async_list_from_req(struct io_ring_ctx *ctx,
> struct io_kiocb *req)
> {
> + if (!(req->flags & REQ_F_ISREG))
> + return NULL;
> +
> switch (req->submit.opcode) {
> case IORING_OP_READV:
> case IORING_OP_READ_FIXED:
>
--
Pavel Begunkov
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] io_uring: Try to merge io requests only for regular files
2021-03-19 5:28 [PATCH] io_uring: Try to merge io requests only for regular files Dmitry Monakhov
2021-03-19 6:36 ` Greg KH
2021-03-19 10:23 ` Pavel Begunkov
@ 2021-03-19 14:06 ` Matthew Wilcox
2 siblings, 0 replies; 4+ messages in thread
From: Matthew Wilcox @ 2021-03-19 14:06 UTC (permalink / raw)
To: Dmitry Monakhov; +Cc: linux-kernel, linux-fsdevel, stable, axboe
On Fri, Mar 19, 2021 at 05:28:59AM +0000, Dmitry Monakhov wrote:
> Otherwise we may endup blocking on pipe or socket.
>
> Fixes: 6d5d5ac ("io_uring: extend async work merge")
7 bytes of sha1 isn't enough. You can set core.abbrev to 12 or upgrade
to a version of git from this decade to get that automatically.
> 2.7.4
... is from 2016, so you're five years out of date. Don't get cut
off when git switches from SHA1.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-19 14:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 5:28 [PATCH] io_uring: Try to merge io requests only for regular files Dmitry Monakhov
2021-03-19 6:36 ` Greg KH
2021-03-19 10:23 ` Pavel Begunkov
2021-03-19 14:06 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).