* [PATCH 4.19] net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz
@ 2021-07-22 16:38 Marek Behún
2021-07-26 9:24 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Marek Behún @ 2021-07-22 16:38 UTC (permalink / raw)
To: stable; +Cc: gregkh, Marek Behún, Andrew Lunn, David S . Miller
commit 11527f3c4725640e6c40a2b7654e303f45e82a6c upstream.
Commit 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode")
introduced wrong .stats_set_histogram() method for Topaz family.
The Peridot method should be used instead.
Signed-off-by: Marek Behún <kabel@kernel.org>
Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/dsa/mv88e6xxx/chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 7c50d27bab76..1df7aed5ae15 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -3051,7 +3051,7 @@ static const struct mv88e6xxx_ops mv88e6141_ops = {
.port_link_state = mv88e6352_port_link_state,
.port_get_cmode = mv88e6352_port_get_cmode,
.stats_snapshot = mv88e6390_g1_stats_snapshot,
- .stats_set_histogram = mv88e6095_g1_stats_set_histogram,
+ .stats_set_histogram = mv88e6390_g1_stats_set_histogram,
.stats_get_sset_count = mv88e6320_stats_get_sset_count,
.stats_get_strings = mv88e6320_stats_get_strings,
.stats_get_stats = mv88e6390_stats_get_stats,
@@ -3672,7 +3672,7 @@ static const struct mv88e6xxx_ops mv88e6341_ops = {
.port_link_state = mv88e6352_port_link_state,
.port_get_cmode = mv88e6352_port_get_cmode,
.stats_snapshot = mv88e6390_g1_stats_snapshot,
- .stats_set_histogram = mv88e6095_g1_stats_set_histogram,
+ .stats_set_histogram = mv88e6390_g1_stats_set_histogram,
.stats_get_sset_count = mv88e6320_stats_get_sset_count,
.stats_get_strings = mv88e6320_stats_get_strings,
.stats_get_stats = mv88e6390_stats_get_stats,
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4.19] net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz
2021-07-22 16:38 [PATCH 4.19] net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz Marek Behún
@ 2021-07-26 9:24 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-07-26 9:24 UTC (permalink / raw)
To: Marek Behún; +Cc: stable, Andrew Lunn, David S . Miller
On Thu, Jul 22, 2021 at 06:38:32PM +0200, Marek Behún wrote:
> commit 11527f3c4725640e6c40a2b7654e303f45e82a6c upstream.
>
> Commit 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode")
> introduced wrong .stats_set_histogram() method for Topaz family.
>
> The Peridot method should be used instead.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> drivers/net/dsa/mv88e6xxx/chip.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Both now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-26 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 16:38 [PATCH 4.19] net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz Marek Behún
2021-07-26 9:24 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).