* [PATCH v2] mhi: pci_generic: Graceful shutdown on freeze
@ 2021-10-26 17:09 Loic Poulain
2021-10-29 9:28 ` Manivannan Sadhasivam
2021-11-18 6:17 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Loic Poulain @ 2021-10-26 17:09 UTC (permalink / raw)
To: mani; +Cc: linux-arm-msm, hemantk, bbhatt, Loic Poulain, stable
There is no reason for shutting down MHI ungracefully on freeze,
this causes the MHI host stack & device stack to not be aligned
anymore since the proper MHI reset sequence is not performed for
ungraceful shutdown.
Cc: stable@vger.kernel.org
Fixes: 5f0c2ee1fe8d ("bus: mhi: pci-generic: Fix hibernation")
Suggested-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
---
v2: Forgot to mention this change comes from a Bhaumik suggestion
drivers/bus/mhi/pci_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 6a42425..d4a3ce2 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -1018,7 +1018,7 @@ static int __maybe_unused mhi_pci_freeze(struct device *dev)
* context.
*/
if (test_and_clear_bit(MHI_PCI_DEV_STARTED, &mhi_pdev->status)) {
- mhi_power_down(mhi_cntrl, false);
+ mhi_power_down(mhi_cntrl, true);
mhi_unprepare_after_power_down(mhi_cntrl);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mhi: pci_generic: Graceful shutdown on freeze
2021-10-26 17:09 [PATCH v2] mhi: pci_generic: Graceful shutdown on freeze Loic Poulain
@ 2021-10-29 9:28 ` Manivannan Sadhasivam
2021-11-18 6:17 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2021-10-29 9:28 UTC (permalink / raw)
To: Loic Poulain; +Cc: linux-arm-msm, hemantk, bbhatt, stable
On Tue, Oct 26, 2021 at 07:09:40PM +0200, Loic Poulain wrote:
> There is no reason for shutting down MHI ungracefully on freeze,
> this causes the MHI host stack & device stack to not be aligned
> anymore since the proper MHI reset sequence is not performed for
> ungraceful shutdown.
>
> Cc: stable@vger.kernel.org
> Fixes: 5f0c2ee1fe8d ("bus: mhi: pci-generic: Fix hibernation")
> Suggested-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> v2: Forgot to mention this change comes from a Bhaumik suggestion
>
> drivers/bus/mhi/pci_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 6a42425..d4a3ce2 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -1018,7 +1018,7 @@ static int __maybe_unused mhi_pci_freeze(struct device *dev)
> * context.
> */
> if (test_and_clear_bit(MHI_PCI_DEV_STARTED, &mhi_pdev->status)) {
> - mhi_power_down(mhi_cntrl, false);
> + mhi_power_down(mhi_cntrl, true);
> mhi_unprepare_after_power_down(mhi_cntrl);
> }
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mhi: pci_generic: Graceful shutdown on freeze
2021-10-26 17:09 [PATCH v2] mhi: pci_generic: Graceful shutdown on freeze Loic Poulain
2021-10-29 9:28 ` Manivannan Sadhasivam
@ 2021-11-18 6:17 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2021-11-18 6:17 UTC (permalink / raw)
To: Loic Poulain; +Cc: linux-arm-msm, hemantk, bbhatt, stable
On Tue, Oct 26, 2021 at 07:09:40PM +0200, Loic Poulain wrote:
> There is no reason for shutting down MHI ungracefully on freeze,
> this causes the MHI host stack & device stack to not be aligned
> anymore since the proper MHI reset sequence is not performed for
> ungraceful shutdown.
>
> Cc: stable@vger.kernel.org
> Fixes: 5f0c2ee1fe8d ("bus: mhi: pci-generic: Fix hibernation")
> Suggested-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> v2: Forgot to mention this change comes from a Bhaumik suggestion
>
> drivers/bus/mhi/pci_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 6a42425..d4a3ce2 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -1018,7 +1018,7 @@ static int __maybe_unused mhi_pci_freeze(struct device *dev)
> * context.
> */
> if (test_and_clear_bit(MHI_PCI_DEV_STARTED, &mhi_pdev->status)) {
> - mhi_power_down(mhi_cntrl, false);
> + mhi_power_down(mhi_cntrl, true);
> mhi_unprepare_after_power_down(mhi_cntrl);
> }
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-18 6:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 17:09 [PATCH v2] mhi: pci_generic: Graceful shutdown on freeze Loic Poulain
2021-10-29 9:28 ` Manivannan Sadhasivam
2021-11-18 6:17 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).