* [PATCH] arm64: dts: ten64: remove redundant interrupt declaration for gpio-keys
@ 2021-11-22 2:55 Mathew McBride
2021-11-23 12:26 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Mathew McBride @ 2021-11-22 2:55 UTC (permalink / raw)
To: Shawn Guo, Li Yang, linux-arm-kernel, devicetree, Rob Herring
Cc: Mathew McBride, stable
gpio-keys already 'inherits' the interrupts from the controller
of the specified GPIO, so having another declaration is redundant.
On >=v5.15 this started causing an oops under gpio_keys_probe as
the IRQ was already claimed.
Signed-off-by: Mathew McBride <matt@traverse.com.au>
Fixes: 418962eea358 ("arm64: dts: add device tree for Traverse Ten64 (LS1088A)")
Cc: stable@vger.kernel.org
---
arch/arm64/boot/dts/freescale/fsl-ls1088a-ten64.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-ten64.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-ten64.dts
index 3063851c2fb9..d3f03dcbb8c3 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-ten64.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-ten64.dts
@@ -38,7 +38,6 @@ buttons {
powerdn {
label = "External Power Down";
gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
- interrupts = <&gpio1 17 IRQ_TYPE_EDGE_FALLING>;
linux,code = <KEY_POWER>;
};
@@ -46,7 +45,6 @@ powerdn {
admin {
label = "ADMIN button";
gpios = <&gpio3 8 GPIO_ACTIVE_HIGH>;
- interrupts = <&gpio3 8 IRQ_TYPE_EDGE_RISING>;
linux,code = <KEY_WPS_BUTTON>;
};
};
--
2.30.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: ten64: remove redundant interrupt declaration for gpio-keys
2021-11-22 2:55 [PATCH] arm64: dts: ten64: remove redundant interrupt declaration for gpio-keys Mathew McBride
@ 2021-11-23 12:26 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2021-11-23 12:26 UTC (permalink / raw)
To: Mathew McBride; +Cc: Li Yang, linux-arm-kernel, devicetree, Rob Herring, stable
On Mon, Nov 22, 2021 at 02:55:54AM +0000, Mathew McBride wrote:
> gpio-keys already 'inherits' the interrupts from the controller
> of the specified GPIO, so having another declaration is redundant.
> On >=v5.15 this started causing an oops under gpio_keys_probe as
> the IRQ was already claimed.
>
> Signed-off-by: Mathew McBride <matt@traverse.com.au>
> Fixes: 418962eea358 ("arm64: dts: add device tree for Traverse Ten64 (LS1088A)")
> Cc: stable@vger.kernel.org
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-23 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 2:55 [PATCH] arm64: dts: ten64: remove redundant interrupt declaration for gpio-keys Mathew McBride
2021-11-23 12:26 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).