* [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250
@ 2021-12-30 19:53 ` Krzysztof Kozlowski
2021-12-30 19:53 ` [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2 Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-12-30 19:53 UTC (permalink / raw)
To: Krzysztof Kozlowski, Marek Szyprowski, Jaehoon Chung,
Chanho Park, Sam Protsenko, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Sylwester Nawrocki, stable
The gpa1-4 pin was put twice in UART3 pin configuration of Exynos5250,
instead of proper pin gpa1-5.
Fixes: f8bfe2b050f3 ("ARM: dts: add pin state information in client nodes for Exynos5 platforms")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
index d31a68672bfa..d7d756614edd 100644
--- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
@@ -260,7 +260,7 @@ i2c3_hs_bus: i2c3-hs-bus {
};
uart3_data: uart3-data {
- samsung,pins = "gpa1-4", "gpa1-4";
+ samsung,pins = "gpa1-4", "gpa1-5";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2
2021-12-30 19:53 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Krzysztof Kozlowski
@ 2021-12-30 19:53 ` Krzysztof Kozlowski
2021-12-31 12:02 ` Krzysztof Kozlowski
2022-01-06 18:13 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Alim Akhtar
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-12-30 19:53 UTC (permalink / raw)
To: Krzysztof Kozlowski, Marek Szyprowski, Jaehoon Chung,
Chanho Park, Sam Protsenko, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Sylwester Nawrocki, stable
Each pin configuration in pin controller should be a node with
"samsung,pins" and other similar properties. However the macro PIN()
(used for initial/sleep states) defines entire node, so PCIe WLAN pin
configuration node was ignored.
Fixes: 98c03b6eef3f ("arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index cbcc01a66aab..c5054c7a9c03 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -1104,8 +1104,11 @@ &pinctrl_ese {
pinctrl-names = "default";
pinctrl-0 = <&initial_ese>;
- pcie_wlanen: pcie-wlanen {
- PIN(INPUT, gpj2-0, UP, FAST_SR4);
+ pcie_wlanen: pcie-wlanen-pins {
+ samsung,pins = "gpj2-0";
+ samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
+ samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+ samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR4>;
};
initial_ese: initial-state {
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2
2021-12-30 19:53 ` [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2 Krzysztof Kozlowski
@ 2021-12-31 12:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-12-31 12:02 UTC (permalink / raw)
To: Marek Szyprowski, Jaehoon Chung, Chanho Park, Sam Protsenko,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Sylwester Nawrocki, stable
On 30/12/2021 20:53, Krzysztof Kozlowski wrote:
> Each pin configuration in pin controller should be a node with
> "samsung,pins" and other similar properties. However the macro PIN()
> (used for initial/sleep states) defines entire node, so PCIe WLAN pin
> configuration node was ignored.
>
> Fixes: 98c03b6eef3f ("arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
This patch is not correct, because the driver/bindings allow and work
with such DTS. Please ignore.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250
2021-12-30 19:53 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Krzysztof Kozlowski
2021-12-30 19:53 ` [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2 Krzysztof Kozlowski
@ 2022-01-06 18:13 ` Alim Akhtar
2022-01-10 22:20 ` Marek Szyprowski
2022-01-23 17:10 ` (subset) " Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2022-01-06 18:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Marek Szyprowski, Jaehoon Chung, Chanho Park, Sam Protsenko,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Sylwester Nawrocki, stable
Hi Krzysztof
On Fri, Dec 31, 2021 at 4:02 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The gpa1-4 pin was put twice in UART3 pin configuration of Exynos5250,
> instead of proper pin gpa1-5.
>
> Fixes: f8bfe2b050f3 ("ARM: dts: add pin state information in client nodes for Exynos5 platforms")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Thanks for fixing this.
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> index d31a68672bfa..d7d756614edd 100644
> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> @@ -260,7 +260,7 @@ i2c3_hs_bus: i2c3-hs-bus {
> };
>
> uart3_data: uart3-data {
> - samsung,pins = "gpa1-4", "gpa1-4";
> + samsung,pins = "gpa1-4", "gpa1-5";
> samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> --
> 2.32.0
>
--
Regards,
Alim
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250
2021-12-30 19:53 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Krzysztof Kozlowski
2021-12-30 19:53 ` [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2 Krzysztof Kozlowski
2022-01-06 18:13 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Alim Akhtar
@ 2022-01-10 22:20 ` Marek Szyprowski
2022-01-23 17:10 ` (subset) " Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Marek Szyprowski @ 2022-01-10 22:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, Jaehoon Chung, Chanho Park, Sam Protsenko,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Sylwester Nawrocki, stable
On 30.12.2021 20:53, Krzysztof Kozlowski wrote:
> The gpa1-4 pin was put twice in UART3 pin configuration of Exynos5250,
> instead of proper pin gpa1-5.
>
> Fixes: f8bfe2b050f3 ("ARM: dts: add pin state information in client nodes for Exynos5 platforms")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Well, the uart3_data node is not referenced anywhere, so this change is
not really relevant to any board, but for the completeness, feel free to
add:
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> index d31a68672bfa..d7d756614edd 100644
> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> @@ -260,7 +260,7 @@ i2c3_hs_bus: i2c3-hs-bus {
> };
>
> uart3_data: uart3-data {
> - samsung,pins = "gpa1-4", "gpa1-4";
> + samsung,pins = "gpa1-4", "gpa1-5";
> samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250
2021-12-30 19:53 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-01-10 22:20 ` Marek Szyprowski
@ 2022-01-23 17:10 ` Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-01-23 17:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-samsung-soc, Chanho Park,
Marek Szyprowski, Jaehoon Chung, devicetree, linux-arm-kernel,
Sam Protsenko, linux-kernel
Cc: stable, Sylwester Nawrocki
On Thu, 30 Dec 2021 20:53:23 +0100, Krzysztof Kozlowski wrote:
> The gpa1-4 pin was put twice in UART3 pin configuration of Exynos5250,
> instead of proper pin gpa1-5.
>
>
Applied, thanks!
[1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250
commit: 372d7027fed43c8570018e124cf78b89523a1f8e
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-23 17:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20211230195340eucas1p1ebbcf10a6b4fb15fca9b7757af5e1702@eucas1p1.samsung.com>
2021-12-30 19:53 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Krzysztof Kozlowski
2021-12-30 19:53 ` [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2 Krzysztof Kozlowski
2021-12-31 12:02 ` Krzysztof Kozlowski
2022-01-06 18:13 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Alim Akhtar
2022-01-10 22:20 ` Marek Szyprowski
2022-01-23 17:10 ` (subset) " Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).