* [PATCH v2] thermal: int340x: Increase bitmap size
@ 2022-03-14 22:08 Srinivas Pandruvada
2022-03-16 18:37 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Pandruvada @ 2022-03-14 22:08 UTC (permalink / raw)
To: rafael, daniel.lezcano, amitk, rui.zhang
Cc: linux-pm, linux-kernel, David.Laight, Srinivas Pandruvada, stable
The number of policies are 10, so can't be supported by the bitmap size
of u8. Even though there are no platfoms with these many policies, but
as correctness increase to u32.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Fixes: 16fc8eca1975 ("thermal/int340x_thermal: Add additional UUIDs")
Cc: stable@vger.kernel.org
---
v2
- Changed u16 to u32 for better alignment as suggested by David
drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
index 72acb1f61849..348b1f4ef801 100644
--- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
@@ -53,7 +53,7 @@ struct int3400_thermal_priv {
struct art *arts;
int trt_count;
struct trt *trts;
- u8 uuid_bitmap;
+ u32 uuid_bitmap;
int rel_misc_dev_res;
int current_uuid_index;
char *data_vault;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] thermal: int340x: Increase bitmap size
2022-03-14 22:08 [PATCH v2] thermal: int340x: Increase bitmap size Srinivas Pandruvada
@ 2022-03-16 18:37 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2022-03-16 18:37 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang, Rui,
Linux PM, Linux Kernel Mailing List, David Laight, Stable
On Mon, Mar 14, 2022 at 11:09 PM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> The number of policies are 10, so can't be supported by the bitmap size
> of u8. Even though there are no platfoms with these many policies, but
> as correctness increase to u32.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Fixes: 16fc8eca1975 ("thermal/int340x_thermal: Add additional UUIDs")
> Cc: stable@vger.kernel.org
> ---
> v2
> - Changed u16 to u32 for better alignment as suggested by David
>
> drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index 72acb1f61849..348b1f4ef801 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -53,7 +53,7 @@ struct int3400_thermal_priv {
> struct art *arts;
> int trt_count;
> struct trt *trts;
> - u8 uuid_bitmap;
> + u32 uuid_bitmap;
> int rel_misc_dev_res;
> int current_uuid_index;
> char *data_vault;
> --
Applied as 5.18 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-16 18:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 22:08 [PATCH v2] thermal: int340x: Increase bitmap size Srinivas Pandruvada
2022-03-16 18:37 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).