From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Changbin Du <changbin.du@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
jirislaby@kernel.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
linux-riscv@lists.infradead.org
Subject: [PATCH AUTOSEL 5.17 17/60] sysrq: do not omit current cpu when showing backtrace of all active CPUs
Date: Tue, 7 Jun 2022 13:52:14 -0400 [thread overview]
Message-ID: <20220607175259.478835-17-sashal@kernel.org> (raw)
In-Reply-To: <20220607175259.478835-1-sashal@kernel.org>
From: Changbin Du <changbin.du@gmail.com>
[ Upstream commit 5390e7f46b9d5546d45a83e6463bc656678b1d0e ]
The backtrace of current CPU also should be printed as it is active. This
change add stack trace for current CPU and print a hint for idle CPU for
the generic workqueue based printing. (x86 already does this)
Now it looks like below:
[ 279.401567] sysrq: Show backtrace of all active CPUs
[ 279.407234] sysrq: CPU5:
[ 279.407505] Call Trace:
[ 279.408789] [<ffffffff8000606c>] dump_backtrace+0x2c/0x3a
[ 279.411698] [<ffffffff800060ac>] show_stack+0x32/0x3e
[ 279.411809] [<ffffffff80542258>] sysrq_handle_showallcpus+0x4c/0xc6
[ 279.411929] [<ffffffff80542f16>] __handle_sysrq+0x106/0x26c
[ 279.412034] [<ffffffff805436a8>] write_sysrq_trigger+0x64/0x74
[ 279.412139] [<ffffffff8029cd48>] proc_reg_write+0x8e/0xe2
[ 279.412252] [<ffffffff8021a8f8>] vfs_write+0x90/0x2be
[ 279.412362] [<ffffffff8021acd2>] ksys_write+0xa6/0xce
[ 279.412467] [<ffffffff8021ad24>] sys_write+0x2a/0x38
[ 279.412689] [<ffffffff80003ff8>] ret_from_syscall+0x0/0x2
[ 279.417173] sysrq: CPU6: backtrace skipped as idling
[ 279.417185] sysrq: CPU4: backtrace skipped as idling
[ 279.417187] sysrq: CPU0: backtrace skipped as idling
[ 279.417181] sysrq: CPU7: backtrace skipped as idling
[ 279.417190] sysrq: CPU1: backtrace skipped as idling
[ 279.417193] sysrq: CPU3: backtrace skipped as idling
[ 279.417219] sysrq: CPU2:
[ 279.419179] Call Trace:
[ 279.419440] [<ffffffff8000606c>] dump_backtrace+0x2c/0x3a
[ 279.419782] [<ffffffff800060ac>] show_stack+0x32/0x3e
[ 279.420015] [<ffffffff80542b30>] showacpu+0x5c/0x96
[ 279.420317] [<ffffffff800ba71c>] flush_smp_call_function_queue+0xd6/0x218
[ 279.420569] [<ffffffff800bb438>] generic_smp_call_function_single_interrupt+0x14/0x1c
[ 279.420798] [<ffffffff800079ae>] handle_IPI+0xaa/0x13a
[ 279.421024] [<ffffffff804dcb92>] riscv_intc_irq+0x56/0x70
[ 279.421274] [<ffffffff80a05b70>] generic_handle_arch_irq+0x6a/0xfa
[ 279.421518] [<ffffffff80004006>] ret_from_exception+0x0/0x10
[ 279.421750] [<ffffffff80096492>] rcu_idle_enter+0x16/0x1e
Signed-off-by: Changbin Du <changbin.du@gmail.com>
Link: https://lore.kernel.org/r/20220117154300.2808-1-changbin.du@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/tty/sysrq.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index bbfd004449b5..34cfdda4aff5 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -232,8 +232,10 @@ static void showacpu(void *dummy)
unsigned long flags;
/* Idle CPUs have no interesting backtrace. */
- if (idle_cpu(smp_processor_id()))
+ if (idle_cpu(smp_processor_id())) {
+ pr_info("CPU%d: backtrace skipped as idling\n", smp_processor_id());
return;
+ }
raw_spin_lock_irqsave(&show_lock, flags);
pr_info("CPU%d:\n", smp_processor_id());
@@ -260,10 +262,13 @@ static void sysrq_handle_showallcpus(int key)
if (in_hardirq())
regs = get_irq_regs();
- if (regs) {
- pr_info("CPU%d:\n", smp_processor_id());
+
+ pr_info("CPU%d:\n", smp_processor_id());
+ if (regs)
show_regs(regs);
- }
+ else
+ show_stack(NULL, NULL, KERN_INFO);
+
schedule_work(&sysrq_showallcpus);
}
}
--
2.35.1
next prev parent reply other threads:[~2022-06-07 18:24 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 17:51 [PATCH AUTOSEL 5.17 01/60] iio: dummy: iio_simple_dummy: check the return value of kstrdup() Sasha Levin
2022-06-07 17:51 ` [PATCH AUTOSEL 5.17 02/60] staging: rtl8712: fix a potential memory leak in r871xu_drv_init() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 03/60] iio: st_sensors: Add a local lock for protecting odr Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 04/60] lkdtm/usercopy: Expand size of "out of frame" object Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 05/60] drivers: staging: rtl8723bs: Fix deadlock in rtw_surveydone_event_callback() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 06/60] drivers: staging: rtl8192bs: Fix deadlock in rtw_joinbss_event_prehandle() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 07/60] tty: synclink_gt: Fix null-pointer-dereference in slgt_clean() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 08/60] tty: Fix a possible resource leak in icom_probe Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 09/60] thunderbolt: Use different lane for second DisplayPort tunnel Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 10/60] drivers: staging: rtl8192u: Fix deadlock in ieee80211_beacons_stop() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 11/60] drivers: staging: rtl8192e: Fix deadlock in rtllib_beacons_stop() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 12/60] USB: host: isp116x: check return value after calling platform_get_resource() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 13/60] drivers: tty: serial: Fix deadlock in sa1100_set_termios() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 14/60] drivers: usb: host: Fix deadlock in oxu_bus_suspend() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 15/60] USB: hcd-pci: Fully suspend across freeze/thaw cycle Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 16/60] char: xillybus: fix a refcount leak in cleanup_dev() Sasha Levin
2022-06-07 17:52 ` Sasha Levin [this message]
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 18/60] usb: dwc2: gadget: don't reset gadget's driver->bus Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 19/60] usb: dwc3: host: Stop setting the ACPI companion Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 20/60] soundwire: qcom: adjust autoenumeration timeout Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 21/60] misc: rtsx: set NULL intfdata when probe fails Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 22/60] extcon: Fix extcon_get_extcon_dev() error handling Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 23/60] extcon: Modify extcon device to be created after driver data is set Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 24/60] clocksource/drivers/sp804: Avoid error on multiple instances Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 25/60] staging: rtl8723bs: Fix alignment to match open parenthesis Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 26/60] staging: rtl8712: fix uninit-value in usb_read8() and friends Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 27/60] staging: rtl8712: fix uninit-value in r871xu_drv_init() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 28/60] serial: msm_serial: disable interrupts in __msm_console_write() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 29/60] accessiblity: speakup: Add missing misc_deregister in softsynth_probe Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 30/60] kernfs: Separate kernfs_pr_cont_buf and rename_lock Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 31/60] watchdog: wdat_wdt: Stop watchdog when rebooting the system Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 32/60] ksmbd: smbd: fix connection dropped issue Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 33/60] md: don't unregister sync_thread with reconfig_mutex held Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 34/60] md: protect md_unregister_thread from reentrancy Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 35/60] scsi: myrb: Fix up null pointer access on myrb_cleanup() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 36/60] ASoC: rt5640: Do not manipulate pin "Platform Clock" if the "Platform Clock" is not in the DAPM Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 37/60] Revert "net: af_key: add check for pfkey_broadcast in function pfkey_process" Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 38/60] ceph: allow ceph.dir.rctime xattr to be updatable Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 39/60] ceph: flush the mdlog for filesystem sync Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 40/60] net, neigh: Set lower cap for neigh_managed_work rearming Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 41/60] drm/amd/display: Check if modulo is 0 before dividing Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 42/60] drm/radeon: fix a possible null pointer dereference Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 43/60] drm/amd/pm: fix a potential gpu_metrics_table memory leak Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 44/60] drm/amd/pm: Fix missing thermal throttler status Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 45/60] um: line: Use separate IRQs per line Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 46/60] modpost: fix undefined behavior of is_arm_mapping_symbol() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 47/60] x86/cpu: Elide KCSAN for cpu_has() and friends Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 48/60] jump_label,noinstr: Avoid instrumentation for JUMP_LABEL=n builds Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 49/60] nbd: call genl_unregister_family() first in nbd_cleanup() Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 50/60] nbd: fix race between nbd_alloc_config() and module removal Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 51/60] nbd: fix io hung while disconnecting device Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 52/60] fs/ntfs3: Fix invalid free in log_replay Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 53/60] Revert "PCI: brcmstb: Do not turn off WOL regulators on suspend" Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 54/60] Revert "PCI: brcmstb: Add control of subdevice voltage regulators" Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 55/60] Revert "PCI: brcmstb: Add mechanism to turn on subdev regulators" Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 56/60] Revert "PCI: brcmstb: Split brcm_pcie_setup() into two funcs" Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 57/60] s390/gmap: voluntarily schedule during key setting Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 58/60] cifs: version operations for smb20 unneeded when legacy support disabled Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 59/60] drm/amd/pm: use bitmap_{from,to}_arr32 where appropriate Sasha Levin
2022-06-07 17:52 ` [PATCH AUTOSEL 5.17 60/60] nodemask: Fix return values to be unsigned Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607175259.478835-17-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=changbin.du@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).