[PATCH linux-5.4.y only] Revert "net: dsa: b53: Fix valid setting for MDB entries"

[PATCH linux-5.4.y only] Revert "net: dsa: b53: Fix valid setting for MDB entries"

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

This reverts commit 1fae6eb0fc91d3ecb539e03f9e4dcd1c53ada553.

Upstream commit was a fix for an overlook of setting "ent.is_valid"
twice after 5d65b64a3d97 ("net: dsa: b53: Add support for MDB").

Since MDB support was not backported to stable kernels (it's not a bug
fix) there is nothing to fix there. Backporting this commit resulted in
"env.is_valid" not being set at all.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/net/dsa/b53/b53_common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
index 825d840cdb8c..1458416f4f91 100644
--- a/drivers/net/dsa/b53/b53_common.c
+++ b/drivers/net/dsa/b53/b53_common.c
@@ -1551,6 +1551,7 @@ static int b53_arl_op(struct b53_device *dev, int op, int port,
 
 	memset(&ent, 0, sizeof(ent));
 	ent.port = port;
+	ent.is_valid = is_valid;
 	ent.vid = vid;
 	ent.is_static = true;
 	memcpy(ent.mac, addr, ETH_ALEN);
-- 
2.34.1

Re: [PATCH linux-5.4.y only] Revert "net: dsa: b53: Fix valid setting for MDB entries"

[Florian Fainelli]

On 12/6/22 23:01, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This reverts commit 1fae6eb0fc91d3ecb539e03f9e4dcd1c53ada553.
> 
> Upstream commit was a fix for an overlook of setting "ent.is_valid"
> twice after 5d65b64a3d97 ("net: dsa: b53: Add support for MDB").
> 
> Since MDB support was not backported to stable kernels (it's not a bug
> fix) there is nothing to fix there. Backporting this commit resulted in
> "env.is_valid" not being set at all.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks for catching this!
-- 
Florian