* [PATCH RESEND] perf/core: Call LSM hook after copying perf_event_attr
@ 2022-12-20 22:31 Namhyung Kim
2022-12-27 11:51 ` [tip: perf/urgent] " tip-bot2 for Namhyung Kim
0 siblings, 1 reply; 2+ messages in thread
From: Namhyung Kim @ 2022-12-20 22:31 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Ingo Molnar, Mark Rutland, Alexander Shishkin,
Arnaldo Carvalho de Melo, Jiri Olsa, LKML, KP Singh, stable,
Joel Fernandes
It passes the attr struct to the security_perf_event_open() but it's
not initialized yet.
Fixes: da97e18458fb ("perf_event: Add support for LSM and SELinux checks")
Cc: stable@vger.kernel.org
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
kernel/events/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 65e20c5c3c44..5d7193d3ffef 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -12293,12 +12293,12 @@ SYSCALL_DEFINE5(perf_event_open,
if (flags & ~PERF_FLAG_ALL)
return -EINVAL;
- /* Do we allow access to perf_event_open(2) ? */
- err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
+ err = perf_copy_attr(attr_uptr, &attr);
if (err)
return err;
- err = perf_copy_attr(attr_uptr, &attr);
+ /* Do we allow access to perf_event_open(2) ? */
+ err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
if (err)
return err;
--
2.39.0.314.g84b9a713c41-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: perf/urgent] perf/core: Call LSM hook after copying perf_event_attr
2022-12-20 22:31 [PATCH RESEND] perf/core: Call LSM hook after copying perf_event_attr Namhyung Kim
@ 2022-12-27 11:51 ` tip-bot2 for Namhyung Kim
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Namhyung Kim @ 2022-12-27 11:51 UTC (permalink / raw)
To: linux-tip-commits
Cc: Namhyung Kim, Peter Zijlstra (Intel), Joel Fernandes (Google),
stable, x86, linux-kernel
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: 0a041ebca4956292cadfb14a63ace3a9c1dcb0a3
Gitweb: https://git.kernel.org/tip/0a041ebca4956292cadfb14a63ace3a9c1dcb0a3
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 20 Dec 2022 14:31:40 -08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 27 Dec 2022 12:44:01 +01:00
perf/core: Call LSM hook after copying perf_event_attr
It passes the attr struct to the security_perf_event_open() but it's
not initialized yet.
Fixes: da97e18458fb ("perf_event: Add support for LSM and SELinux checks")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20221220223140.4020470-1-namhyung@kernel.org
---
kernel/events/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 63d674c..d56328e 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -12321,12 +12321,12 @@ SYSCALL_DEFINE5(perf_event_open,
if (flags & ~PERF_FLAG_ALL)
return -EINVAL;
- /* Do we allow access to perf_event_open(2) ? */
- err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
+ err = perf_copy_attr(attr_uptr, &attr);
if (err)
return err;
- err = perf_copy_attr(attr_uptr, &attr);
+ /* Do we allow access to perf_event_open(2) ? */
+ err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
if (err)
return err;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-27 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-20 22:31 [PATCH RESEND] perf/core: Call LSM hook after copying perf_event_attr Namhyung Kim
2022-12-27 11:51 ` [tip: perf/urgent] " tip-bot2 for Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).