* [PATCH 2/6] ARM: dts: exynos: correct TMU phandle in Exynos4210
2023-02-09 10:58 [PATCH 1/6] ARM: dts: exynos: correct TMU phandle in Exynos4 Krzysztof Kozlowski
@ 2023-02-09 10:58 ` Krzysztof Kozlowski
2023-02-09 10:58 ` [PATCH 3/6] ARM: dts: exynos: correct TMU phandle in Exynos5250 Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-09 10:58 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Eduardo Valentin,
Lukasz Majewski, Kukjin Kim, Javier Martinez Canillas,
Marek Szyprowski, Anand Moon, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Krzysztof Kozlowski, stable
TMU node uses 0 as thermal-sensor-cells, thus thermal zone referencing
it must not have an argument to phandle. Since thermal-sensors property is
already defined in included exynos4-cpu-thermal.dtsi, drop it from
exynos4210.dtsi to fix the error and remoev redundancy.
Fixes: 9843a2236003 ("ARM: dts: Provide dt bindings identical for Exynos TMU")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/exynos4210.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index 5a1ec714c612..0e27c3375e2e 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -393,7 +393,6 @@ &cpu_alert2 {
&cpu_thermal {
polling-delay-passive = <0>;
polling-delay = <0>;
- thermal-sensors = <&tmu 0>;
};
&gic {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/6] ARM: dts: exynos: correct TMU phandle in Exynos5250
2023-02-09 10:58 [PATCH 1/6] ARM: dts: exynos: correct TMU phandle in Exynos4 Krzysztof Kozlowski
2023-02-09 10:58 ` [PATCH 2/6] ARM: dts: exynos: correct TMU phandle in Exynos4210 Krzysztof Kozlowski
@ 2023-02-09 10:58 ` Krzysztof Kozlowski
2023-02-09 10:58 ` [PATCH 4/6] ARM: dts: exynos: correct TMU phandle in Odroid XU Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-09 10:58 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Eduardo Valentin,
Lukasz Majewski, Kukjin Kim, Javier Martinez Canillas,
Marek Szyprowski, Anand Moon, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Krzysztof Kozlowski, stable
TMU node uses 0 as thermal-sensor-cells, thus thermal zone referencing
it must not have an argument to phandle.
Cc: <stable@vger.kernel.org>
Fixes: 9843a2236003 ("ARM: dts: Provide dt bindings identical for Exynos TMU")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/exynos5250.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index c76c3a79bbc6..89c8665ac9aa 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -1105,7 +1105,7 @@ timer {
&cpu_thermal {
polling-delay-passive = <0>;
polling-delay = <0>;
- thermal-sensors = <&tmu 0>;
+ thermal-sensors = <&tmu>;
cooling-maps {
map0 {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/6] ARM: dts: exynos: correct TMU phandle in Odroid XU
2023-02-09 10:58 [PATCH 1/6] ARM: dts: exynos: correct TMU phandle in Exynos4 Krzysztof Kozlowski
2023-02-09 10:58 ` [PATCH 2/6] ARM: dts: exynos: correct TMU phandle in Exynos4210 Krzysztof Kozlowski
2023-02-09 10:58 ` [PATCH 3/6] ARM: dts: exynos: correct TMU phandle in Exynos5250 Krzysztof Kozlowski
@ 2023-02-09 10:58 ` Krzysztof Kozlowski
2023-02-09 10:58 ` [PATCH 5/6] ARM: dts: exynos: correct TMU phandle in Odroid HC1 Krzysztof Kozlowski
2023-02-09 10:58 ` [PATCH 6/6] ARM: dts: exynos: correct TMU phandle in Odroid XU3 family Krzysztof Kozlowski
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-09 10:58 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Eduardo Valentin,
Lukasz Majewski, Kukjin Kim, Javier Martinez Canillas,
Marek Szyprowski, Anand Moon, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Krzysztof Kozlowski, stable
TMU node uses 0 as thermal-sensor-cells, thus thermal zone referencing
it must not have an argument to phandle. Since thermal-sensors property
is already defined in included exynosi5410.dtsi, drop it from
exynos5410-odroidxu.dts to fix the error and remoev redundancy.
Fixes: 88644b4c750b ("ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/exynos5410-odroidxu.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 232561620da2..6ddd1dd2fb0b 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -120,7 +120,6 @@ &clock_audss {
};
&cpu0_thermal {
- thermal-sensors = <&tmu_cpu0 0>;
polling-delay-passive = <0>;
polling-delay = <0>;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 5/6] ARM: dts: exynos: correct TMU phandle in Odroid HC1
2023-02-09 10:58 [PATCH 1/6] ARM: dts: exynos: correct TMU phandle in Exynos4 Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-02-09 10:58 ` [PATCH 4/6] ARM: dts: exynos: correct TMU phandle in Odroid XU Krzysztof Kozlowski
@ 2023-02-09 10:58 ` Krzysztof Kozlowski
2023-02-09 10:58 ` [PATCH 6/6] ARM: dts: exynos: correct TMU phandle in Odroid XU3 family Krzysztof Kozlowski
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-09 10:58 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Eduardo Valentin,
Lukasz Majewski, Kukjin Kim, Javier Martinez Canillas,
Marek Szyprowski, Anand Moon, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Krzysztof Kozlowski, stable
TMU node uses 0 as thermal-sensor-cells, thus thermal zone referencing
it must not have an argument to phandle. This was not critical before,
but since rework of thermal Devicetree initialization in the
commit 3fd6d6e2b4e8 ("thermal/of: Rework the thermal device tree
initialization"), this leads to errors registering thermal zones other
than first one:
thermal_sys: cpu0-thermal: Failed to read thermal-sensors cells: -2
thermal_sys: Failed to find thermal zone for tmu id=0
exynos-tmu 10064000.tmu: Failed to register sensor: -2
exynos-tmu: probe of 10064000.tmu failed with error -2
Fixes: 1ac49427b566 ("ARM: dts: exynos: Add support for Hardkernel's Odroid HC1 board")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/exynos5422-odroidhc1.dts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5422-odroidhc1.dts b/arch/arm/boot/dts/exynos5422-odroidhc1.dts
index 3de7019572a2..5e4280393706 100644
--- a/arch/arm/boot/dts/exynos5422-odroidhc1.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidhc1.dts
@@ -31,7 +31,7 @@ led-1 {
thermal-zones {
cpu0_thermal: cpu0-thermal {
- thermal-sensors = <&tmu_cpu0 0>;
+ thermal-sensors = <&tmu_cpu0>;
trips {
cpu0_alert0: cpu-alert-0 {
temperature = <70000>; /* millicelsius */
@@ -86,7 +86,7 @@ map1 {
};
};
cpu1_thermal: cpu1-thermal {
- thermal-sensors = <&tmu_cpu1 0>;
+ thermal-sensors = <&tmu_cpu1>;
trips {
cpu1_alert0: cpu-alert-0 {
temperature = <70000>;
@@ -130,7 +130,7 @@ map1 {
};
};
cpu2_thermal: cpu2-thermal {
- thermal-sensors = <&tmu_cpu2 0>;
+ thermal-sensors = <&tmu_cpu2>;
trips {
cpu2_alert0: cpu-alert-0 {
temperature = <70000>;
@@ -174,7 +174,7 @@ map1 {
};
};
cpu3_thermal: cpu3-thermal {
- thermal-sensors = <&tmu_cpu3 0>;
+ thermal-sensors = <&tmu_cpu3>;
trips {
cpu3_alert0: cpu-alert-0 {
temperature = <70000>;
@@ -218,7 +218,7 @@ map1 {
};
};
gpu_thermal: gpu-thermal {
- thermal-sensors = <&tmu_gpu 0>;
+ thermal-sensors = <&tmu_gpu>;
trips {
gpu_alert0: gpu-alert-0 {
temperature = <70000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 6/6] ARM: dts: exynos: correct TMU phandle in Odroid XU3 family
2023-02-09 10:58 [PATCH 1/6] ARM: dts: exynos: correct TMU phandle in Exynos4 Krzysztof Kozlowski
` (3 preceding siblings ...)
2023-02-09 10:58 ` [PATCH 5/6] ARM: dts: exynos: correct TMU phandle in Odroid HC1 Krzysztof Kozlowski
@ 2023-02-09 10:58 ` Krzysztof Kozlowski
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-09 10:58 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Eduardo Valentin,
Lukasz Majewski, Kukjin Kim, Javier Martinez Canillas,
Marek Szyprowski, Anand Moon, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Krzysztof Kozlowski, stable
TMU node uses 0 as thermal-sensor-cells, thus thermal zone referencing
it must not have an argument to phandle. This was not critical before,
but since rework of thermal Devicetree initialization in the
commit 3fd6d6e2b4e8 ("thermal/of: Rework the thermal device tree
initialization"), this leads to errors registering thermal zones other
than first one:
thermal_sys: cpu0-thermal: Failed to read thermal-sensors cells: -2
thermal_sys: Failed to find thermal zone for tmu id=0
exynos-tmu 10064000.tmu: Failed to register sensor: -2
exynos-tmu: probe of 10064000.tmu failed with error -2
Fixes: f1722d7dd8b8 ("ARM: dts: Define default thermal-zones for exynos5422")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index a6961ff24030..e6e7e2ff2a26 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -50,7 +50,7 @@ fan0: pwm-fan {
thermal-zones {
cpu0_thermal: cpu0-thermal {
- thermal-sensors = <&tmu_cpu0 0>;
+ thermal-sensors = <&tmu_cpu0>;
polling-delay-passive = <250>;
polling-delay = <0>;
trips {
@@ -139,7 +139,7 @@ cpu0_cooling_map4: map4 {
};
};
cpu1_thermal: cpu1-thermal {
- thermal-sensors = <&tmu_cpu1 0>;
+ thermal-sensors = <&tmu_cpu1>;
polling-delay-passive = <250>;
polling-delay = <0>;
trips {
@@ -212,7 +212,7 @@ cpu1_cooling_map4: map4 {
};
};
cpu2_thermal: cpu2-thermal {
- thermal-sensors = <&tmu_cpu2 0>;
+ thermal-sensors = <&tmu_cpu2>;
polling-delay-passive = <250>;
polling-delay = <0>;
trips {
@@ -285,7 +285,7 @@ cpu2_cooling_map4: map4 {
};
};
cpu3_thermal: cpu3-thermal {
- thermal-sensors = <&tmu_cpu3 0>;
+ thermal-sensors = <&tmu_cpu3>;
polling-delay-passive = <250>;
polling-delay = <0>;
trips {
@@ -358,7 +358,7 @@ cpu3_cooling_map4: map4 {
};
};
gpu_thermal: gpu-thermal {
- thermal-sensors = <&tmu_gpu 0>;
+ thermal-sensors = <&tmu_gpu>;
polling-delay-passive = <250>;
polling-delay = <0>;
trips {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread