* FAILED: patch "[PATCH] zonefs: Clear inode information flags on inode creation" failed to apply to 5.18-stable tree
@ 2022-06-06 12:28 gregkh
2022-06-07 5:36 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: gregkh @ 2022-06-06 12:28 UTC (permalink / raw)
To: damien.lemoal, hans.holmberg, johannes.thumshirn, kch, stable; +Cc: stable
The patch below does not apply to the 5.18-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From b954ebba296bb2eb2e38322f17aaa6426934bd7e Mon Sep 17 00:00:00 2001
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Date: Tue, 12 Apr 2022 20:52:35 +0900
Subject: [PATCH] zonefs: Clear inode information flags on inode creation
Ensure that the i_flags field of struct zonefs_inode_info is cleared to
0 when initializing a zone file inode, avoiding seeing the flag
ZONEFS_ZONE_OPEN being incorrectly set.
Fixes: b5c00e975779 ("zonefs: open/close zone on file open/close")
Cc: <stable@vger.kernel.org>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com>
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index 3614c7834007..75d8dabe0807 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -1142,6 +1142,7 @@ static struct inode *zonefs_alloc_inode(struct super_block *sb)
inode_init_once(&zi->i_vnode);
mutex_init(&zi->i_truncate_mutex);
zi->i_wr_refcnt = 0;
+ zi->i_flags = 0;
return &zi->i_vnode;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: FAILED: patch "[PATCH] zonefs: Clear inode information flags on inode creation" failed to apply to 5.18-stable tree
2022-06-06 12:28 FAILED: patch "[PATCH] zonefs: Clear inode information flags on inode creation" failed to apply to 5.18-stable tree gregkh
@ 2022-06-07 5:36 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2022-06-07 5:36 UTC (permalink / raw)
To: gregkh, hans.holmberg, johannes.thumshirn, kch, stable
On 6/6/22 21:28, gregkh@linuxfoundation.org wrote:
>
> The patch below does not apply to the 5.18-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.
>
> thanks,
>
> greg k-h
Greg,
This patch is already applied to 5.18, 5.17, 5.15 and 5.10. I think that
your bot picked it up again because of the bad PR I sent to Linus for
5.19 which had these patches included again.
My apologies for the noise.
Thanks !
>
> ------------------ original commit in Linus's tree ------------------
>
> From b954ebba296bb2eb2e38322f17aaa6426934bd7e Mon Sep 17 00:00:00 2001
> From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Date: Tue, 12 Apr 2022 20:52:35 +0900
> Subject: [PATCH] zonefs: Clear inode information flags on inode creation
>
> Ensure that the i_flags field of struct zonefs_inode_info is cleared to
> 0 when initializing a zone file inode, avoiding seeing the flag
> ZONEFS_ZONE_OPEN being incorrectly set.
>
> Fixes: b5c00e975779 ("zonefs: open/close zone on file open/close")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com>
>
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index 3614c7834007..75d8dabe0807 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -1142,6 +1142,7 @@ static struct inode *zonefs_alloc_inode(struct super_block *sb)
> inode_init_once(&zi->i_vnode);
> mutex_init(&zi->i_truncate_mutex);
> zi->i_wr_refcnt = 0;
> + zi->i_flags = 0;
>
> return &zi->i_vnode;
> }
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-07 5:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-06 12:28 FAILED: patch "[PATCH] zonefs: Clear inode information flags on inode creation" failed to apply to 5.18-stable tree gregkh
2022-06-07 5:36 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).