stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Jens Axboe <axboe@kernel.dk>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	Pavel Begunkov <asml.silence@gmail.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)
Date: Fri, 29 Nov 2019 17:14:18 +0100	[thread overview]
Message-ID: <4ef71e74-848f-59d4-6b0b-d3a3c52095a0@c-s.fr> (raw)
In-Reply-To: <3a95d445-1f5c-7750-f0de-ddc427800b3b@kernel.dk>



Le 29/11/2019 à 17:04, Jens Axboe a écrit :
> On 11/29/19 6:53 AM, Christophe Leroy wrote:
>>     CC      fs/io_uring.o
>> fs/io_uring.c: In function ‘loop_rw_iter’:
>> fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’
>> [-Werror=implicit-function-declaration]
>>       iovec.iov_base = kmap(iter->bvec->bv_page)
>>                        ^
>> fs/io_uring.c:1628:19: warning: assignment makes pointer from integer
>> without a cast [-Wint-conversion]
>>       iovec.iov_base = kmap(iter->bvec->bv_page)
>>                      ^
>> fs/io_uring.c:1643:4: error: implicit declaration of function ‘kunmap’
>> [-Werror=implicit-function-declaration]
>>       kunmap(iter->bvec->bv_page);
>>       ^
>>
>>
>> Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter
>> fixed rw") clears the failure.
>>
>> Most likely an #include is missing.
> 
> Huh weird how the build bots didn't catch that. Does the below work?

Yes it works, thanks.

Christophe

  reply	other threads:[~2019-11-29 16:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 14:53 Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw) Christophe Leroy
2019-11-29 16:04 ` Jens Axboe
2019-11-29 16:14   ` Christophe Leroy [this message]
2019-11-29 17:16     ` Jens Axboe
2019-11-29 18:07       ` Pavel Begunkov
2019-11-29 20:45         ` Jens Axboe
2019-12-03  9:06   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ef71e74-848f-59d4-6b0b-d3a3c52095a0@c-s.fr \
    --to=christophe.leroy@c-s.fr \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).