* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-14 16:15 [PATCH 5.10 000/130] 5.10.44-rc2 review Greg Kroah-Hartman
@ 2021-06-14 17:55 ` Jon Hunter
2021-06-14 19:03 ` Fox Chen
` (7 subsequent siblings)
8 siblings, 0 replies; 15+ messages in thread
From: Jon Hunter @ 2021-06-14 17:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, stable, linux-tegra
On Mon, 14 Jun 2021 18:15:07 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests passing for Tegra ...
Test results for stable-v5.10:
12 builds: 12 pass, 0 fail
28 boots: 28 pass, 0 fail
70 tests: 70 pass, 0 fail
Linux version: 5.10.44-rc2-g3f05ff8b3370
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Jon
^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-14 16:15 [PATCH 5.10 000/130] 5.10.44-rc2 review Greg Kroah-Hartman
2021-06-14 17:55 ` Jon Hunter
@ 2021-06-14 19:03 ` Fox Chen
2021-06-14 19:48 ` Pavel Machek
` (6 subsequent siblings)
8 siblings, 0 replies; 15+ messages in thread
From: Fox Chen @ 2021-06-14 19:03 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, stable, Fox Chen
On Mon, 14 Jun 2021 18:15:07 +0200, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
5.10.44-rc2 Successfully Compiled and booted on my Raspberry PI 4b (8g) (bcm2711)
Tested-by: Fox Chen <foxhlchen@gmail.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-14 16:15 [PATCH 5.10 000/130] 5.10.44-rc2 review Greg Kroah-Hartman
2021-06-14 17:55 ` Jon Hunter
2021-06-14 19:03 ` Fox Chen
@ 2021-06-14 19:48 ` Pavel Machek
2021-06-14 20:20 ` Florian Fainelli
` (5 subsequent siblings)
8 siblings, 0 replies; 15+ messages in thread
From: Pavel Machek @ 2021-06-14 19:48 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, torvalds, akpm, linux, shuah, patches, lkft-triage,
pavel, jonathanh, f.fainelli, stable
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
Hi!
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
Tested-by: Pavel Machek (CIP) <pavel@denx.de>
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-14 16:15 [PATCH 5.10 000/130] 5.10.44-rc2 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2021-06-14 19:48 ` Pavel Machek
@ 2021-06-14 20:20 ` Florian Fainelli
2021-06-14 21:34 ` Shuah Khan
` (4 subsequent siblings)
8 siblings, 0 replies; 15+ messages in thread
From: Florian Fainelli @ 2021-06-14 20:20 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: torvalds, akpm, linux, shuah, patches, lkft-triage, pavel,
jonathanh, stable
On 6/14/2021 9:15 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit kernels:
Tested-by: Florian Fainelli <f.fainelli@gmail.com>On ARCH_BRCMSTB using
32-bit and 64-bit kernels:
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-14 16:15 [PATCH 5.10 000/130] 5.10.44-rc2 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2021-06-14 20:20 ` Florian Fainelli
@ 2021-06-14 21:34 ` Shuah Khan
2021-06-15 4:11 ` Naresh Kamboju
` (3 subsequent siblings)
8 siblings, 0 replies; 15+ messages in thread
From: Shuah Khan @ 2021-06-14 21:34 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: torvalds, akpm, linux, shuah, patches, lkft-triage, pavel,
jonathanh, f.fainelli, stable, Shuah Khan
On 6/14/21 10:15 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-14 16:15 [PATCH 5.10 000/130] 5.10.44-rc2 review Greg Kroah-Hartman
` (4 preceding siblings ...)
2021-06-14 21:34 ` Shuah Khan
@ 2021-06-15 4:11 ` Naresh Kamboju
2021-06-15 6:05 ` Greg Kroah-Hartman
2021-06-15 8:51 ` Samuel Zou
` (2 subsequent siblings)
8 siblings, 1 reply; 15+ messages in thread
From: Naresh Kamboju @ 2021-06-15 4:11 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: open list, Shuah Khan, Florian Fainelli, patches, lkft-triage,
Jon Hunter, linux-stable, Pavel Machek, Andrew Morton,
Linus Torvalds, Guenter Roeck, linux-usb, Peter Chen, Jack Pham,
Felipe Balbi
Hi Greg,
On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
[ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
[ 5.145567] Unable to handle kernel NULL pointer dereference at
virtual address 0000000000000002
[ 5.154451] Mem abort info:
[ 5.157296] ESR = 0x96000004
[ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
[ 5.165771] SET = 0, FnV = 0
[ 5.168873] EA = 0, S1PTW = 0
[ 5.172064] Data abort info:
[ 5.174980] ISV = 0, ISS = 0x00000004
[ 5.178860] CM = 0, WnR = 0
[ 5.181872] [0000000000000002] user address but active_mm is swapper
[ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
[ 5.193922] Modules linked in:
[ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
[ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
[ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
[ 5.209434] Workqueue: events deferred_probe_work_func
[ 5.221786] ufshcd-qcom 1d84000.ufshc:
ufshcd_find_max_sup_active_icc_level: Regulator capability was not
set, actvIccLevel=0
[ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
[ 5.226551] pc : inode_permission+0x2c/0x178
[ 5.226559] lr : lookup_one_len_common+0xac/0x100
ref:
https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
There is a crash like this reported and discussed on the mailing thread.
https://lore.kernel.org/linux-usb/20210608105656.10795-1-peter.chen@kernel.org/
metadata:
git branch: linux-5.10.y
git repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
git commit: 3f05ff8b337097d73b2c408d60befe39dac31bb8
git describe: v5.10.43-131-g3f05ff8b3370
make_kernelversion: 5.10.44-rc2
kernel-config: https://builds.tuxbuild.com/1twkN9cmRWOK3boqZes7Yi1t0OO/config
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-15 4:11 ` Naresh Kamboju
@ 2021-06-15 6:05 ` Greg Kroah-Hartman
2021-06-15 7:07 ` Jack Pham
0 siblings, 1 reply; 15+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-15 6:05 UTC (permalink / raw)
To: Naresh Kamboju
Cc: open list, Shuah Khan, Florian Fainelli, patches, lkft-triage,
Jon Hunter, linux-stable, Pavel Machek, Andrew Morton,
Linus Torvalds, Guenter Roeck, linux-usb, Peter Chen, Jack Pham,
Felipe Balbi
On Tue, Jun 15, 2021 at 09:41:26AM +0530, Naresh Kamboju wrote:
> Hi Greg,
>
> On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 5.10.44 release.
> > There are 130 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
>
> [ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
> [ 5.145567] Unable to handle kernel NULL pointer dereference at
> virtual address 0000000000000002
> [ 5.154451] Mem abort info:
> [ 5.157296] ESR = 0x96000004
> [ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
> [ 5.165771] SET = 0, FnV = 0
> [ 5.168873] EA = 0, S1PTW = 0
> [ 5.172064] Data abort info:
> [ 5.174980] ISV = 0, ISS = 0x00000004
> [ 5.178860] CM = 0, WnR = 0
> [ 5.181872] [0000000000000002] user address but active_mm is swapper
> [ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> [ 5.193922] Modules linked in:
> [ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
> [ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
> [ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
> TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> [ 5.209434] Workqueue: events deferred_probe_work_func
> [ 5.221786] ufshcd-qcom 1d84000.ufshc:
> ufshcd_find_max_sup_active_icc_level: Regulator capability was not
> set, actvIccLevel=0
> [ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
> [ 5.226551] pc : inode_permission+0x2c/0x178
> [ 5.226559] lr : lookup_one_len_common+0xac/0x100
>
> ref:
> https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> There is a crash like this reported and discussed on the mailing thread.
> https://lore.kernel.org/linux-usb/20210608105656.10795-1-peter.chen@kernel.org/
Is this crash just on shutdown? That's what that commit was fixing, but
it is resolving an error that should not be in the 5.10.y tree.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-15 6:05 ` Greg Kroah-Hartman
@ 2021-06-15 7:07 ` Jack Pham
2021-06-15 7:11 ` Greg Kroah-Hartman
0 siblings, 1 reply; 15+ messages in thread
From: Jack Pham @ 2021-06-15 7:07 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Naresh Kamboju, open list, Shuah Khan, Florian Fainelli, patches,
lkft-triage, Jon Hunter, linux-stable, Pavel Machek,
Andrew Morton, Linus Torvalds, Guenter Roeck, linux-usb,
Peter Chen, Felipe Balbi
Hi Greg,
On Tue, Jun 15, 2021 at 08:05:50AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 15, 2021 at 09:41:26AM +0530, Naresh Kamboju wrote:
> > On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 5.10.44 release.
> > > There are 130 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
> >
> > [ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
Looks like -EPROBE_DEFER happened here due to a not-yet-probed
dependency (interconnect driver). This leads to dwc3_qcom_probe()
unwinding and calling of_platform_depopulate() which triggers the
"child" dwc3's driver remove callback dwc3_remove()...
> > [ 5.145567] Unable to handle kernel NULL pointer dereference at
> > virtual address 0000000000000002
> > [ 5.154451] Mem abort info:
> > [ 5.157296] ESR = 0x96000004
> > [ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
> > [ 5.165771] SET = 0, FnV = 0
> > [ 5.168873] EA = 0, S1PTW = 0
> > [ 5.172064] Data abort info:
> > [ 5.174980] ISV = 0, ISS = 0x00000004
> > [ 5.178860] CM = 0, WnR = 0
> > [ 5.181872] [0000000000000002] user address but active_mm is swapper
> > [ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > [ 5.193922] Modules linked in:
> > [ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
> > [ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
> > [ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
> > TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> > [ 5.209434] Workqueue: events deferred_probe_work_func
> > [ 5.221786] ufshcd-qcom 1d84000.ufshc:
> > ufshcd_find_max_sup_active_icc_level: Regulator capability was not
> > set, actvIccLevel=0
> > [ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
> > [ 5.226551] pc : inode_permission+0x2c/0x178
> > [ 5.226559] lr : lookup_one_len_common+0xac/0x100
> >
> > ref:
> > https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > There is a crash like this reported and discussed on the mailing thread.
> > https://lore.kernel.org/linux-usb/20210608105656.10795-1-peter.chen@kernel.org/
>
> Is this crash just on shutdown? That's what that commit was fixing, but
> it is resolving an error that should not be in the 5.10.y tree.
Peter reported and fixed it based on reproducing the crash from shutting
down but in my manual testing I found that it could be triggered any
time dwc3_remove() is called, though I surmised it would be a rare
occurence. In this particular case however Naresh is reporting it is
triggered even during bootup since dwc3-qcom would add its
dwc3 child, but because it encounters a probe deferral it has to
subsequently trigger the dwc3 driver remove callback right after it was
just probed.
So I think it would be good if Peter's follow-up change
(2a042767814b in your usb-next branch) can please go into stable as well
as it should help not only for the shutdown/reboot case. Otherwise,
my change "usb: dwc3: debugfs: Add and remove endpoint dirs
dynamically" could be simply be dropped until they can go in together.
Thanks,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-15 7:07 ` Jack Pham
@ 2021-06-15 7:11 ` Greg Kroah-Hartman
2021-06-15 8:16 ` Jack Pham
0 siblings, 1 reply; 15+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-15 7:11 UTC (permalink / raw)
To: Jack Pham
Cc: Naresh Kamboju, open list, Shuah Khan, Florian Fainelli, patches,
lkft-triage, Jon Hunter, linux-stable, Pavel Machek,
Andrew Morton, Linus Torvalds, Guenter Roeck, linux-usb,
Peter Chen, Felipe Balbi
On Tue, Jun 15, 2021 at 12:07:47AM -0700, Jack Pham wrote:
> Hi Greg,
>
> On Tue, Jun 15, 2021 at 08:05:50AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jun 15, 2021 at 09:41:26AM +0530, Naresh Kamboju wrote:
> > > On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > This is the start of the stable review cycle for the 5.10.44 release.
> > > > There are 130 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> > > > or in the git tree and branch at:
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
> > >
> > > [ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
>
> Looks like -EPROBE_DEFER happened here due to a not-yet-probed
> dependency (interconnect driver). This leads to dwc3_qcom_probe()
> unwinding and calling of_platform_depopulate() which triggers the
> "child" dwc3's driver remove callback dwc3_remove()...
>
> > > [ 5.145567] Unable to handle kernel NULL pointer dereference at
> > > virtual address 0000000000000002
> > > [ 5.154451] Mem abort info:
> > > [ 5.157296] ESR = 0x96000004
> > > [ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
> > > [ 5.165771] SET = 0, FnV = 0
> > > [ 5.168873] EA = 0, S1PTW = 0
> > > [ 5.172064] Data abort info:
> > > [ 5.174980] ISV = 0, ISS = 0x00000004
> > > [ 5.178860] CM = 0, WnR = 0
> > > [ 5.181872] [0000000000000002] user address but active_mm is swapper
> > > [ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > > [ 5.193922] Modules linked in:
> > > [ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
> > > [ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
> > > [ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
> > > TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> > > [ 5.209434] Workqueue: events deferred_probe_work_func
> > > [ 5.221786] ufshcd-qcom 1d84000.ufshc:
> > > ufshcd_find_max_sup_active_icc_level: Regulator capability was not
> > > set, actvIccLevel=0
> > > [ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
> > > [ 5.226551] pc : inode_permission+0x2c/0x178
> > > [ 5.226559] lr : lookup_one_len_common+0xac/0x100
> > >
> > > ref:
> > > https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
> > >
> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > >
> > > There is a crash like this reported and discussed on the mailing thread.
> > > https://lore.kernel.org/linux-usb/20210608105656.10795-1-peter.chen@kernel.org/
> >
> > Is this crash just on shutdown? That's what that commit was fixing, but
> > it is resolving an error that should not be in the 5.10.y tree.
>
> Peter reported and fixed it based on reproducing the crash from shutting
> down but in my manual testing I found that it could be triggered any
> time dwc3_remove() is called, though I surmised it would be a rare
> occurence. In this particular case however Naresh is reporting it is
> triggered even during bootup since dwc3-qcom would add its
> dwc3 child, but because it encounters a probe deferral it has to
> subsequently trigger the dwc3 driver remove callback right after it was
> just probed.
>
> So I think it would be good if Peter's follow-up change
> (2a042767814b in your usb-next branch) can please go into stable as well
> as it should help not only for the shutdown/reboot case. Otherwise,
> my change "usb: dwc3: debugfs: Add and remove endpoint dirs
> dynamically" could be simply be dropped until they can go in together.
That will all have to wait until 5.14-rc1 as these patches are not
queued up to hit Linus's tree until then. I was not aware that this
problem was showing up anywhere except in linux-next.
If we need a fix in 5.13-final before then, please let me know and
submit it so that I can take it in my tree and get it to Linus quickly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-15 7:11 ` Greg Kroah-Hartman
@ 2021-06-15 8:16 ` Jack Pham
2021-06-15 10:22 ` Greg Kroah-Hartman
0 siblings, 1 reply; 15+ messages in thread
From: Jack Pham @ 2021-06-15 8:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Naresh Kamboju, open list, Shuah Khan, Florian Fainelli, patches,
lkft-triage, Jon Hunter, linux-stable, Pavel Machek,
Andrew Morton, Linus Torvalds, Guenter Roeck, linux-usb,
Peter Chen, Felipe Balbi
On Tue, Jun 15, 2021 at 09:11:48AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 15, 2021 at 12:07:47AM -0700, Jack Pham wrote:
> > Hi Greg,
> >
> > On Tue, Jun 15, 2021 at 08:05:50AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Jun 15, 2021 at 09:41:26AM +0530, Naresh Kamboju wrote:
> > > > On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
> > > > <gregkh@linuxfoundation.org> wrote:
> > > > >
> > > > > This is the start of the stable review cycle for the 5.10.44 release.
> > > > > There are 130 patches in this series, all will be posted as a response
> > > > > to this one. If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> > > > > Anything received after that time might be too late.
> > > > >
> > > > > The whole patch series can be found in one patch at:
> > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> > > > > or in the git tree and branch at:
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > > > and the diffstat can be found below.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
> > > >
> > > > [ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
> >
> > Looks like -EPROBE_DEFER happened here due to a not-yet-probed
> > dependency (interconnect driver). This leads to dwc3_qcom_probe()
> > unwinding and calling of_platform_depopulate() which triggers the
> > "child" dwc3's driver remove callback dwc3_remove()...
> >
> > > > [ 5.145567] Unable to handle kernel NULL pointer dereference at
> > > > virtual address 0000000000000002
> > > > [ 5.154451] Mem abort info:
> > > > [ 5.157296] ESR = 0x96000004
> > > > [ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
> > > > [ 5.165771] SET = 0, FnV = 0
> > > > [ 5.168873] EA = 0, S1PTW = 0
> > > > [ 5.172064] Data abort info:
> > > > [ 5.174980] ISV = 0, ISS = 0x00000004
> > > > [ 5.178860] CM = 0, WnR = 0
> > > > [ 5.181872] [0000000000000002] user address but active_mm is swapper
> > > > [ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > > > [ 5.193922] Modules linked in:
> > > > [ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
> > > > [ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
> > > > [ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
> > > > TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> > > > [ 5.209434] Workqueue: events deferred_probe_work_func
> > > > [ 5.221786] ufshcd-qcom 1d84000.ufshc:
> > > > ufshcd_find_max_sup_active_icc_level: Regulator capability was not
> > > > set, actvIccLevel=0
> > > > [ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
> > > > [ 5.226551] pc : inode_permission+0x2c/0x178
> > > > [ 5.226559] lr : lookup_one_len_common+0xac/0x100
> > > >
> > > > ref:
> > > > https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
> > > >
> > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > >
> > > > There is a crash like this reported and discussed on the mailing thread.
> > > > https://lore.kernel.org/linux-usb/20210608105656.10795-1-peter.chen@kernel.org/
> > >
> > > Is this crash just on shutdown? That's what that commit was fixing, but
> > > it is resolving an error that should not be in the 5.10.y tree.
> >
> > Peter reported and fixed it based on reproducing the crash from shutting
> > down but in my manual testing I found that it could be triggered any
> > time dwc3_remove() is called, though I surmised it would be a rare
> > occurence. In this particular case however Naresh is reporting it is
> > triggered even during bootup since dwc3-qcom would add its
> > dwc3 child, but because it encounters a probe deferral it has to
> > subsequently trigger the dwc3 driver remove callback right after it was
> > just probed.
> >
> > So I think it would be good if Peter's follow-up change
> > (2a042767814b in your usb-next branch) can please go into stable as well
> > as it should help not only for the shutdown/reboot case. Otherwise,
> > my change "usb: dwc3: debugfs: Add and remove endpoint dirs
> > dynamically" could be simply be dropped until they can go in together.
>
> That will all have to wait until 5.14-rc1 as these patches are not
> queued up to hit Linus's tree until then. I was not aware that this
> problem was showing up anywhere except in linux-next.
>
> If we need a fix in 5.13-final before then, please let me know and
> submit it so that I can take it in my tree and get it to Linus quickly.
Sure. I just responded to one of your auto-replies about Peter's patch
"usb: dwc3: core: fix kernel panic when do reboot" getting accepted for
usb-next and asked if you can take it for usb-linus for 5.13-final asap
as well. Or did you mean I should submit a new separate patch?
As for this failure in $subject on 5.10.44-rc2, I think the prudent
thing would be to drop my patch "usb: dwc3: debugfs: Add and remove
endpoint dirs dynamically" from the stable queue altogether and revisit
it later (when it can go in along with Peter's fix). I hope it's not
too late to NAK it (at least for now) on stable?
Sorry for the mess.
Jack
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-15 8:16 ` Jack Pham
@ 2021-06-15 10:22 ` Greg Kroah-Hartman
0 siblings, 0 replies; 15+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-15 10:22 UTC (permalink / raw)
To: Jack Pham
Cc: Naresh Kamboju, open list, Shuah Khan, Florian Fainelli, patches,
lkft-triage, Jon Hunter, linux-stable, Pavel Machek,
Andrew Morton, Linus Torvalds, Guenter Roeck, linux-usb,
Peter Chen, Felipe Balbi
On Tue, Jun 15, 2021 at 01:16:18AM -0700, Jack Pham wrote:
> On Tue, Jun 15, 2021 at 09:11:48AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jun 15, 2021 at 12:07:47AM -0700, Jack Pham wrote:
> > > Hi Greg,
> > >
> > > On Tue, Jun 15, 2021 at 08:05:50AM +0200, Greg Kroah-Hartman wrote:
> > > > On Tue, Jun 15, 2021 at 09:41:26AM +0530, Naresh Kamboju wrote:
> > > > > On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
> > > > > <gregkh@linuxfoundation.org> wrote:
> > > > > >
> > > > > > This is the start of the stable review cycle for the 5.10.44 release.
> > > > > > There are 130 patches in this series, all will be posted as a response
> > > > > > to this one. If anyone has any issues with these being applied, please
> > > > > > let me know.
> > > > > >
> > > > > > Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> > > > > > Anything received after that time might be too late.
> > > > > >
> > > > > > The whole patch series can be found in one patch at:
> > > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> > > > > > or in the git tree and branch at:
> > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > > > > and the diffstat can be found below.
> > > > > >
> > > > > > thanks,
> > > > > >
> > > > > > greg k-h
> > > > >
> > > > > The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
> > > > >
> > > > > [ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
> > >
> > > Looks like -EPROBE_DEFER happened here due to a not-yet-probed
> > > dependency (interconnect driver). This leads to dwc3_qcom_probe()
> > > unwinding and calling of_platform_depopulate() which triggers the
> > > "child" dwc3's driver remove callback dwc3_remove()...
> > >
> > > > > [ 5.145567] Unable to handle kernel NULL pointer dereference at
> > > > > virtual address 0000000000000002
> > > > > [ 5.154451] Mem abort info:
> > > > > [ 5.157296] ESR = 0x96000004
> > > > > [ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
> > > > > [ 5.165771] SET = 0, FnV = 0
> > > > > [ 5.168873] EA = 0, S1PTW = 0
> > > > > [ 5.172064] Data abort info:
> > > > > [ 5.174980] ISV = 0, ISS = 0x00000004
> > > > > [ 5.178860] CM = 0, WnR = 0
> > > > > [ 5.181872] [0000000000000002] user address but active_mm is swapper
> > > > > [ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > > > > [ 5.193922] Modules linked in:
> > > > > [ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
> > > > > [ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
> > > > > [ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
> > > > > TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> > > > > [ 5.209434] Workqueue: events deferred_probe_work_func
> > > > > [ 5.221786] ufshcd-qcom 1d84000.ufshc:
> > > > > ufshcd_find_max_sup_active_icc_level: Regulator capability was not
> > > > > set, actvIccLevel=0
> > > > > [ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
> > > > > [ 5.226551] pc : inode_permission+0x2c/0x178
> > > > > [ 5.226559] lr : lookup_one_len_common+0xac/0x100
> > > > >
> > > > > ref:
> > > > > https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
> > > > >
> > > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > > >
> > > > > There is a crash like this reported and discussed on the mailing thread.
> > > > > https://lore.kernel.org/linux-usb/20210608105656.10795-1-peter.chen@kernel.org/
> > > >
> > > > Is this crash just on shutdown? That's what that commit was fixing, but
> > > > it is resolving an error that should not be in the 5.10.y tree.
> > >
> > > Peter reported and fixed it based on reproducing the crash from shutting
> > > down but in my manual testing I found that it could be triggered any
> > > time dwc3_remove() is called, though I surmised it would be a rare
> > > occurence. In this particular case however Naresh is reporting it is
> > > triggered even during bootup since dwc3-qcom would add its
> > > dwc3 child, but because it encounters a probe deferral it has to
> > > subsequently trigger the dwc3 driver remove callback right after it was
> > > just probed.
> > >
> > > So I think it would be good if Peter's follow-up change
> > > (2a042767814b in your usb-next branch) can please go into stable as well
> > > as it should help not only for the shutdown/reboot case. Otherwise,
> > > my change "usb: dwc3: debugfs: Add and remove endpoint dirs
> > > dynamically" could be simply be dropped until they can go in together.
> >
> > That will all have to wait until 5.14-rc1 as these patches are not
> > queued up to hit Linus's tree until then. I was not aware that this
> > problem was showing up anywhere except in linux-next.
> >
> > If we need a fix in 5.13-final before then, please let me know and
> > submit it so that I can take it in my tree and get it to Linus quickly.
>
> Sure. I just responded to one of your auto-replies about Peter's patch
> "usb: dwc3: core: fix kernel panic when do reboot" getting accepted for
> usb-next and asked if you can take it for usb-linus for 5.13-final asap
> as well. Or did you mean I should submit a new separate patch?
>
> As for this failure in $subject on 5.10.44-rc2, I think the prudent
> thing would be to drop my patch "usb: dwc3: debugfs: Add and remove
> endpoint dirs dynamically" from the stable queue altogether and revisit
> it later (when it can go in along with Peter's fix). I hope it's not
> too late to NAK it (at least for now) on stable?
>
> Sorry for the mess.
Ick, yeah, that's a mess, we had this commit in two different branches,
and that's what happens when this gets out of sync...
Anyway, I've cherry-picked this commit now to my branch for 5.13-final,
fixed up the "Fixes:" line, and will get it to Linus soon.
I'll also go drop this "dwc3: debugfs:" patch from the stable queue as
it will cause problems for people, and not add it back until I can get
this fix into Linus's tree as well.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-14 16:15 [PATCH 5.10 000/130] 5.10.44-rc2 review Greg Kroah-Hartman
` (5 preceding siblings ...)
2021-06-15 4:11 ` Naresh Kamboju
@ 2021-06-15 8:51 ` Samuel Zou
2021-06-15 9:46 ` Sudip Mukherjee
2021-06-15 14:21 ` Guenter Roeck
8 siblings, 0 replies; 15+ messages in thread
From: Samuel Zou @ 2021-06-15 8:51 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: torvalds, akpm, linux, shuah, patches, lkft-triage, pavel,
jonathanh, f.fainelli, stable
On 2021/6/15 0:15, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Tested on arm64 and x86 for 5.10.44-rc2,
Kernel repo:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Branch: linux-5.10.y
Version: 5.10.44-rc2
Commit: 3f05ff8b337097d73b2c408d60befe39dac31bb8
Compiler: gcc version 7.3.0 (GCC)
arm64:
--------------------------------------------------------------------
Testcase Result Summary:
total: 8906
passed: 8906
failed: 0
timeout: 0
--------------------------------------------------------------------
x86:
--------------------------------------------------------------------
Testcase Result Summary:
total: 8906
passed: 8906
failed: 0
timeout: 0
--------------------------------------------------------------------
Tested-by: Hulk Robot <hulkrobot@huawei.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-14 16:15 [PATCH 5.10 000/130] 5.10.44-rc2 review Greg Kroah-Hartman
` (6 preceding siblings ...)
2021-06-15 8:51 ` Samuel Zou
@ 2021-06-15 9:46 ` Sudip Mukherjee
2021-06-15 14:21 ` Guenter Roeck
8 siblings, 0 replies; 15+ messages in thread
From: Sudip Mukherjee @ 2021-06-15 9:46 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, torvalds, akpm, linux, shuah, patches, lkft-triage,
pavel, jonathanh, f.fainelli, stable
Hi Greg,
On Mon, Jun 14, 2021 at 06:15:07PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
Build test:
mips (gcc version 11.1.1 20210523): 63 configs -> no failure
arm (gcc version 11.1.1 20210523): 105 configs -> no new failure
arm64 (gcc version 11.1.1 20210523): 2 configs -> no failure
x86_64 (gcc version 10.2.1 20210110): 2 configs -> no failure
Boot test:
x86_64: Booted on my test laptop. No regression.
x86_64: Booted on qemu. No regression.
arm64: Booted on rpi4b (4GB model). No regression.
Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
--
Regards
Sudip
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.10 000/130] 5.10.44-rc2 review
2021-06-14 16:15 [PATCH 5.10 000/130] 5.10.44-rc2 review Greg Kroah-Hartman
` (7 preceding siblings ...)
2021-06-15 9:46 ` Sudip Mukherjee
@ 2021-06-15 14:21 ` Guenter Roeck
8 siblings, 0 replies; 15+ messages in thread
From: Guenter Roeck @ 2021-06-15 14:21 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, torvalds, akpm, shuah, patches, lkft-triage, pavel,
jonathanh, f.fainelli, stable
On Mon, Jun 14, 2021 at 06:15:07PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
Build results:
total: 156 pass: 156 fail: 0
Qemu test results:
total: 455 pass: 455 fail: 0
Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
^ permalink raw reply [flat|nested] 15+ messages in thread