From: Jan Beulich <jbeulich@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
Stefano Stabellini <stefano.stabellini@xilinx.com>,
stable@vger.kernel.org, Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen: detect uninitialized xenbus in xenbus_init
Date: Fri, 19 Nov 2021 09:24:16 +0100 [thread overview]
Message-ID: <79a85431-a505-795d-1e72-76628df987af@suse.com> (raw)
In-Reply-To: <fdfe4ba4-8f5f-47a2-98df-3dfdb50d8f6f@oracle.com>
On 18.11.2021 23:24, Boris Ostrovsky wrote:
> On 11/18/21 4:00 PM, Stefano Stabellini wrote:
>>
>> /*
>> * Avoid truncation on 32-bit.
>> * TODO: handle addresses >= 4G
>> */
>> if ( v >= ~0UL ) {
>> err = -EINVAL;
>> goto out_error;
>> }
>
>
> Since this is only relevant to 32-bit kernels then "#if BITS_PER_LONG == 32".
Plus then > instead of >= (thus also making the comment actually decribe
the code) and ULONG_MAX instead of ~0UL, I would say.
Jan
next prev parent reply other threads:[~2021-11-19 8:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 2:11 [PATCH] xen: detect uninitialized xenbus in xenbus_init Stefano Stabellini
2021-11-17 7:41 ` Jan Beulich
2021-11-18 2:37 ` Stefano Stabellini
2021-11-18 5:32 ` Juergen Gross
2021-11-18 8:47 ` Jan Beulich
2021-11-18 8:53 ` Juergen Gross
2021-11-18 21:00 ` Stefano Stabellini
2021-11-18 22:24 ` Boris Ostrovsky
2021-11-19 8:24 ` Jan Beulich [this message]
2021-11-19 5:16 ` Juergen Gross
2021-11-18 8:40 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79a85431-a505-795d-1e72-76628df987af@suse.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=stefano.stabellini@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).