From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org,
Stefano Stabellini <stefano.stabellini@xilinx.com>,
stable@vger.kernel.org,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] xen: detect uninitialized xenbus in xenbus_init
Date: Thu, 18 Nov 2021 09:47:41 +0100 [thread overview]
Message-ID: <9453672e-56ea-71cd-cdd2-b4aaafb8db56@suse.com> (raw)
In-Reply-To: <44403efe-a850-b53b-785f-6f5c73eb2b96@suse.com>
On 18.11.2021 06:32, Juergen Gross wrote:
> On 18.11.21 03:37, Stefano Stabellini wrote:
>> --- a/drivers/xen/xenbus/xenbus_probe.c
>> +++ b/drivers/xen/xenbus/xenbus_probe.c
>> @@ -951,6 +951,28 @@ static int __init xenbus_init(void)
>> err = hvm_get_parameter(HVM_PARAM_STORE_PFN, &v);
>> if (err)
>> goto out_error;
>> + /*
>> + * Return error on an invalid value.
>> + *
>> + * Uninitialized hvm_params are zero and return no error.
>> + * Although it is theoretically possible to have
>> + * HVM_PARAM_STORE_PFN set to zero on purpose, in reality it is
>> + * not zero when valid. If zero, it means that Xenstore hasn't
>> + * been properly initialized. Instead of attempting to map a
>> + * wrong guest physical address return error.
>> + */
>> + if (v == 0) {
>
> Make this "if (v == ULONG_MAX || v== 0)" instead?
> This would result in the same err on a new and an old hypervisor
> (assuming we switch the hypervisor to init params with ~0UL).
>
>> + err = -ENOENT;
>> + goto out_error;
>> + }
>> + /*
>> + * ULONG_MAX is invalid on 64-bit because is INVALID_PFN.
>> + * On 32-bit return error to avoid truncation.
>> + */
>> + if (v >= ULONG_MAX) {
>> + err = -EINVAL;
>> + goto out_error;
>> + }
>
> Does it make sense to continue the system running in case of
> truncation? This would be a 32-bit guest with more than 16TB of RAM
> and the Xen tools decided to place the Xenstore ring page above the
> 16TB boundary. This is a completely insane scenario IMO.
>
> A proper panic() in this case would make diagnosis of that much
> easier (me having doubts that this will ever be hit, though).
While I agree panic() may be an option here (albeit I'm not sure why
that would be better than trying to cope with 0 and hence without
xenbus), I'd like to point out that the amount of RAM assigned to a
guest is unrelated to the choice of GFNs for the various "magic"
items.
Jan
next prev parent reply other threads:[~2021-11-18 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 2:11 [PATCH] xen: detect uninitialized xenbus in xenbus_init Stefano Stabellini
2021-11-17 7:41 ` Jan Beulich
2021-11-18 2:37 ` Stefano Stabellini
2021-11-18 5:32 ` Juergen Gross
2021-11-18 8:47 ` Jan Beulich [this message]
2021-11-18 8:53 ` Juergen Gross
2021-11-18 21:00 ` Stefano Stabellini
2021-11-18 22:24 ` Boris Ostrovsky
2021-11-19 8:24 ` Jan Beulich
2021-11-19 5:16 ` Juergen Gross
2021-11-18 8:40 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9453672e-56ea-71cd-cdd2-b4aaafb8db56@suse.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=stefano.stabellini@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).