* [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455
[not found] <20220926150740.6684-1-linux@fw-web.de>
@ 2022-09-26 15:07 ` Frank Wunderlich
2022-09-27 6:31 ` Johan Hovold
2022-09-26 15:07 ` [PATCH 2/2] net: usb: qmi_wwan: Add " Frank Wunderlich
1 sibling, 1 reply; 6+ messages in thread
From: Frank Wunderlich @ 2022-09-26 15:07 UTC (permalink / raw)
To: linux-usb
Cc: Frank Wunderlich, Bjørn Mork, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Johan Hovold, Greg Kroah-Hartman,
netdev, linux-kernel, stable
From: Frank Wunderlich <frank-w@public-files.de>
Add support for Dell 5811e (EM7455) with USB-id 0x413c:0x81c2.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Cc: stable@vger.kernel.org
---
drivers/usb/serial/qcserial.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 586ef5551e76..7897609916a6 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = {
{DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
{DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */
{DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */
+ {DEVICE_SWI(0x413c, 0x81c2)}, /* Dell Wireless 5811e QDL */
{DEVICE_SWI(0x413c, 0x81cb)}, /* Dell Wireless 5816e QDL */
{DEVICE_SWI(0x413c, 0x81cc)}, /* Dell Wireless 5816e */
{DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] net: usb: qmi_wwan: Add new usb-id for Dell branded EM7455
[not found] <20220926150740.6684-1-linux@fw-web.de>
2022-09-26 15:07 ` [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455 Frank Wunderlich
@ 2022-09-26 15:07 ` Frank Wunderlich
2022-09-26 17:04 ` Bjørn Mork
1 sibling, 1 reply; 6+ messages in thread
From: Frank Wunderlich @ 2022-09-26 15:07 UTC (permalink / raw)
To: linux-usb
Cc: Frank Wunderlich, Bjørn Mork, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Johan Hovold, Greg Kroah-Hartman,
netdev, linux-kernel, stable
From: Frank Wunderlich <frank-w@public-files.de>
Add support for Dell 5811e (EM7455) with USB-id 0x413c:0x81c2.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Cc: stable@vger.kernel.org
---
drivers/net/usb/qmi_wwan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 0cb187def5bc..26c34a7c21bd 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1402,6 +1402,7 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x413c, 0x81b3, 8)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
{QMI_FIXED_INTF(0x413c, 0x81b6, 8)}, /* Dell Wireless 5811e */
{QMI_FIXED_INTF(0x413c, 0x81b6, 10)}, /* Dell Wireless 5811e */
+ {QMI_FIXED_INTF(0x413c, 0x81c2, 8)}, /* Dell Wireless 5811e */
{QMI_FIXED_INTF(0x413c, 0x81cc, 8)}, /* Dell Wireless 5816e */
{QMI_FIXED_INTF(0x413c, 0x81d7, 0)}, /* Dell Wireless 5821e */
{QMI_FIXED_INTF(0x413c, 0x81d7, 1)}, /* Dell Wireless 5821e preproduction config */
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] net: usb: qmi_wwan: Add new usb-id for Dell branded EM7455
2022-09-26 15:07 ` [PATCH 2/2] net: usb: qmi_wwan: Add " Frank Wunderlich
@ 2022-09-26 17:04 ` Bjørn Mork
0 siblings, 0 replies; 6+ messages in thread
From: Bjørn Mork @ 2022-09-26 17:04 UTC (permalink / raw)
To: Frank Wunderlich
Cc: linux-usb, Frank Wunderlich, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Johan Hovold, Greg Kroah-Hartman,
netdev, linux-kernel, stable
Frank Wunderlich <linux@fw-web.de> writes:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Add support for Dell 5811e (EM7455) with USB-id 0x413c:0x81c2.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Cc: stable@vger.kernel.org
> ---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 0cb187def5bc..26c34a7c21bd 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1402,6 +1402,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x413c, 0x81b3, 8)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
> {QMI_FIXED_INTF(0x413c, 0x81b6, 8)}, /* Dell Wireless 5811e */
> {QMI_FIXED_INTF(0x413c, 0x81b6, 10)}, /* Dell Wireless 5811e */
> + {QMI_FIXED_INTF(0x413c, 0x81c2, 8)}, /* Dell Wireless 5811e */
> {QMI_FIXED_INTF(0x413c, 0x81cc, 8)}, /* Dell Wireless 5816e */
> {QMI_FIXED_INTF(0x413c, 0x81d7, 0)}, /* Dell Wireless 5821e */
> {QMI_FIXED_INTF(0x413c, 0x81d7, 1)}, /* Dell Wireless 5821e preproduction config */
Acked-by: Bjørn Mork <bjorn@mork.no>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455
2022-09-26 15:07 ` [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455 Frank Wunderlich
@ 2022-09-27 6:31 ` Johan Hovold
2022-09-27 6:48 ` Aw: " Frank Wunderlich
0 siblings, 1 reply; 6+ messages in thread
From: Johan Hovold @ 2022-09-27 6:31 UTC (permalink / raw)
To: Frank Wunderlich
Cc: linux-usb, Frank Wunderlich, Bjørn Mork, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Greg Kroah-Hartman,
netdev, linux-kernel, stable
On Mon, Sep 26, 2022 at 05:07:39PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Add support for Dell 5811e (EM7455) with USB-id 0x413c:0x81c2.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Cc: stable@vger.kernel.org
> ---
> drivers/usb/serial/qcserial.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index 586ef5551e76..7897609916a6 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = {
> {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
> {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */
> {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */
> + {DEVICE_SWI(0x413c, 0x81c2)}, /* Dell Wireless 5811e QDL */
I assume this is not just for QDL mode as the comment indicates.
Could you post the output of usb-devices for this device?
> {DEVICE_SWI(0x413c, 0x81cb)}, /* Dell Wireless 5816e QDL */
> {DEVICE_SWI(0x413c, 0x81cc)}, /* Dell Wireless 5816e */
> {DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Aw: Re: [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455
2022-09-27 6:31 ` Johan Hovold
@ 2022-09-27 6:48 ` Frank Wunderlich
2022-09-27 7:04 ` Johan Hovold
0 siblings, 1 reply; 6+ messages in thread
From: Frank Wunderlich @ 2022-09-27 6:48 UTC (permalink / raw)
To: Johan Hovold
Cc: Frank Wunderlich, linux-usb, Bjørn Mork, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Greg Kroah-Hartman,
netdev, linux-kernel, stable
Hi
> Gesendet: Dienstag, 27. September 2022 um 08:31 Uhr
> Von: "Johan Hovold" <johan@kernel.org>
> An: "Frank Wunderlich" <linux@fw-web.de>
> Cc: linux-usb@vger.kernel.org, "Frank Wunderlich" <frank-w@public-files.de>, "Bjørn Mork" <bjorn@mork.no>, "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org
> Betreff: Re: [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455
>
> On Mon, Sep 26, 2022 at 05:07:39PM +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> > +++ b/drivers/usb/serial/qcserial.c
> > @@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = {
> > {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
> > {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */
> > {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */
> > + {DEVICE_SWI(0x413c, 0x81c2)}, /* Dell Wireless 5811e QDL */
>
> I assume this is not just for QDL mode as the comment indicates.
to be honest, have not found out yet what QDL means and assumed that it's like the other dw5811e, so not changed comment :)
> Could you post the output of usb-devices for this device?
Bus 001 Device 004: ID 413c:81c2 Sierra Wireless, Incorporated DW5811e Snapdragon™ X7 LTE
/: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci-mtk/2p, 480M
ID 1d6b:0002 Linux Foundation 2.0 root hub
|__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M
ID 1a40:0101 Terminus Technology Inc. Hub
|__ Port 1: Dev 6, If 0, Class=Vendor Specific Class, Driver=qcserial, 480M
ID 413c:81c2 Dell Computer Corp.
|__ Port 1: Dev 6, If 2, Class=Vendor Specific Class, Driver=qcserial, 480M
ID 413c:81c2 Dell Computer Corp.
|__ Port 1: Dev 6, If 3, Class=Vendor Specific Class, Driver=qcserial, 480M
ID 413c:81c2 Dell Computer Corp.
|__ Port 1: Dev 6, If 8, Class=Vendor Specific Class, Driver=qmi_wwan, 480M
ID 413c:81c2 Dell Computer Corp.
> > {DEVICE_SWI(0x413c, 0x81cb)}, /* Dell Wireless 5816e QDL */
> > {DEVICE_SWI(0x413c, 0x81cc)}, /* Dell Wireless 5816e */
> > {DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */
>
> Johan
regards Frank
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Aw: Re: [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455
2022-09-27 6:48 ` Aw: " Frank Wunderlich
@ 2022-09-27 7:04 ` Johan Hovold
0 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2022-09-27 7:04 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Frank Wunderlich, linux-usb, Bjørn Mork, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Greg Kroah-Hartman,
netdev, linux-kernel, stable
On Tue, Sep 27, 2022 at 08:48:23AM +0200, Frank Wunderlich wrote:
> Hi
>
> > Gesendet: Dienstag, 27. September 2022 um 08:31 Uhr
> > Von: "Johan Hovold" <johan@kernel.org>
> > On Mon, Sep 26, 2022 at 05:07:39PM +0200, Frank Wunderlich wrote:
> > > From: Frank Wunderlich <frank-w@public-files.de>
>
> > > +++ b/drivers/usb/serial/qcserial.c
> > > @@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = {
> > > {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
> > > {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */
> > > {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */
> > > + {DEVICE_SWI(0x413c, 0x81c2)}, /* Dell Wireless 5811e QDL */
> >
> > I assume this is not just for QDL mode as the comment indicates.
>
> to be honest, have not found out yet what QDL means and assumed that
> it's like the other dw5811e, so not changed comment :)
I believe that's Qualcomm Download mode or similar, for flashing the
device (cf. 5816e which has two entries, one for QDL mode).
> > Could you post the output of usb-devices for this device?
>
> Bus 001 Device 004: ID 413c:81c2 Sierra Wireless, Incorporated DW5811e Snapdragon™ X7 LTE
>
>
> /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci-mtk/2p, 480M
> ID 1d6b:0002 Linux Foundation 2.0 root hub
> |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M
> ID 1a40:0101 Terminus Technology Inc. Hub
> |__ Port 1: Dev 6, If 0, Class=Vendor Specific Class, Driver=qcserial, 480M
> ID 413c:81c2 Dell Computer Corp.
> |__ Port 1: Dev 6, If 2, Class=Vendor Specific Class, Driver=qcserial, 480M
> ID 413c:81c2 Dell Computer Corp.
> |__ Port 1: Dev 6, If 3, Class=Vendor Specific Class, Driver=qcserial, 480M
> ID 413c:81c2 Dell Computer Corp.
> |__ Port 1: Dev 6, If 8, Class=Vendor Specific Class, Driver=qmi_wwan, 480M
> ID 413c:81c2 Dell Computer Corp.
Thanks. The above doesn't include all the details that usb-devices (or
lsusb -v) would but still confirms the basic bits so I've applied the
patch now after amending the comment.
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-27 7:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220926150740.6684-1-linux@fw-web.de>
2022-09-26 15:07 ` [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455 Frank Wunderlich
2022-09-27 6:31 ` Johan Hovold
2022-09-27 6:48 ` Aw: " Frank Wunderlich
2022-09-27 7:04 ` Johan Hovold
2022-09-26 15:07 ` [PATCH 2/2] net: usb: qmi_wwan: Add " Frank Wunderlich
2022-09-26 17:04 ` Bjørn Mork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).