* [PATCH] efi: Add iMac Pro 2017 to uefi skip cert quirk @ 2022-10-27 10:01 Aditya Garg 2022-11-01 11:57 ` Mimi Zohar 0 siblings, 1 reply; 4+ messages in thread From: Aditya Garg @ 2022-10-27 10:01 UTC (permalink / raw) To: zohar, chyishian.jiang, linux-kernel, jarkko, dmitry.kasatkin, paul, jmorris, serge, linux-integrity, keyrings, linux-security-module Cc: stable, Orlando Chamberlain From: Aditya Garg <gargaditya08@live.com> The iMac Pro 2017 is also a T2 Mac. Thus add it to the list of uefi skip cert. Cc: stable@vger.kernel.org Signed-off-by: Aditya Garg <gargaditya08@live.com> --- security/integrity/platform_certs/load_uefi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c index b78753d27d8ea6..d1fdd113450a63 100644 --- a/security/integrity/platform_certs/load_uefi.c +++ b/security/integrity/platform_certs/load_uefi.c @@ -35,6 +35,7 @@ static const struct dmi_system_id uefi_skip_cert[] = { { UEFI_QUIRK_SKIP_CERT("Apple Inc.", "MacPro7,1") }, { UEFI_QUIRK_SKIP_CERT("Apple Inc.", "iMac20,1") }, { UEFI_QUIRK_SKIP_CERT("Apple Inc.", "iMac20,2") }, + { UEFI_QUIRK_SKIP_CERT("Apple Inc.", "iMacPro1,1") }, { } }; ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] efi: Add iMac Pro 2017 to uefi skip cert quirk 2022-10-27 10:01 [PATCH] efi: Add iMac Pro 2017 to uefi skip cert quirk Aditya Garg @ 2022-11-01 11:57 ` Mimi Zohar 2022-11-01 14:06 ` Aditya Garg 0 siblings, 1 reply; 4+ messages in thread From: Mimi Zohar @ 2022-11-01 11:57 UTC (permalink / raw) To: Aditya Garg, chyishian.jiang, linux-kernel, jarkko, dmitry.kasatkin, paul, jmorris, serge, linux-integrity, keyrings, linux-security-module Cc: stable, Orlando Chamberlain Hi Aditya, On Thu, 2022-10-27 at 10:01 +0000, Aditya Garg wrote: > From: Aditya Garg <gargaditya08@live.com> > > The iMac Pro 2017 is also a T2 Mac. Thus add it to the list of uefi skip cert. > > Cc: stable@vger.kernel.org > Signed-off-by: Aditya Garg <gargaditya08@live.com> I found this list of computers with the Apple T2 Security Chip - https://support.apple.com/en-us/HT208862, but not a list that correlates them to the system ID. With this update, is this the entire list? thanks, Mimi > --- > security/integrity/platform_certs/load_uefi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c > index b78753d27d8ea6..d1fdd113450a63 100644 > --- a/security/integrity/platform_certs/load_uefi.c > +++ b/security/integrity/platform_certs/load_uefi.c > @@ -35,6 +35,7 @@ static const struct dmi_system_id uefi_skip_cert[] = { > { UEFI_QUIRK_SKIP_CERT("Apple Inc.", "MacPro7,1") }, > { UEFI_QUIRK_SKIP_CERT("Apple Inc.", "iMac20,1") }, > { UEFI_QUIRK_SKIP_CERT("Apple Inc.", "iMac20,2") }, > + { UEFI_QUIRK_SKIP_CERT("Apple Inc.", "iMacPro1,1") }, > { } > }; > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] efi: Add iMac Pro 2017 to uefi skip cert quirk 2022-11-01 11:57 ` Mimi Zohar @ 2022-11-01 14:06 ` Aditya Garg 2022-11-01 21:07 ` Mimi Zohar 0 siblings, 1 reply; 4+ messages in thread From: Aditya Garg @ 2022-11-01 14:06 UTC (permalink / raw) To: Mimi Zohar Cc: chyishian.jiang, linux-kernel, jarkko, dmitry.kasatkin, paul, jmorris, serge, linux-integrity, keyrings, linux-security-module, stable, Orlando Chamberlain Hi Mimi > I found this list of computers with the Apple T2 Security Chip - > https://support.apple.com/en-us/HT208862, but not a list that > correlates them to the system ID. With this update, is this the entire > list? As per the link you sent me, the following are the system IDs of the T2 Macs mentioned in the list 1. iMac (Retina 5K, 27-inch, 2020) - iMac20,1, iMac20,2 2. iMac Pro - iMacPro1,1 3. Mac Pro (2019) - MacPro7,1 4. Mac Pro (Rack, 2019) - MacPro7,1 5. Mac mini (2018) - Macmini8,1 6. MacBook Air (Retina, 13-inch, 2020) - MacBookAir9,1 7. MacBook Air (Retina, 13-inch, 2019) - MacBookAir8,2 8. MacBook Air (Retina, 13-inch, 2018) - MacBookAir8,1 9. MacBook Pro (13-inch, 2020, Two Thunderbolt 3 ports) - MacBookPro16,3 10. MacBook Pro (13-inch, 2020, Four Thunderbolt 3 ports) - MacBookPro16,2 11. MacBook Pro (16-inch, 2019) - MacBookPro16,1, MacBookPro16,4 12. MacBook Pro (13-inch, 2019, Two Thunderbolt 3 ports) - MacBookPro15,4 13. MacBook Pro (15-inch, 2019) - MacBookPro15,1, MacBookPro15,3 14. MacBook Pro (13-inch, 2019, Four Thunderbolt 3 ports) - MacBookPro15,2 15. MacBook Pro (15-inch, 2018) - MacBookPro15,1 16. MacBook Pro (13-inch, 2018, Four Thunderbolt 3 ports) - MacBookPro15,2 The system IDs of the Macs can be seen from official Apple’s documentation form the links below :- https://support.apple.com/en-in/HT201634 - For iMac https://support.apple.com/en-in/HT202888 - For Mac Pro https://support.apple.com/en-in/HT201894 - For Mac mini https://support.apple.com/en-in/HT201862 - For MacBook Air https://support.apple.com/en-in/HT201300 - For MacBook Pro After cross-checking only iMacPro1,1 seems to be missing. Thanks Aditya ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] efi: Add iMac Pro 2017 to uefi skip cert quirk 2022-11-01 14:06 ` Aditya Garg @ 2022-11-01 21:07 ` Mimi Zohar 0 siblings, 0 replies; 4+ messages in thread From: Mimi Zohar @ 2022-11-01 21:07 UTC (permalink / raw) To: Aditya Garg Cc: chyishian.jiang, linux-kernel, jarkko, dmitry.kasatkin, paul, jmorris, serge, linux-integrity, keyrings, linux-security-module, stable, Orlando Chamberlain Hi Aditya, On Tue, 2022-11-01 at 14:06 +0000, Aditya Garg wrote: > Hi Mimi > > > I found this list of computers with the Apple T2 Security Chip - > > https://support.apple.com/en-us/HT208862, but not a list that > > correlates them to the system ID. With this update, is this the entire > > list? > > As per the link you sent me, the following are the system IDs of the T2 Macs mentioned in the list > > 1. iMac (Retina 5K, 27-inch, 2020) - iMac20,1, iMac20,2 > 2. iMac Pro - iMacPro1,1 > 3. Mac Pro (2019) - MacPro7,1 > 4. Mac Pro (Rack, 2019) - MacPro7,1 > 5. Mac mini (2018) - Macmini8,1 > 6. MacBook Air (Retina, 13-inch, 2020) - MacBookAir9,1 > 7. MacBook Air (Retina, 13-inch, 2019) - MacBookAir8,2 > 8. MacBook Air (Retina, 13-inch, 2018) - MacBookAir8,1 > 9. MacBook Pro (13-inch, 2020, Two Thunderbolt 3 ports) - MacBookPro16,3 > 10. MacBook Pro (13-inch, 2020, Four Thunderbolt 3 ports) - MacBookPro16,2 > 11. MacBook Pro (16-inch, 2019) - MacBookPro16,1, MacBookPro16,4 > 12. MacBook Pro (13-inch, 2019, Two Thunderbolt 3 ports) - MacBookPro15,4 > 13. MacBook Pro (15-inch, 2019) - MacBookPro15,1, MacBookPro15,3 > 14. MacBook Pro (13-inch, 2019, Four Thunderbolt 3 ports) - MacBookPro15,2 > 15. MacBook Pro (15-inch, 2018) - MacBookPro15,1 > 16. MacBook Pro (13-inch, 2018, Four Thunderbolt 3 ports) - MacBookPro15,2 > > The system IDs of the Macs can be seen from official Apple’s documentation form the links below :- > > https://support.apple.com/en-in/HT201634 - For iMac > https://support.apple.com/en-in/HT202888 - For Mac Pro > https://support.apple.com/en-in/HT201894 - For Mac mini > https://support.apple.com/en-in/HT201862 - For MacBook Air > https://support.apple.com/en-in/HT201300 - For MacBook Pro > > After cross-checking only iMacPro1,1 seems to be missing. Thank you for double checking. The patch is now queued in next- integrity. Mimi ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-01 21:07 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-10-27 10:01 [PATCH] efi: Add iMac Pro 2017 to uefi skip cert quirk Aditya Garg 2022-11-01 11:57 ` Mimi Zohar 2022-11-01 14:06 ` Aditya Garg 2022-11-01 21:07 ` Mimi Zohar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).