* [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
@ 2019-05-30 15:16 Ben Hutchings
2019-05-31 2:02 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 7+ messages in thread
From: Ben Hutchings @ 2019-05-30 15:16 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Prarit Bhargava, Juergen Gross, xen-devel, stable
I'm looking at CVE-2015-8553 which is fixed by:
commit 7681f31ec9cdacab4fd10570be924f2cef6669ba
Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date: Wed Feb 13 18:21:31 2019 -0500
xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
I'm aware that this change is incompatible with qemu < 2.5, but that's
now quite old. Do you think it makes sense to apply this change to
some stable branches?
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
2019-05-30 15:16 [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset Ben Hutchings
@ 2019-05-31 2:02 ` Konrad Rzeszutek Wilk
2019-05-31 11:46 ` Juergen Gross
2019-06-03 8:00 ` Greg KH
0 siblings, 2 replies; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2019-05-31 2:02 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Prarit Bhargava, Juergen Gross, xen-devel, stable
On 5/30/19 8:16 AM, Ben Hutchings wrote:
> I'm looking at CVE-2015-8553 which is fixed by:
>
> commit 7681f31ec9cdacab4fd10570be924f2cef6669ba
> Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Date: Wed Feb 13 18:21:31 2019 -0500
>
> xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
>
> I'm aware that this change is incompatible with qemu < 2.5, but that's
> now quite old. Do you think it makes sense to apply this change to
> some stable branches?
>
> Ben.
>
Hey Ben,
<shrugs> My opinion is to drop it, but if Juergen thinks it makes sense
to backport I am not going to argue.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
2019-05-31 2:02 ` Konrad Rzeszutek Wilk
@ 2019-05-31 11:46 ` Juergen Gross
2019-06-03 8:00 ` Greg KH
1 sibling, 0 replies; 7+ messages in thread
From: Juergen Gross @ 2019-05-31 11:46 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Ben Hutchings; +Cc: Prarit Bhargava, xen-devel, stable
On 31/05/2019 04:02, Konrad Rzeszutek Wilk wrote:
> On 5/30/19 8:16 AM, Ben Hutchings wrote:
>> I'm looking at CVE-2015-8553 which is fixed by:
>>
>> commit 7681f31ec9cdacab4fd10570be924f2cef6669ba
>> Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> Date: Wed Feb 13 18:21:31 2019 -0500
>>
>> xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
>>
>> I'm aware that this change is incompatible with qemu < 2.5, but that's
>> now quite old. Do you think it makes sense to apply this change to
>> some stable branches?
>>
>> Ben.
>>
>
> Hey Ben,
>
> <shrugs> My opinion is to drop it, but if Juergen thinks it makes sense
> to backport I am not going to argue.
>
I'm with Konrad here.
Juergen
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
2019-05-31 2:02 ` Konrad Rzeszutek Wilk
2019-05-31 11:46 ` Juergen Gross
@ 2019-06-03 8:00 ` Greg KH
2019-06-03 12:02 ` Ben Hutchings
1 sibling, 1 reply; 7+ messages in thread
From: Greg KH @ 2019-06-03 8:00 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Ben Hutchings, Prarit Bhargava, Juergen Gross, xen-devel, stable
On Thu, May 30, 2019 at 07:02:34PM -0700, Konrad Rzeszutek Wilk wrote:
> On 5/30/19 8:16 AM, Ben Hutchings wrote:
> > I'm looking at CVE-2015-8553 which is fixed by:
> >
> > commit 7681f31ec9cdacab4fd10570be924f2cef6669ba
> > Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Date: Wed Feb 13 18:21:31 2019 -0500
> >
> > xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
> >
> > I'm aware that this change is incompatible with qemu < 2.5, but that's
> > now quite old. Do you think it makes sense to apply this change to
> > some stable branches?
> >
> > Ben.
> >
>
> Hey Ben,
>
> <shrugs> My opinion is to drop it, but if Juergen thinks it makes sense to
> backport I am not going to argue.
Ok, I've queued this up now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
2019-06-03 8:00 ` Greg KH
@ 2019-06-03 12:02 ` Ben Hutchings
2019-06-03 13:10 ` Juergen Gross
0 siblings, 1 reply; 7+ messages in thread
From: Ben Hutchings @ 2019-06-03 12:02 UTC (permalink / raw)
To: Greg KH
Cc: Prarit Bhargava, Juergen Gross, xen-devel, stable, Konrad Rzeszutek Wilk
On Mon, 2019-06-03 at 10:00 +0200, Greg KH wrote:
> On Thu, May 30, 2019 at 07:02:34PM -0700, Konrad Rzeszutek Wilk wrote:
> > On 5/30/19 8:16 AM, Ben Hutchings wrote:
> > > I'm looking at CVE-2015-8553 which is fixed by:
> > >
> > > commit 7681f31ec9cdacab4fd10570be924f2cef6669ba
> > > Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > Date: Wed Feb 13 18:21:31 2019 -0500
> > >
> > > xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
> > >
> > > I'm aware that this change is incompatible with qemu < 2.5, but that's
> > > now quite old. Do you think it makes sense to apply this change to
> > > some stable branches?
> > >
> > > Ben.
> > >
> >
> > Hey Ben,
> >
> > <shrugs> My opinion is to drop it, but if Juergen thinks it makes sense to
> > backport I am not going to argue.
>
> Ok, I've queued this up now, thanks.
Juergen said:
> I'm with Konrad here.
so unless I'm very confused this should *not* be applied to stable
branches.
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
2019-06-03 12:02 ` Ben Hutchings
@ 2019-06-03 13:10 ` Juergen Gross
2019-06-04 5:48 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Juergen Gross @ 2019-06-03 13:10 UTC (permalink / raw)
To: Ben Hutchings, Greg KH
Cc: Prarit Bhargava, xen-devel, stable, Konrad Rzeszutek Wilk
On 03/06/2019 14:02, Ben Hutchings wrote:
> On Mon, 2019-06-03 at 10:00 +0200, Greg KH wrote:
>> On Thu, May 30, 2019 at 07:02:34PM -0700, Konrad Rzeszutek Wilk wrote:
>>> On 5/30/19 8:16 AM, Ben Hutchings wrote:
>>>> I'm looking at CVE-2015-8553 which is fixed by:
>>>>
>>>> commit 7681f31ec9cdacab4fd10570be924f2cef6669ba
>>>> Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>> Date: Wed Feb 13 18:21:31 2019 -0500
>>>>
>>>> xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
>>>>
>>>> I'm aware that this change is incompatible with qemu < 2.5, but that's
>>>> now quite old. Do you think it makes sense to apply this change to
>>>> some stable branches?
>>>>
>>>> Ben.
>>>>
>>>
>>> Hey Ben,
>>>
>>> <shrugs> My opinion is to drop it, but if Juergen thinks it makes sense to
>>> backport I am not going to argue.
>>
>> Ok, I've queued this up now, thanks.
>
> Juergen said:
>
>> I'm with Konrad here.
>
> so unless I'm very confused this should *not* be applied to stable
> branches.
"should not" is a little bit hard. I didn't opt for adding it, but I
don't object to add it either (like Konrad :-) ).
Juergen
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
2019-06-03 13:10 ` Juergen Gross
@ 2019-06-04 5:48 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2019-06-04 5:48 UTC (permalink / raw)
To: Juergen Gross
Cc: Ben Hutchings, Prarit Bhargava, xen-devel, stable, Konrad Rzeszutek Wilk
On Mon, Jun 03, 2019 at 03:10:55PM +0200, Juergen Gross wrote:
> On 03/06/2019 14:02, Ben Hutchings wrote:
> > On Mon, 2019-06-03 at 10:00 +0200, Greg KH wrote:
> >> On Thu, May 30, 2019 at 07:02:34PM -0700, Konrad Rzeszutek Wilk wrote:
> >>> On 5/30/19 8:16 AM, Ben Hutchings wrote:
> >>>> I'm looking at CVE-2015-8553 which is fixed by:
> >>>>
> >>>> commit 7681f31ec9cdacab4fd10570be924f2cef6669ba
> >>>> Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>> Date: Wed Feb 13 18:21:31 2019 -0500
> >>>>
> >>>> xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
> >>>>
> >>>> I'm aware that this change is incompatible with qemu < 2.5, but that's
> >>>> now quite old. Do you think it makes sense to apply this change to
> >>>> some stable branches?
> >>>>
> >>>> Ben.
> >>>>
> >>>
> >>> Hey Ben,
> >>>
> >>> <shrugs> My opinion is to drop it, but if Juergen thinks it makes sense to
> >>> backport I am not going to argue.
> >>
> >> Ok, I've queued this up now, thanks.
> >
> > Juergen said:
> >
> >> I'm with Konrad here.
> >
> > so unless I'm very confused this should *not* be applied to stable
> > branches.
>
> "should not" is a little bit hard. I didn't opt for adding it, but I
> don't object to add it either (like Konrad :-) ).
Ok, I've added it as it does fix a CVE, and if I don't, I'll get odd
emails 6 months from now asking why I didn't include it...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-06-04 5:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-30 15:16 [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset Ben Hutchings
2019-05-31 2:02 ` Konrad Rzeszutek Wilk
2019-05-31 11:46 ` Juergen Gross
2019-06-03 8:00 ` Greg KH
2019-06-03 12:02 ` Ben Hutchings
2019-06-03 13:10 ` Juergen Gross
2019-06-04 5:48 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).