stable-rc 4.9.212-rc1/2e383da55e49: regressions detected in project stable v4.9.y on OE

stable-rc 4.9.212-rc1/2e383da55e49: regressions detected in project stable v4.9.y on OE

[Naresh Kamboju]

stable-rc 4.9 build failed due to these build error,

drivers/md/bitmap.c:1702:13: error: conflicting types for 'bitmap_free'
 static void bitmap_free(struct bitmap *bitmap)
             ^~~~~~~~~~~
include/linux/bitmap.h:94:13: note: previous declaration of
'bitmap_free' was here
 extern void bitmap_free(const unsigned long *bitmap);
             ^~~~~~~~~~~
scripts/Makefile.build:304: recipe for target 'drivers/md/bitmap.o' failed

suspecting this patch causing this build failure on stable-rc 4.9

bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free()
commit c42b65e363ce97a828f81b59033c3558f8fa7f70 upstream.

A lot of code become ugly because of open coding allocations for bitmaps.

Introduce three helpers to allow users be more clear of intention
and keep their code neat.

Note, due to multiple circular dependencies we may not provide
the helpers as inliners. For now we keep them exported and, perhaps,
at some point in the future we will sort out header inclusion and
inheritance.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
Linaro LKFT
https://lkft.linaro.org

Re: stable-rc 4.9.212-rc1/2e383da55e49: regressions detected in project stable v4.9.y on OE

[Greg Kroah-Hartman]

On Tue, Jan 28, 2020 at 05:14:33PM +0530, Naresh Kamboju wrote:
> stable-rc 4.9 build failed due to these build error,
> 
> drivers/md/bitmap.c:1702:13: error: conflicting types for 'bitmap_free'
>  static void bitmap_free(struct bitmap *bitmap)
>              ^~~~~~~~~~~
> include/linux/bitmap.h:94:13: note: previous declaration of
> 'bitmap_free' was here
>  extern void bitmap_free(const unsigned long *bitmap);
>              ^~~~~~~~~~~
> scripts/Makefile.build:304: recipe for target 'drivers/md/bitmap.o' failed
> 
> suspecting this patch causing this build failure on stable-rc 4.9
> 
> bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free()
> commit c42b65e363ce97a828f81b59033c3558f8fa7f70 upstream.
> 
> A lot of code become ugly because of open coding allocations for bitmaps.
> 
> Introduce three helpers to allow users be more clear of intention
> and keep their code neat.
> 
> Note, due to multiple circular dependencies we may not provide
> the helpers as inliners. For now we keep them exported and, perhaps,
> at some point in the future we will sort out header inclusion and
> inheritance.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Sorry, my fault, am fixing this up for 4.9 and 4.4 and 4.14 right now...
Will push out new -rcs when working again.

greg k-h

Re: stable-rc 4.9.212-rc1/2e383da55e49: regressions detected in project stable v4.9.y on OE

[Greg Kroah-Hartman]

On Tue, Jan 28, 2020 at 12:54:46PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 28, 2020 at 05:14:33PM +0530, Naresh Kamboju wrote:
> > stable-rc 4.9 build failed due to these build error,
> > 
> > drivers/md/bitmap.c:1702:13: error: conflicting types for 'bitmap_free'
> >  static void bitmap_free(struct bitmap *bitmap)
> >              ^~~~~~~~~~~
> > include/linux/bitmap.h:94:13: note: previous declaration of
> > 'bitmap_free' was here
> >  extern void bitmap_free(const unsigned long *bitmap);
> >              ^~~~~~~~~~~
> > scripts/Makefile.build:304: recipe for target 'drivers/md/bitmap.o' failed
> > 
> > suspecting this patch causing this build failure on stable-rc 4.9
> > 
> > bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free()
> > commit c42b65e363ce97a828f81b59033c3558f8fa7f70 upstream.
> > 
> > A lot of code become ugly because of open coding allocations for bitmaps.
> > 
> > Introduce three helpers to allow users be more clear of intention
> > and keep their code neat.
> > 
> > Note, due to multiple circular dependencies we may not provide
> > the helpers as inliners. For now we keep them exported and, perhaps,
> > at some point in the future we will sort out header inclusion and
> > inheritance.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Sorry, my fault, am fixing this up for 4.9 and 4.4 and 4.14 right now...
> Will push out new -rcs when working again.

Ok, should be now resolved, sorry for the mess.

greg k-h