stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* cpuidle-tegra.c:349:38: error: 'TEGRA_SUSPEND_NOT_READY' undeclared
@ 2021-11-24 12:05 Naresh Kamboju
  2021-11-24 12:40 ` Naresh Kamboju
  0 siblings, 1 reply; 4+ messages in thread
From: Naresh Kamboju @ 2021-11-24 12:05 UTC (permalink / raw)
  To: linux-stable, Greg Kroah-Hartman, Sasha Levin
  Cc: Daniel Lezcano, Dmitry Osipenko, Thierry Reding, lkft-triage

Regression found on arm gcc-11 builds
Following build warnings / errors reported on stable-rc queue/5.10.

metadata:
    git_describe: v5.10.81-155-gca79bd042925
    git_repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc-queues
    git_short_log: ca79bd042925 (\"x86/Kconfig: Fix an unused variable
error in dell-smm-hwmon\")
    target_arch: arm
    toolchain: gcc-11

build error :
--------------
arch/arm/boot/dts/bcm53016-meraki-mr32.dts:204.4-14: Warning
(reg_format): /srab@18007000/ports/port@0:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
arch/arm/boot/dts/bcm53016-meraki-mr32.dts:209.4-14: Warning
(reg_format): /srab@18007000/ports/port@5:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
arch/arm/boot/dts/bcm53016-meraki-mr32.dtb: Warning
(pci_device_bus_num): Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm53016-meraki-mr32.dtb: Warning (i2c_bus_reg):
Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm53016-meraki-mr32.dtb: Warning (spi_bus_reg):
Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm53016-meraki-mr32.dts:203.10-206.5: Warning
(avoid_default_addr_size): /srab@18007000/ports/port@0: Relying on
default #address-cells value
arch/arm/boot/dts/bcm53016-meraki-mr32.dts:203.10-206.5: Warning
(avoid_default_addr_size): /srab@18007000/ports/port@0: Relying on
default #size-cells value
arch/arm/boot/dts/bcm53016-meraki-mr32.dts:208.10-217.5: Warning
(avoid_default_addr_size): /srab@18007000/ports/port@5: Relying on
default #address-cells value
arch/arm/boot/dts/bcm53016-meraki-mr32.dts:208.10-217.5: Warning
(avoid_default_addr_size): /srab@18007000/ports/port@5: Relying on
default #size-cells value

drivers/cpuidle/cpuidle-tegra.c: In function 'tegra_cpuidle_probe':
drivers/cpuidle/cpuidle-tegra.c:349:38: error:
'TEGRA_SUSPEND_NOT_READY' undeclared (first use in this function); did
you mean 'TEGRA_SUSPEND_NONE'?
  349 |  if (tegra_pmc_get_suspend_mode() == TEGRA_SUSPEND_NOT_READY)
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~
      |                                      TEGRA_SUSPEND_NONE

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

due to the following patch,
cpuidle: tegra: Check whether PMC is ready
[ Upstream commit bdb1ffdad3b73e4d0538098fc02e2ea87a6b27cd ]

Check whether PMC is ready before proceeding with the cpuidle registration.
This fixes racing with the PMC driver probe order, which results in a
disabled deepest CC6 idling state if cpuidle driver is probed before the
PMC.

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

build link:
-----------
https://builds.tuxbuild.com//21Ma7IQryRIdyeUb4V2IeX4ePy8/build.log

build config:
-------------
https://builds.tuxbuild.com//21Ma7IQryRIdyeUb4V2IeX4ePy8/config

# To install tuxmake on your system globally
# sudo pip3 install -U tuxmake
tuxmake --runtime podman --target-arch arm --toolchain gcc-10
--kconfig defconfig  \
      --kconfig-add
https://builds.tuxbuild.com//21Ma7IQryRIdyeUb4V2IeX4ePy8/config

--
Linaro LKFT
https://lkft.linaro.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: cpuidle-tegra.c:349:38: error: 'TEGRA_SUSPEND_NOT_READY' undeclared
  2021-11-24 12:05 cpuidle-tegra.c:349:38: error: 'TEGRA_SUSPEND_NOT_READY' undeclared Naresh Kamboju
@ 2021-11-24 12:40 ` Naresh Kamboju
  2021-11-24 16:13   ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Naresh Kamboju @ 2021-11-24 12:40 UTC (permalink / raw)
  To: linux-stable, Greg Kroah-Hartman, Sasha Levin
  Cc: Daniel Lezcano, Dmitry Osipenko, Thierry Reding, lkft-triage

On Wed, 24 Nov 2021 at 17:35, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> Regression found on arm gcc-11 builds
> Following build warnings / errors reported on stable-rc queue/5.10.

 Following build warnings / errors reported on stable-rc 5.10 also.

>
> metadata:
>     git_describe: v5.10.81-155-gca79bd042925
>     git_repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc-queues
>     git_short_log: ca79bd042925 (\"x86/Kconfig: Fix an unused variable
> error in dell-smm-hwmon\")
>     target_arch: arm
>     toolchain: gcc-11
>
> build error :
> --------------
> arch/arm/boot/dts/bcm53016-meraki-mr32.dts:204.4-14: Warning
> (reg_format): /srab@18007000/ports/port@0:reg: property has invalid
> length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/bcm53016-meraki-mr32.dts:209.4-14: Warning
> (reg_format): /srab@18007000/ports/port@5:reg: property has invalid
> length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/bcm53016-meraki-mr32.dtb: Warning
> (pci_device_bus_num): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm53016-meraki-mr32.dtb: Warning (i2c_bus_reg):
> Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm53016-meraki-mr32.dtb: Warning (spi_bus_reg):
> Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm53016-meraki-mr32.dts:203.10-206.5: Warning
> (avoid_default_addr_size): /srab@18007000/ports/port@0: Relying on
> default #address-cells value
> arch/arm/boot/dts/bcm53016-meraki-mr32.dts:203.10-206.5: Warning
> (avoid_default_addr_size): /srab@18007000/ports/port@0: Relying on
> default #size-cells value
> arch/arm/boot/dts/bcm53016-meraki-mr32.dts:208.10-217.5: Warning
> (avoid_default_addr_size): /srab@18007000/ports/port@5: Relying on
> default #address-cells value
> arch/arm/boot/dts/bcm53016-meraki-mr32.dts:208.10-217.5: Warning
> (avoid_default_addr_size): /srab@18007000/ports/port@5: Relying on
> default #size-cells value
>
> drivers/cpuidle/cpuidle-tegra.c: In function 'tegra_cpuidle_probe':
> drivers/cpuidle/cpuidle-tegra.c:349:38: error:
> 'TEGRA_SUSPEND_NOT_READY' undeclared (first use in this function); did
> you mean 'TEGRA_SUSPEND_NONE'?
>   349 |  if (tegra_pmc_get_suspend_mode() == TEGRA_SUSPEND_NOT_READY)
>       |                                      ^~~~~~~~~~~~~~~~~~~~~~~
>       |                                      TEGRA_SUSPEND_NONE
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> due to the following patch,
> cpuidle: tegra: Check whether PMC is ready
> [ Upstream commit bdb1ffdad3b73e4d0538098fc02e2ea87a6b27cd ]
>
> Check whether PMC is ready before proceeding with the cpuidle registration.
> This fixes racing with the PMC driver probe order, which results in a
> disabled deepest CC6 idling state if cpuidle driver is probed before the
> PMC.
>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> build link:
> -----------
> https://builds.tuxbuild.com//21Ma7IQryRIdyeUb4V2IeX4ePy8/build.log
>
> build config:
> -------------
> https://builds.tuxbuild.com//21Ma7IQryRIdyeUb4V2IeX4ePy8/config
>
> # To install tuxmake on your system globally
> # sudo pip3 install -U tuxmake
> tuxmake --runtime podman --target-arch arm --toolchain gcc-10
> --kconfig defconfig  \
>       --kconfig-add
> https://builds.tuxbuild.com//21Ma7IQryRIdyeUb4V2IeX4ePy8/config
>
> --
> Linaro LKFT
> https://lkft.linaro.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: cpuidle-tegra.c:349:38: error: 'TEGRA_SUSPEND_NOT_READY' undeclared
  2021-11-24 12:40 ` Naresh Kamboju
@ 2021-11-24 16:13   ` Greg Kroah-Hartman
  2021-11-25  7:26     ` Naresh Kamboju
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-11-24 16:13 UTC (permalink / raw)
  To: Naresh Kamboju
  Cc: linux-stable, Sasha Levin, Daniel Lezcano, Dmitry Osipenko,
	Thierry Reding, lkft-triage

On Wed, Nov 24, 2021 at 06:10:16PM +0530, Naresh Kamboju wrote:
> On Wed, 24 Nov 2021 at 17:35, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> > Regression found on arm gcc-11 builds
> > Following build warnings / errors reported on stable-rc queue/5.10.
> 
>  Following build warnings / errors reported on stable-rc 5.10 also.

I think you mean 5.15, right?

Anyway, now dropped, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: cpuidle-tegra.c:349:38: error: 'TEGRA_SUSPEND_NOT_READY' undeclared
  2021-11-24 16:13   ` Greg Kroah-Hartman
@ 2021-11-25  7:26     ` Naresh Kamboju
  0 siblings, 0 replies; 4+ messages in thread
From: Naresh Kamboju @ 2021-11-25  7:26 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-stable, Sasha Levin, Daniel Lezcano, Dmitry Osipenko,
	Thierry Reding, lkft-triage

On Wed, 24 Nov 2021 at 21:43, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Nov 24, 2021 at 06:10:16PM +0530, Naresh Kamboju wrote:
> > On Wed, 24 Nov 2021 at 17:35, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> > >
> > > Regression found on arm gcc-11 builds
> > > Following build warnings / errors reported on stable-rc queue/5.10.
> >
> >  Following build warnings / errors reported on stable-rc 5.10 also.
>
> I think you mean 5.15, right?

i mean
stable-rc 5.10
stable-rc queue/5.10

- Naresh

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-25  7:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 12:05 cpuidle-tegra.c:349:38: error: 'TEGRA_SUSPEND_NOT_READY' undeclared Naresh Kamboju
2021-11-24 12:40 ` Naresh Kamboju
2021-11-24 16:13   ` Greg Kroah-Hartman
2021-11-25  7:26     ` Naresh Kamboju

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).