From: Linus Torvalds <torvalds@linux-foundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, patches@lists.linux.dev,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
shuah@kernel.org, patches@kernelci.org,
lkft-triage@lists.linaro.org, pavel@denx.de,
jonathanh@nvidia.com, f.fainelli@gmail.com,
sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de
Subject: Re: [PATCH 5.15 00/37] 5.15.96-rc2 review
Date: Thu, 23 Feb 2023 10:03:43 -0800 [thread overview]
Message-ID: <CAHk-=whCG1zudvDsqdFo89pHARvDv4=r6vaZ8GWc_Q9amxBM6Q@mail.gmail.com> (raw)
In-Reply-To: <cfd03ee0-b47a-644d-4364-79601025f35f@roeck-us.net>
On Thu, Feb 23, 2023 at 9:31 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> This isn't the first time this happens. I seem to recall that you mentioned
> some time ago that whatever you use to apply patches (quilt ?) doesn't
> handle executable permission bits correctly.
Note that even though git itself does handle these things right, we've
also always said that if some old fogey wants to use tar-balls and
patches, that's supposed to still work.
I guess the same "old fogey" comment then covers quilt too.
End result: we should try to generally not execute our scripts
directly, but to explicitly state which interpreter it should use,
rather than then depend on the #! in the script itself to do it.
In fact, for shell scripting in particular, we go further than that,
and use $(CONFIG_SHELL)
Of course, in this case, it's actually using the Makefile '$(shell
..)' format, so I guess it looks a bit odd to write it as
$(shell $(CONFIG_SHELL) script..)
but I do think we should do it.
Now, independently of that I also think quilt should probably just
learn the git world order about file modes, because let's face it, git
_has_ taken over the world. Mwhahahhahahaahaaa!
Linus
next prev parent reply other threads:[~2023-02-23 18:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 14:16 [PATCH 5.15 00/37] 5.15.96-rc2 review Greg Kroah-Hartman
2023-02-23 15:36 ` Guenter Roeck
2023-02-23 16:33 ` Greg Kroah-Hartman
2023-02-23 16:37 ` Florian Fainelli
2023-02-23 17:30 ` Guenter Roeck
2023-02-23 18:03 ` Linus Torvalds [this message]
2023-02-23 19:47 ` Nathan Chancellor
2023-02-23 21:18 ` Linus Torvalds
2023-02-23 21:23 ` Greg Kroah-Hartman
2023-02-23 21:39 ` Linus Torvalds
2023-02-24 10:25 ` Greg Kroah-Hartman
2023-02-24 16:55 ` Greg Kroah-Hartman
2023-02-23 15:40 ` Naresh Kamboju
2023-02-23 15:45 ` Shuah Khan
2023-02-23 16:18 ` Shuah Khan
2023-02-23 21:54 ` Florian Fainelli
2023-02-23 23:34 ` Shuah Khan
2023-02-24 4:03 ` Slade Watkins
2023-02-24 9:50 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whCG1zudvDsqdFo89pHARvDv4=r6vaZ8GWc_Q9amxBM6Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=patches@kernelci.org \
--cc=patches@lists.linux.dev \
--cc=pavel@denx.de \
--cc=rwarsow@gmx.de \
--cc=shuah@kernel.org \
--cc=srw@sladewatkins.net \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).