* [PATCH] [v2] cpuidle: add ARCH_SUSPEND_POSSIBLE dependencies
@ 2023-02-06 19:33 Arnd Bergmann
2023-02-07 10:14 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2023-02-06 19:33 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Dmitry Osipenko
Cc: Arnd Bergmann, Randy Dunlap, stable, Anup Patel, Sudeep Holla,
Ulf Hansson, Michael Walle, Thierry Reding, Bjorn Andersson,
Lina Iyer, Stephan Gerhold, linux-pm, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Some ARMv4 processors don't support suspend, which leads
to a build failure with the tegra and qualcomm cpuidle driver:
WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
Selected by [y]:
- ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
arch/arm/kernel/sleep.o: in function `__cpu_suspend':
(.text+0x68): undefined reference to `cpu_sa110_suspend_size'
(.text+0x68): undefined reference to `cpu_fa526_suspend_size'
Add an explicit dependency to make randconfig builds avoid
this combination.
Fixes: faae6c9f2e68 ("cpuidle: tegra: Enable compile testing")
Fixes: a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")
Link: https://lore.kernel.org/all/20211013160125.772873-1-arnd@kernel.org/
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: stable@vger.kernel.org
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I found this in my backlog of patches that never made it upstream,
testing shows this is still needed. Please apply.
---
drivers/cpuidle/Kconfig.arm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
index 747aa537389b..f0714a32921e 100644
--- a/drivers/cpuidle/Kconfig.arm
+++ b/drivers/cpuidle/Kconfig.arm
@@ -102,6 +102,7 @@ config ARM_MVEBU_V7_CPUIDLE
config ARM_TEGRA_CPUIDLE
bool "CPU Idle Driver for NVIDIA Tegra SoCs"
depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 && MMU
+ depends on ARCH_SUSPEND_POSSIBLE
select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
select ARM_CPU_SUSPEND
help
@@ -110,6 +111,7 @@ config ARM_TEGRA_CPUIDLE
config ARM_QCOM_SPM_CPUIDLE
bool "CPU Idle Driver for Qualcomm Subsystem Power Manager (SPM)"
depends on (ARCH_QCOM || COMPILE_TEST) && !ARM64 && MMU
+ depends on ARCH_SUSPEND_POSSIBLE
select ARM_CPU_SUSPEND
select CPU_IDLE_MULTIPLE_DRIVERS
select DT_IDLE_STATES
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] cpuidle: add ARCH_SUSPEND_POSSIBLE dependencies
2023-02-06 19:33 [PATCH] [v2] cpuidle: add ARCH_SUSPEND_POSSIBLE dependencies Arnd Bergmann
@ 2023-02-07 10:14 ` Thierry Reding
2023-02-09 19:52 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2023-02-07 10:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rafael J. Wysocki, Daniel Lezcano, Dmitry Osipenko,
Arnd Bergmann, Randy Dunlap, stable, Anup Patel, Sudeep Holla,
Ulf Hansson, Michael Walle, Bjorn Andersson, Lina Iyer,
Stephan Gerhold, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]
On Mon, Feb 06, 2023 at 08:33:06PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Some ARMv4 processors don't support suspend, which leads
> to a build failure with the tegra and qualcomm cpuidle driver:
>
> WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
> Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
> Selected by [y]:
> - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
>
> arch/arm/kernel/sleep.o: in function `__cpu_suspend':
> (.text+0x68): undefined reference to `cpu_sa110_suspend_size'
> (.text+0x68): undefined reference to `cpu_fa526_suspend_size'
>
> Add an explicit dependency to make randconfig builds avoid
> this combination.
>
> Fixes: faae6c9f2e68 ("cpuidle: tegra: Enable compile testing")
> Fixes: a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")
> Link: https://lore.kernel.org/all/20211013160125.772873-1-arnd@kernel.org/
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: stable@vger.kernel.org
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I found this in my backlog of patches that never made it upstream,
> testing shows this is still needed. Please apply.
> ---
> drivers/cpuidle/Kconfig.arm | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] cpuidle: add ARCH_SUSPEND_POSSIBLE dependencies
2023-02-07 10:14 ` Thierry Reding
@ 2023-02-09 19:52 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2023-02-09 19:52 UTC (permalink / raw)
To: Thierry Reding, Arnd Bergmann
Cc: Rafael J. Wysocki, Daniel Lezcano, Dmitry Osipenko,
Arnd Bergmann, Randy Dunlap, stable, Anup Patel, Sudeep Holla,
Ulf Hansson, Michael Walle, Bjorn Andersson, Lina Iyer,
Stephan Gerhold, linux-pm, linux-kernel
On Tue, Feb 7, 2023 at 11:14 AM Thierry Reding <treding@nvidia.com> wrote:
>
> On Mon, Feb 06, 2023 at 08:33:06PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Some ARMv4 processors don't support suspend, which leads
> > to a build failure with the tegra and qualcomm cpuidle driver:
> >
> > WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
> > Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
> > Selected by [y]:
> > - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
> >
> > arch/arm/kernel/sleep.o: in function `__cpu_suspend':
> > (.text+0x68): undefined reference to `cpu_sa110_suspend_size'
> > (.text+0x68): undefined reference to `cpu_fa526_suspend_size'
> >
> > Add an explicit dependency to make randconfig builds avoid
> > this combination.
> >
> > Fixes: faae6c9f2e68 ("cpuidle: tegra: Enable compile testing")
> > Fixes: a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")
> > Link: https://lore.kernel.org/all/20211013160125.772873-1-arnd@kernel.org/
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Cc: stable@vger.kernel.org
> > Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > I found this in my backlog of patches that never made it upstream,
> > testing shows this is still needed. Please apply.
> > ---
> > drivers/cpuidle/Kconfig.arm | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Acked-by: Thierry Reding <treding@nvidia.com>
Applied as 6.3 material, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-09 19:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-06 19:33 [PATCH] [v2] cpuidle: add ARCH_SUSPEND_POSSIBLE dependencies Arnd Bergmann
2023-02-07 10:14 ` Thierry Reding
2023-02-09 19:52 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).