From: Miklos Szeredi <miklos@szeredi.hu>
To: Christoph Hellwig <hch@lst.de>
Cc: Bart Van Assche <bvanassche@acm.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-aio <linux-aio@kvack.org>,
syzbot <syzkaller@googlegroups.com>,
Avi Kivity <avi@scylladb.com>, Eric Dumazet <edumazet@google.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] aio: Fix locking in aio_poll()
Date: Tue, 5 Feb 2019 09:12:53 +0100 [thread overview]
Message-ID: <CAJfpegtkPSss5LxB3eEK7tLCu+tv5GOeM+Wu+cksUxjvSg3now@mail.gmail.com> (raw)
In-Reply-To: <20190204174900.GA16229@lst.de>
On Mon, Feb 4, 2019 at 6:49 PM Christoph Hellwig <hch@lst.de> wrote:
>
> On Mon, Feb 04, 2019 at 09:45:55AM -0800, Bart Van Assche wrote:
> > Since kioctx.ctx_lock may be acquired from IRQ context, all code that
> > acquires that lock from thread context must disable interrupts. This
> > patch fixes the following lockdep complaint:
>
> But breaks the real life users of this interface :(
>
> aio_poll_wake is assigned as the wake function to a waitqueue,
> and the waitqueue interface requires that function to be called
> with irqs disabled. It looks like the fuse code is breaking that
> contract, so we need to fix that instead of disable irqs.
Not all variants of the waitqueue interface require irqs to be
disabled, and fuse has nothing whatsoever to do with irqs, so there's
no sane reason to disable them.
Also, AFAICS, the fuse device does not support asynchronous IO. I
just don't get what this is about...
Thanks,
Miklos
next prev parent reply other threads:[~2019-02-05 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 17:45 [PATCH] aio: Fix locking in aio_poll() Bart Van Assche
2019-02-04 17:49 ` Christoph Hellwig
2019-02-05 8:12 ` Miklos Szeredi [this message]
2019-02-06 0:53 ` Bart Van Assche
2019-02-06 8:36 ` Miklos Szeredi
2019-02-06 13:47 ` Christoph Hellwig
2019-02-06 14:31 ` Miklos Szeredi
2019-02-06 13:39 ` Christoph Hellwig
2019-02-09 0:59 Bart Van Assche
2019-02-12 7:56 ` Christoph Hellwig
2019-02-21 22:28 ` Bart Van Assche
2019-02-22 3:17 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegtkPSss5LxB3eEK7tLCu+tv5GOeM+Wu+cksUxjvSg3now@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=avi@scylladb.com \
--cc=bvanassche@acm.org \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).