* [PATCH] ARC: hide unused function unw_hdr_alloc
@ 2019-07-03 13:39 Arnd Bergmann
2019-07-03 16:12 ` Vineet Gupta
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2019-07-03 13:39 UTC (permalink / raw)
To: Vineet Gupta
Cc: Arnd Bergmann, stable, Andrew Morton, Mike Rapoport,
linux-snps-arc, linux-kernel
As kernelci.org reports, this function is not used in
vdk_hs38_defconfig:
arch/arc/kernel/unwind.c:188:14: warning: 'unw_hdr_alloc' defined but not used [-Wunused-function]
Fixes: bc79c9a72165 ("ARC: dw2 unwind: Reinstante unwinding out of modules")
Link: https://kernelci.org/build/id/5d1cae3f59b514300340c132/logs/
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arc/kernel/unwind.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/arch/arc/kernel/unwind.c b/arch/arc/kernel/unwind.c
index 182ce67dfe10..c2663fce7f6c 100644
--- a/arch/arc/kernel/unwind.c
+++ b/arch/arc/kernel/unwind.c
@@ -181,11 +181,6 @@ static void *__init unw_hdr_alloc_early(unsigned long sz)
return memblock_alloc_from(sz, sizeof(unsigned int), MAX_DMA_ADDRESS);
}
-static void *unw_hdr_alloc(unsigned long sz)
-{
- return kmalloc(sz, GFP_KERNEL);
-}
-
static void init_unwind_table(struct unwind_table *table, const char *name,
const void *core_start, unsigned long core_size,
const void *init_start, unsigned long init_size,
@@ -366,6 +361,10 @@ static void init_unwind_hdr(struct unwind_table *table,
}
#ifdef CONFIG_MODULES
+static void *unw_hdr_alloc(unsigned long sz)
+{
+ return kmalloc(sz, GFP_KERNEL);
+}
static struct unwind_table *last_table;
--
2.20.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARC: hide unused function unw_hdr_alloc
2019-07-03 13:39 [PATCH] ARC: hide unused function unw_hdr_alloc Arnd Bergmann
@ 2019-07-03 16:12 ` Vineet Gupta
2019-07-03 18:24 ` Arnd Bergmann
2019-07-03 18:25 ` Arnd Bergmann
0 siblings, 2 replies; 4+ messages in thread
From: Vineet Gupta @ 2019-07-03 16:12 UTC (permalink / raw)
To: Arnd Bergmann
Cc: stable, Andrew Morton, Mike Rapoport, linux-snps-arc, linux-kernel
On 7/3/19 6:39 AM, Arnd Bergmann wrote:
> As kernelci.org reports,
Curious, how are you getting these reports ? I want to see as well.
> this function is not used in
> vdk_hs38_defconfig:
>
> arch/arc/kernel/unwind.c:188:14: warning: 'unw_hdr_alloc' defined but not used [-Wunused-function]
>
> Fixes: bc79c9a72165 ("ARC: dw2 unwind: Reinstante unwinding out of modules")
> Link: https://kernelci.org/build/id/5d1cae3f59b514300340c132/logs/
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thx, do you want me to pick this up via arc tree.
Thx,
-Vineet
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARC: hide unused function unw_hdr_alloc
2019-07-03 16:12 ` Vineet Gupta
@ 2019-07-03 18:24 ` Arnd Bergmann
2019-07-03 18:25 ` Arnd Bergmann
1 sibling, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2019-07-03 18:24 UTC (permalink / raw)
To: Vineet Gupta
Cc: stable, Andrew Morton, Mike Rapoport, linux-snps-arc, linux-kernel
n Wed, Jul 3, 2019 at 6:13 PM Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
>
> On 7/3/19 6:39 AM, Arnd Bergmann wrote:
> > As kernelci.org reports,
>
> Curious, how are you getting these reports ? I want to see as well.
I'm subscribed to the mailing list at
https://lists.linaro.org/mailman/listinfo/kernel-build-reports
I think you can also ask the kernelci folks to get a different subset of
the build reports.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARC: hide unused function unw_hdr_alloc
2019-07-03 16:12 ` Vineet Gupta
2019-07-03 18:24 ` Arnd Bergmann
@ 2019-07-03 18:25 ` Arnd Bergmann
1 sibling, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2019-07-03 18:25 UTC (permalink / raw)
To: Vineet Gupta
Cc: stable, Andrew Morton, Mike Rapoport, linux-snps-arc, linux-kernel
On Wed, Jul 3, 2019 at 6:13 PM Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
> On 7/3/19 6:39 AM, Arnd Bergmann wrote:
> > Fixes: bc79c9a72165 ("ARC: dw2 unwind: Reinstante unwinding out of modules")
> > Link: https://kernelci.org/build/id/5d1cae3f59b514300340c132/logs/
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thx, do you want me to pick this up via arc tree.
Yes, that would be great.
Thanks,
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-03 18:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-03 13:39 [PATCH] ARC: hide unused function unw_hdr_alloc Arnd Bergmann
2019-07-03 16:12 ` Vineet Gupta
2019-07-03 18:24 ` Arnd Bergmann
2019-07-03 18:25 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).