* [PATCH 01/17] ARM: dts: da850: fix interrupt numbers for clocksource [not found] <20190111172134.30147-1-brgl@bgdev.pl> @ 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-17 14:22 ` Sekhar Nori 0 siblings, 1 reply; 3+ messages in thread From: Bartosz Golaszewski @ 2019-01-11 17:21 UTC (permalink / raw) To: Sekhar Nori, Kevin Hilman, Daniel Lezcano, Rob Herring, Mark Rutland, Thomas Gleixner Cc: linux-arm-kernel, linux-kernel, devicetree, Bartosz Golaszewski, stable From: Bartosz Golaszewski <bgolaszewski@baylibre.com> The timer interrupts specified in commit 3652e2741f42 ("ARM: dts: da850: Add clocks") are wrong but since the current timer code hard-codes them, the bug was never spotted. This patch must go into stable since, once we introduce a proper clocksource driver, devices with buggy device tree will stop booting. Fixes: 3652e2741f42 ("ARM: dts: da850: Add clocks") Cc: stable@vger.kernel.org Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- arch/arm/boot/dts/da850.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 47aa53ba6b92..559659b399d0 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -476,7 +476,7 @@ clocksource: timer@20000 { compatible = "ti,da830-timer"; reg = <0x20000 0x1000>; - interrupts = <12>, <13>; + interrupts = <21>, <22>; interrupt-names = "tint12", "tint34"; clocks = <&pll0_auxclk>; }; -- 2.19.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 01/17] ARM: dts: da850: fix interrupt numbers for clocksource 2019-01-11 17:21 ` [PATCH 01/17] ARM: dts: da850: fix interrupt numbers for clocksource Bartosz Golaszewski @ 2019-01-17 14:22 ` Sekhar Nori 2019-01-17 14:32 ` Bartosz Golaszewski 0 siblings, 1 reply; 3+ messages in thread From: Sekhar Nori @ 2019-01-17 14:22 UTC (permalink / raw) To: Bartosz Golaszewski, Kevin Hilman, Daniel Lezcano, Rob Herring, Mark Rutland, Thomas Gleixner Cc: linux-arm-kernel, linux-kernel, devicetree, Bartosz Golaszewski, stable On 11/01/19 10:51 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > The timer interrupts specified in commit 3652e2741f42 ("ARM: dts: > da850: Add clocks") are wrong but since the current timer code > hard-codes them, the bug was never spotted. > > This patch must go into stable since, once we introduce a proper > clocksource driver, devices with buggy device tree will stop booting. Is this the case where someone uses device-tree from a stable tree and kernel from latest mainline? I have added it to my fixes branch for v5.0 anyway. Thanks, Sekhar ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 01/17] ARM: dts: da850: fix interrupt numbers for clocksource 2019-01-17 14:22 ` Sekhar Nori @ 2019-01-17 14:32 ` Bartosz Golaszewski 0 siblings, 0 replies; 3+ messages in thread From: Bartosz Golaszewski @ 2019-01-17 14:32 UTC (permalink / raw) To: Sekhar Nori Cc: Kevin Hilman, Daniel Lezcano, Rob Herring, Mark Rutland, Thomas Gleixner, Linux ARM, Linux Kernel Mailing List, devicetree, Bartosz Golaszewski, stable czw., 17 sty 2019 o 15:23 Sekhar Nori <nsekhar@ti.com> napisał(a): > > On 11/01/19 10:51 PM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > The timer interrupts specified in commit 3652e2741f42 ("ARM: dts: > > da850: Add clocks") are wrong but since the current timer code > > hard-codes them, the bug was never spotted. > > > > This patch must go into stable since, once we introduce a proper > > clocksource driver, devices with buggy device tree will stop booting. > > Is this the case where someone uses device-tree from a stable tree and > kernel from latest mainline? > Well, if someone wants to use an old device tree and a newer kernel, then it'll be broken anyway. If we get it to stable then at least the fixed device tree will work in the future. That was my reasoning. Bart ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-17 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190111172134.30147-1-brgl@bgdev.pl>
2019-01-11 17:21 ` [PATCH 01/17] ARM: dts: da850: fix interrupt numbers for clocksource Bartosz Golaszewski
2019-01-17 14:22 ` Sekhar Nori
2019-01-17 14:32 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).