stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Anssi Hannula <anssi.hannula@bitwise.fi>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	"Stable # 4 . 20+" <stable@vger.kernel.org>,
	Laura Abbott <labbott@redhat.com>
Subject: Re: [PATCH] tools: gpio: Fix out-of-tree build regression
Date: Wed, 25 Mar 2020 16:24:32 +0100	[thread overview]
Message-ID: <CAMpxmJVrTJN_YgfvKfxbNHRKscM8rGetbc=ic6hsbqMwCJapPQ@mail.gmail.com> (raw)
In-Reply-To: <20200325103154.32235-1-anssi.hannula@bitwise.fi>

śr., 25 mar 2020 o 11:33 Anssi Hannula <anssi.hannula@bitwise.fi> napisał(a):
>
> Commit 0161a94e2d1c7 ("tools: gpio: Correctly add make dependencies for
> gpio_utils") added a make rule for gpio-utils-in.o but used $(output)
> instead of the correct $(OUTPUT) for the output directory, breaking
> out-of-tree build (O=xx) with the following error:
>
>   No rule to make target 'out/tools/gpio/gpio-utils-in.o', needed by 'out/tools/gpio/lsgpio-in.o'.  Stop.
>
> Fix that.
>
> Fixes: 0161a94e2d1c ("tools: gpio: Correctly add make dependencies for gpio_utils")
> Cc: <stable@vger.kernel.org>
> Cc: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
> ---
>
> The 0161a94e2d1c was also applied to stable releases, which is where I
> got hit by the issue.
>
>  tools/gpio/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/gpio/Makefile b/tools/gpio/Makefile
> index 842287e42c83..440434027557 100644
> --- a/tools/gpio/Makefile
> +++ b/tools/gpio/Makefile
> @@ -35,7 +35,7 @@ $(OUTPUT)include/linux/gpio.h: ../../include/uapi/linux/gpio.h
>
>  prepare: $(OUTPUT)include/linux/gpio.h
>
> -GPIO_UTILS_IN := $(output)gpio-utils-in.o
> +GPIO_UTILS_IN := $(OUTPUT)gpio-utils-in.o
>  $(GPIO_UTILS_IN): prepare FORCE
>         $(Q)$(MAKE) $(build)=gpio-utils
>
> --
> 2.21.1
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

  reply	other threads:[~2020-03-25 15:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 10:31 [PATCH] tools: gpio: Fix out-of-tree build regression Anssi Hannula
2020-03-25 15:24 ` Bartosz Golaszewski [this message]
2020-03-27 21:28 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMpxmJVrTJN_YgfvKfxbNHRKscM8rGetbc=ic6hsbqMwCJapPQ@mail.gmail.com' \
    --to=bgolaszewski@baylibre.com \
    --cc=anssi.hannula@bitwise.fi \
    --cc=labbott@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).