* Re: [PATCH v2] ipv4: ping: fix bind address validity check
[not found] ` <165546541315.12170.9716012665055247467.git-patchwork-notify@kernel.org>
@ 2022-06-17 23:45 ` Maciej Żenczykowski
2022-06-20 10:11 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Maciej Żenczykowski @ 2022-06-17 23:45 UTC (permalink / raw)
To: patchwork-bot+netdevbpf, stable
Cc: Riccardo Paolo Bestetti, Carlos Llamas, David S. Miller,
Hideaki YOSHIFUJI, David Ahern, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, kernel-team, Kernel hackers, Linux NetDev,
Miaohe Lin
On Fri, Jun 17, 2022 at 4:30 AM <patchwork-bot+netdevbpf@kernel.org> wrote:
>
> Hello:
>
> This patch was applied to netdev/net.git (master)
> by David S. Miller <davem@davemloft.net>:
>
> On Fri, 17 Jun 2022 10:54:35 +0200 you wrote:
> > Commit 8ff978b8b222 ("ipv4/raw: support binding to nonlocal addresses")
> > introduced a helper function to fold duplicated validity checks of bind
> > addresses into inet_addr_valid_or_nonlocal(). However, this caused an
> > unintended regression in ping_check_bind_addr(), which previously would
> > reject binding to multicast and broadcast addresses, but now these are
> > both incorrectly allowed as reported in [1].
> >
> > [...]
>
> Here is the summary with links:
> - [v2] ipv4: ping: fix bind address validity check
> https://git.kernel.org/netdev/net/c/b4a028c4d031
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
I believe this [
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=b4a028c4d031
] needs to end up in 5.17+ LTS (though I guess 5.17 is eol, so
probably just 5.18)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ipv4: ping: fix bind address validity check
2022-06-17 23:45 ` [PATCH v2] ipv4: ping: fix bind address validity check Maciej Żenczykowski
@ 2022-06-20 10:11 ` Greg KH
2022-06-23 18:18 ` Maciej Żenczykowski
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2022-06-20 10:11 UTC (permalink / raw)
To: Maciej Żenczykowski
Cc: patchwork-bot+netdevbpf, stable, Riccardo Paolo Bestetti,
Carlos Llamas, David S. Miller, Hideaki YOSHIFUJI, David Ahern,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, kernel-team,
Kernel hackers, Linux NetDev, Miaohe Lin
On Fri, Jun 17, 2022 at 04:45:52PM -0700, Maciej Żenczykowski wrote:
> On Fri, Jun 17, 2022 at 4:30 AM <patchwork-bot+netdevbpf@kernel.org> wrote:
> >
> > Hello:
> >
> > This patch was applied to netdev/net.git (master)
> > by David S. Miller <davem@davemloft.net>:
> >
> > On Fri, 17 Jun 2022 10:54:35 +0200 you wrote:
> > > Commit 8ff978b8b222 ("ipv4/raw: support binding to nonlocal addresses")
> > > introduced a helper function to fold duplicated validity checks of bind
> > > addresses into inet_addr_valid_or_nonlocal(). However, this caused an
> > > unintended regression in ping_check_bind_addr(), which previously would
> > > reject binding to multicast and broadcast addresses, but now these are
> > > both incorrectly allowed as reported in [1].
> > >
> > > [...]
> >
> > Here is the summary with links:
> > - [v2] ipv4: ping: fix bind address validity check
> > https://git.kernel.org/netdev/net/c/b4a028c4d031
> >
> > You are awesome, thank you!
> > --
> > Deet-doot-dot, I am a bot.
> > https://korg.docs.kernel.org/patchwork/pwbot.html
>
> I believe this [
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=b4a028c4d031
> ] needs to end up in 5.17+ LTS (though I guess 5.17 is eol, so
> probably just 5.18)
5.17 is end-of-life, sorry.
And this needs to hit Linus's tree first.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ipv4: ping: fix bind address validity check
2022-06-20 10:11 ` Greg KH
@ 2022-06-23 18:18 ` Maciej Żenczykowski
2022-06-25 14:26 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Maciej Żenczykowski @ 2022-06-23 18:18 UTC (permalink / raw)
To: Greg KH
Cc: patchwork-bot+netdevbpf, stable, Riccardo Paolo Bestetti,
Carlos Llamas, David S. Miller, Hideaki YOSHIFUJI, David Ahern,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, kernel-team,
Kernel hackers, Linux NetDev, Miaohe Lin
On Mon, Jun 20, 2022 at 3:11 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Jun 17, 2022 at 04:45:52PM -0700, Maciej Żenczykowski wrote:
> > On Fri, Jun 17, 2022 at 4:30 AM <patchwork-bot+netdevbpf@kernel.org> wrote:
> > >
> > > Hello:
> > >
> > > This patch was applied to netdev/net.git (master)
> > > by David S. Miller <davem@davemloft.net>:
> > >
> > > On Fri, 17 Jun 2022 10:54:35 +0200 you wrote:
> > > > Commit 8ff978b8b222 ("ipv4/raw: support binding to nonlocal addresses")
> > > > introduced a helper function to fold duplicated validity checks of bind
> > > > addresses into inet_addr_valid_or_nonlocal(). However, this caused an
> > > > unintended regression in ping_check_bind_addr(), which previously would
> > > > reject binding to multicast and broadcast addresses, but now these are
> > > > both incorrectly allowed as reported in [1].
> > > >
> > > > [...]
> > >
> > > Here is the summary with links:
> > > - [v2] ipv4: ping: fix bind address validity check
> > > https://git.kernel.org/netdev/net/c/b4a028c4d031
> > >
> > > You are awesome, thank you!
> > > --
> > > Deet-doot-dot, I am a bot.
> > > https://korg.docs.kernel.org/patchwork/pwbot.html
> >
> > I believe this [
> > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=b4a028c4d031
> > ] needs to end up in 5.17+ LTS (though I guess 5.17 is eol, so
> > probably just 5.18)
>
> 5.17 is end-of-life, sorry.
>
> And this needs to hit Linus's tree first.
It now has:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/net/ipv4/ping.c
ipv4: ping: fix bind address validity check
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/net/ipv4/ping.c?id=b4a028c4d031c27704ad73b1195ca69a1206941e
> thanks,
>
> greg k-h
Thanks,
Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ipv4: ping: fix bind address validity check
2022-06-23 18:18 ` Maciej Żenczykowski
@ 2022-06-25 14:26 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2022-06-25 14:26 UTC (permalink / raw)
To: Maciej Żenczykowski
Cc: patchwork-bot+netdevbpf, stable, Riccardo Paolo Bestetti,
Carlos Llamas, David S. Miller, Hideaki YOSHIFUJI, David Ahern,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, kernel-team,
Kernel hackers, Linux NetDev, Miaohe Lin
On Thu, Jun 23, 2022 at 11:18:21AM -0700, Maciej Żenczykowski wrote:
> On Mon, Jun 20, 2022 at 3:11 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Jun 17, 2022 at 04:45:52PM -0700, Maciej Żenczykowski wrote:
> > > On Fri, Jun 17, 2022 at 4:30 AM <patchwork-bot+netdevbpf@kernel.org> wrote:
> > > >
> > > > Hello:
> > > >
> > > > This patch was applied to netdev/net.git (master)
> > > > by David S. Miller <davem@davemloft.net>:
> > > >
> > > > On Fri, 17 Jun 2022 10:54:35 +0200 you wrote:
> > > > > Commit 8ff978b8b222 ("ipv4/raw: support binding to nonlocal addresses")
> > > > > introduced a helper function to fold duplicated validity checks of bind
> > > > > addresses into inet_addr_valid_or_nonlocal(). However, this caused an
> > > > > unintended regression in ping_check_bind_addr(), which previously would
> > > > > reject binding to multicast and broadcast addresses, but now these are
> > > > > both incorrectly allowed as reported in [1].
> > > > >
> > > > > [...]
> > > >
> > > > Here is the summary with links:
> > > > - [v2] ipv4: ping: fix bind address validity check
> > > > https://git.kernel.org/netdev/net/c/b4a028c4d031
> > > >
> > > > You are awesome, thank you!
> > > > --
> > > > Deet-doot-dot, I am a bot.
> > > > https://korg.docs.kernel.org/patchwork/pwbot.html
> > >
> > > I believe this [
> > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=b4a028c4d031
> > > ] needs to end up in 5.17+ LTS (though I guess 5.17 is eol, so
> > > probably just 5.18)
> >
> > 5.17 is end-of-life, sorry.
> >
> > And this needs to hit Linus's tree first.
>
> It now has:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/net/ipv4/ping.c
>
> ipv4: ping: fix bind address validity check
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/net/ipv4/ping.c?id=b4a028c4d031c27704ad73b1195ca69a1206941e
Great, now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-25 14:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220617085435.193319-1-pbl@bestov.io>
[not found] ` <165546541315.12170.9716012665055247467.git-patchwork-notify@kernel.org>
2022-06-17 23:45 ` [PATCH v2] ipv4: ping: fix bind address validity check Maciej Żenczykowski
2022-06-20 10:11 ` Greg KH
2022-06-23 18:18 ` Maciej Żenczykowski
2022-06-25 14:26 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).