stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Add "usb: dwc3: Stop active transfers before halting the controller" to 5.4-stable
@ 2021-08-06 13:25 Sam Protsenko
  2021-08-09  8:53 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 8+ messages in thread
From: Sam Protsenko @ 2021-08-06 13:25 UTC (permalink / raw)
  To: stable, Greg Kroah-Hartman; +Cc: Wesley Cheng

Hi Greg,

Suggest including next patch (available in linux-mainline) to
5.4-stable branch: commit ae7e86108b12 ("usb: dwc3: Stop active
transfers before halting the controller"). It's also already present
in 5.10 stable. Some fixes exist in 5.10-stable for that patch too.

This patch fixes panic in case of using USB2.0 Dual Role Device
controller, as described below.

1. Boot in peripheral role
2. Configure RNDIS gadget, perform ping, stop ping
3. Switch to host role
4. Kernel panic occurs

Kernel panic happens because gadget->udc->driver->disconnect() (which
is configfs_composite_disconnect()) is not called from
usb_gadget_disconnect() function, due to timeout condition in
dwc3_gadget_run_stop(), which leads to not called rndis_disable(). And
although previously created endpoints are not valid anymore,
eth_start_xmit() gets called and tries to use those, which leads to
invalid memory access. This patch fixes timeout condition, so next
call chain doesn't fail anymore, and RNDIS uninitialized properly on
gadget to host role switch:

<<<<<<<<<<<<<<<<<<<< cut here >>>>>>>>>>>>>>>>>>>
    usb_role_switch_set_role()
        v
    dwc3_usb_role_switch_set()
        v
    dwc3_set_mode()
        v
    __dwc3_set_mode()
        v
    dwc3_gadget_exit()
        v
    usb_del_gadget_udc()
        v
    usb_gadget_remove_driver()
        v
    usb_gadget_disconnect()
        v
    // THIS IS NOT CALLED because gadget->ops->pullup() =
    // dwc3_gadget_pullup() returns -ETIMEDOUT (-110)
    gadget->udc->driver->disconnect()
    // = configfs_composite_disconnect()
        v
    composite_disconnect()
        v
    reset_config()
        v
    foreach (f : function) : f->disable
        v
    rndis_disable()
        v
    gether_disconnect()
        v
    usb_ep_disable(),
    dev->port_usb = NULL
<<<<<<<<<<<<<<<<<<<< cut here >>>>>>>>>>>>>>>>>>>

Thanks!

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-08-12 17:19 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 13:25 Add "usb: dwc3: Stop active transfers before halting the controller" to 5.4-stable Sam Protsenko
2021-08-09  8:53 ` Greg Kroah-Hartman
2021-08-09 16:58   ` Sam Protsenko
2021-08-10  7:27     ` Greg Kroah-Hartman
2021-08-10 14:52       ` Greg Kroah-Hartman
2021-08-10 14:58         ` Greg Kroah-Hartman
2021-08-10 17:55           ` Sam Protsenko
2021-08-12 17:19             ` Sam Protsenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).