* [PATCH net v2 1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function
@ 2023-04-06 1:40 Song Yoong Siang
2023-04-06 2:04 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Song Yoong Siang @ 2023-04-06 1:40 UTC (permalink / raw)
To: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Maxime Coquelin, Alexei Starovoitov, Daniel Borkmann,
Jesper Dangaard Brouer, John Fastabend, Christian Marangi,
Alexander Duyck
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel, bpf, stable,
Song Yoong Siang
Queue reset was moved out from __init_dma_rx_desc_rings() and
__init_dma_tx_desc_rings() functions. Thus, the driver fails to transmit
and receive packet after XDP prog setup.
This commit adds the missing queue reset into stmmac_xdp_open() function.
v2: Add reviewed-by tag
Fixes: f9ec5723c3db ("net: ethernet: stmicro: stmmac: move queue reset to dedicated functions")
Cc: <stable@vger.kernel.org> # 6.0+
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 3e5bbfe3c41b..e4c27eb17bd2 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -6630,6 +6630,8 @@ int stmmac_xdp_open(struct net_device *dev)
goto init_error;
}
+ stmmac_reset_queues_param(priv);
+
/* DMA CSR Channel configuration */
for (chan = 0; chan < dma_csr_ch; chan++) {
stmmac_init_chan(priv, priv->ioaddr, priv->plat->dma_cfg, chan);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2 1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function
2023-04-06 1:40 [PATCH net v2 1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function Song Yoong Siang
@ 2023-04-06 2:04 ` Jakub Kicinski
2023-04-06 14:55 ` Song, Yoong Siang
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2023-04-06 2:04 UTC (permalink / raw)
To: Song Yoong Siang
Cc: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
David S . Miller, Eric Dumazet, Paolo Abeni, Maxime Coquelin,
Alexei Starovoitov, Daniel Borkmann, Jesper Dangaard Brouer,
John Fastabend, Christian Marangi, Alexander Duyck, netdev,
linux-stm32, linux-arm-kernel, linux-kernel, bpf, stable
On Thu, 6 Apr 2023 09:40:04 +0800 Song Yoong Siang wrote:
> v2: Add reviewed-by tag
You don't have to repost to add tags, maintainers will collect
the tags sent to the list when applying the patch. I'm taking v1.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH net v2 1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function
2023-04-06 2:04 ` Jakub Kicinski
@ 2023-04-06 14:55 ` Song, Yoong Siang
0 siblings, 0 replies; 3+ messages in thread
From: Song, Yoong Siang @ 2023-04-06 14:55 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
David S . Miller, Eric Dumazet, Paolo Abeni, Maxime Coquelin,
Alexei Starovoitov, Daniel Borkmann, Jesper Dangaard Brouer,
John Fastabend, Christian Marangi, Alexander Duyck, netdev,
linux-stm32, linux-arm-kernel, linux-kernel, bpf, stable
>On Thu, 6 Apr 2023 09:40:04 +0800 Song Yoong Siang wrote:
>> v2: Add reviewed-by tag
>
>You don't have to repost to add tags, maintainers will collect the tags sent to the
>list when applying the patch. I'm taking v1.
Noted. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-06 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-06 1:40 [PATCH net v2 1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function Song Yoong Siang
2023-04-06 2:04 ` Jakub Kicinski
2023-04-06 14:55 ` Song, Yoong Siang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).