From: Peter Chen <peter.chen@nxp.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: patch "usb: chipidea: fix static checker warning for NULL pointer" added to usb-linus
Date: Mon, 21 Jan 2019 05:29:19 +0000 [thread overview]
Message-ID: <VI1PR04MB5327D98EF458B564DCFDB5D78B9F0@VI1PR04MB5327.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <15478007419157@kroah.com>
> This is a note to let you know that I've just added the patch titled
>
> usb: chipidea: fix static checker warning for NULL pointer
>
> to my usb git tree which can be found at
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
> in the usb-linus branch.
>
> The patch will show up in the next release of the linux-next tree (usually sometime
> within the next 24 hours during the week.)
>
> The patch will hopefully also be merged in Linus's tree for the next -rc kernel
> release.
>
> If you have any questions about this process, please let me know.
>
>
Hi Greg,
This patch does not need to go stable tree, this issue is introduced by v5.0-rc1.
Thanks.
Peter
> From 8ff396fe56f5593640a8ce7223cac33a2cda619e Mon Sep 17 00:00:00 2001
> From: Peter Chen <peter.chen@nxp.com>
> Date: Thu, 17 Jan 2019 09:24:20 +0000
> Subject: usb: chipidea: fix static checker warning for NULL pointer
>
> During the static checker, "data->usbmisc_data" may be NULL.
> Fix it by adding this pointer judgement before using.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index e81de9ca8729..9b45aa422e69 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -316,7 +316,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> if (IS_ERR(data->usbmisc_data))
> return PTR_ERR(data->usbmisc_data);
>
> - if (of_usb_get_phy_mode(dev->of_node) ==
> USBPHY_INTERFACE_MODE_HSIC) {
> + if ((of_usb_get_phy_mode(dev->of_node) ==
> USBPHY_INTERFACE_MODE_HSIC)
> + && data->usbmisc_data) {
> pdata.flags |= CI_HDRC_IMX_IS_HSIC;
> data->usbmisc_data->hsic = 1;
> data->pinctrl = devm_pinctrl_get(dev);
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-01-21 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 8:39 patch "usb: chipidea: fix static checker warning for NULL pointer" added to usb-linus gregkh
2019-01-21 5:29 ` Peter Chen [this message]
2019-01-21 7:21 ` gregkh
2019-01-21 7:26 ` Peter Chen
[not found] ` <20190122155555.0AF57217D4@mail.kernel.org>
2019-01-22 16:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB5327D98EF458B564DCFDB5D78B9F0@VI1PR04MB5327.eurprd04.prod.outlook.com \
--to=peter.chen@nxp.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).