stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: Jason Baron <jbaron@akamai.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] dyndbg: fix use before null check
Date: Wed, 9 Dec 2020 15:54:26 +0100	[thread overview]
Message-ID: <X9DlIkNg2mVf20Bo@kroah.com> (raw)
In-Reply-To: <20201123184334.1777186-1-jim.cromie@gmail.com>

On Mon, Nov 23, 2020 at 11:43:34AM -0700, Jim Cromie wrote:
> commit a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()")
> 
> Above commit copies a string before checking for null pointer, fix
> this, and add a pr_err.  Also trim comment, and add return val info.

The way you list the above commit is very odd, and hard to read and
understand.  How about something like:

	In commit a2d375eda771 ("dyndbg: refine export, rename to
	dynamic_debug_exec_queries()"), a string is copied before
	checking....


Also, when you say "also" in a patch, that is a HUGE flag that the
commit needs to be broken up into multiple patches.  Put the bugfix
first, and then fix up the comment later, if it is not being changed for
this fix.

Also:

> Fixes: a2d375eda771

You need the full information here, please write:
	Fixes: a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()")


Can you fix all of that up and resend?

thanks,

greg k-h

      reply	other threads:[~2020-12-09 14:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 18:43 [PATCH] dyndbg: fix use before null check Jim Cromie
2020-12-09 14:54 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9DlIkNg2mVf20Bo@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jbaron@akamai.com \
    --cc=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).