From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>,
stable@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, bard.liao@intel.com
Subject: Re: [PATCH] soundwire: intel: Initialize clock stop timeout
Date: Fri, 11 Nov 2022 09:41:25 +0530 [thread overview]
Message-ID: <Y23LbSfwWnVS3ZAo@matsya> (raw)
In-Reply-To: <e5acf9e3-20b9-00b3-8d5f-687d47ccd49c@linux.intel.com>
On 09-11-22, 10:05, Pierre-Louis Bossart wrote:
>
>
> On 10/28/22 06:28, Vinod Koul wrote:
> > On 20-10-22, 09:56, Bard Liao wrote:
> >> From: Sjoerd Simons <sjoerd@collabora.com>
> >>
> >> The bus->clk_stop_timeout member is only initialized to a non-zero value
> >> during the codec driver probe. This can lead to corner cases where this
> >> value remains pegged at zero when the bus suspends, which results in an
> >> endless loop in sdw_bus_wait_for_clk_prep_deprep().
> >>
> >> Corner cases include configurations with no codecs described in the
> >> firmware, or delays in probing codec drivers.
> >>
> >> Initializing the default timeout to the smallest non-zero value avoid this
> >> problem and allows for the existing logic to be preserved: the
> >> bus->clk_stop_timeout is set as the maximum required by all codecs
> >> connected on the bus.
> >
> > Applied to fixes, thanks
>
> Thanks Vinod, was this sent to Greg/Linus? the last pull request I see
> was for 6.1-rc1.
> Arch Linux cherry-picked this patch but other distros did not, so quite
> a few users are left with no audio card.
https://git.kernel.org/torvalds/c/f014699cca9a9a28fbdc06a9225b54562154fc20
--
~Vinod
next prev parent reply other threads:[~2022-11-11 4:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 1:56 [PATCH] soundwire: intel: Initialize clock stop timeout Bard Liao
2022-10-20 1:54 ` kernel test robot
2022-10-21 16:37 ` Pierre-Louis Bossart
2022-10-28 11:28 ` Vinod Koul
2022-11-09 16:05 ` Pierre-Louis Bossart
2022-11-11 4:11 ` Vinod Koul [this message]
2022-12-05 17:06 Pierre-Louis Bossart
2022-12-05 18:33 ` Greg KH
2022-12-05 19:33 ` Pierre-Louis Bossart
2022-12-08 20:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y23LbSfwWnVS3ZAo@matsya \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).