From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com,
iommu@lists.linux-foundation.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
obayashi.yoshimasa@socionext.com
Subject: Re: DMA direct mapping fix for 5.4 and earlier stable branches
Date: Tue, 9 Feb 2021 07:58:35 +0100 [thread overview]
Message-ID: <YCIym62vHfbG+dWf@kroah.com> (raw)
In-Reply-To: <CAFA6WYNazCmYN20irLdNV+2vcv5dqR+grvaY-FA7q2WOBMs__g@mail.gmail.com>
On Tue, Feb 09, 2021 at 11:39:25AM +0530, Sumit Garg wrote:
> Hi Christoph, Greg,
>
> Currently we are observing an incorrect address translation
> corresponding to DMA direct mapping methods on 5.4 stable kernel while
> sharing dmabuf from one device to another where both devices have
> their own coherent DMA memory pools.
What devices have this problem? And why can't then just use 5.10 to
solve this issue as that problem has always been present for them,
right?
> I am able to root cause this issue which is caused by incorrect virt
> to phys translation for addresses belonging to vmalloc space using
> virt_to_page(). But while looking at the mainline kernel, this patch
> [1] changes address translation from virt->to->phys to dma->to->phys
> which fixes the issue observed on 5.4 stable kernel as well (minimal
> fix [2]).
>
> So I would like to seek your suggestion for backport to stable kernels
> (5.4 or earlier) as to whether we should backport the complete
> mainline commit [1] or we should just apply the minimal fix [2]?
Whenever you try to create a "minimal" fix, 90% of the time it is wrong
and does not work and I end up having to deal with the mess. What
prevents you from doing the real thing here? Are the patches to big?
And again, why not just use 5.10 for this hardware? What hardware is
it?
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-09 6:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 6:09 DMA direct mapping fix for 5.4 and earlier stable branches Sumit Garg
2021-02-09 6:58 ` Greg Kroah-Hartman [this message]
2021-02-09 7:58 ` Sumit Garg
2021-02-09 8:04 ` Greg Kroah-Hartman
2021-02-09 9:05 ` obayashi.yoshimasa
2021-02-09 9:23 ` Greg KH
2021-02-09 9:36 ` Christoph Hellwig
2021-02-09 12:36 ` Sumit Garg
2021-02-09 12:45 ` Robin Murphy
2021-02-09 15:50 ` Christoph Hellwig
2021-02-09 10:19 ` obayashi.yoshimasa
2021-02-09 10:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCIym62vHfbG+dWf@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel.thompson@linaro.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=obayashi.yoshimasa@socionext.com \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).