stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] clk: imx6q: fix uart earlycon unwork
@ 2021-07-02  8:54 Dong Aisheng
  2021-07-19 10:39 ` Abel Vesa
  2021-08-06  1:12 ` Stephen Boyd
  0 siblings, 2 replies; 5+ messages in thread
From: Dong Aisheng @ 2021-07-02  8:54 UTC (permalink / raw)
  To: linux-clk
  Cc: linux-arm-kernel, sboyd, dongas86, shawnguo, kernel, abel.vesa,
	aford173, Dong Aisheng, stable

The earlycon depends on the bootloader setup UART clocks being retained.
There're actually two uart clocks (ipg, per) on MX6QDL,
but the 'Fixes' commit change to register only one which means
another clock may be disabled during booting phase
and result in the earlycon unwork.

Cc: stable@vger.kernel.org # v5.10+
Fixes: 379c9a24cc23 ("clk: imx: Fix reparenting of UARTs not associated with stdout")
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 drivers/clk/imx/clk-imx6q.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
index 496900de0b0b..de36f58d551c 100644
--- a/drivers/clk/imx/clk-imx6q.c
+++ b/drivers/clk/imx/clk-imx6q.c
@@ -974,6 +974,6 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
 			       hws[IMX6QDL_CLK_PLL3_USB_OTG]->clk);
 	}
 
-	imx_register_uart_clocks(1);
+	imx_register_uart_clocks(2);
 }
 CLK_OF_DECLARE(imx6q, "fsl,imx6q-ccm", imx6q_clocks_init);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] clk: imx6q: fix uart earlycon unwork
  2021-07-02  8:54 [PATCH 1/1] clk: imx6q: fix uart earlycon unwork Dong Aisheng
@ 2021-07-19 10:39 ` Abel Vesa
  2021-07-27 20:51   ` Stephen Boyd
  2021-08-06  1:12 ` Stephen Boyd
  1 sibling, 1 reply; 5+ messages in thread
From: Abel Vesa @ 2021-07-19 10:39 UTC (permalink / raw)
  To: Dong Aisheng, Stephen Boyd
  Cc: linux-clk, linux-arm-kernel, sboyd, dongas86, shawnguo, kernel,
	aford173, stable

On 21-07-02 16:54:38, Dong Aisheng wrote:
> The earlycon depends on the bootloader setup UART clocks being retained.
> There're actually two uart clocks (ipg, per) on MX6QDL,
> but the 'Fixes' commit change to register only one which means
> another clock may be disabled during booting phase
> and result in the earlycon unwork.
> 
> Cc: stable@vger.kernel.org # v5.10+
> Fixes: 379c9a24cc23 ("clk: imx: Fix reparenting of UARTs not associated with stdout")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>


Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

Stephen, will you pick this up ?

> ---
>  drivers/clk/imx/clk-imx6q.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
> index 496900de0b0b..de36f58d551c 100644
> --- a/drivers/clk/imx/clk-imx6q.c
> +++ b/drivers/clk/imx/clk-imx6q.c
> @@ -974,6 +974,6 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
>  			       hws[IMX6QDL_CLK_PLL3_USB_OTG]->clk);
>  	}
>  
> -	imx_register_uart_clocks(1);
> +	imx_register_uart_clocks(2);
>  }
>  CLK_OF_DECLARE(imx6q, "fsl,imx6q-ccm", imx6q_clocks_init);
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] clk: imx6q: fix uart earlycon unwork
  2021-07-19 10:39 ` Abel Vesa
@ 2021-07-27 20:51   ` Stephen Boyd
  2021-07-28  8:28     ` Abel Vesa
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2021-07-27 20:51 UTC (permalink / raw)
  To: Abel Vesa, Dong Aisheng
  Cc: linux-clk, linux-arm-kernel, dongas86, shawnguo, kernel,
	aford173, stable

Quoting Abel Vesa (2021-07-19 03:39:31)
> On 21-07-02 16:54:38, Dong Aisheng wrote:
> > The earlycon depends on the bootloader setup UART clocks being retained.
> > There're actually two uart clocks (ipg, per) on MX6QDL,
> > but the 'Fixes' commit change to register only one which means
> > another clock may be disabled during booting phase
> > and result in the earlycon unwork.
> > 
> > Cc: stable@vger.kernel.org # v5.10+
> > Fixes: 379c9a24cc23 ("clk: imx: Fix reparenting of UARTs not associated with stdout")
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> 
> 
> Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> 
> Stephen, will you pick this up ?
> 

Sure I can pick it up if you need me to pick it to fixes?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] clk: imx6q: fix uart earlycon unwork
  2021-07-27 20:51   ` Stephen Boyd
@ 2021-07-28  8:28     ` Abel Vesa
  0 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2021-07-28  8:28 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Dong Aisheng, linux-clk, linux-arm-kernel, dongas86, shawnguo,
	kernel, aford173, stable

On 21-07-27 13:51:10, Stephen Boyd wrote:
> Quoting Abel Vesa (2021-07-19 03:39:31)
> > On 21-07-02 16:54:38, Dong Aisheng wrote:
> > > The earlycon depends on the bootloader setup UART clocks being retained.
> > > There're actually two uart clocks (ipg, per) on MX6QDL,
> > > but the 'Fixes' commit change to register only one which means
> > > another clock may be disabled during booting phase
> > > and result in the earlycon unwork.
> > > 
> > > Cc: stable@vger.kernel.org # v5.10+
> > > Fixes: 379c9a24cc23 ("clk: imx: Fix reparenting of UARTs not associated with stdout")
> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > 
> > 
> > Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> > 
> > Stephen, will you pick this up ?
> > 
> 
> Sure I can pick it up if you need me to pick it to fixes?

Yes, please.

Thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] clk: imx6q: fix uart earlycon unwork
  2021-07-02  8:54 [PATCH 1/1] clk: imx6q: fix uart earlycon unwork Dong Aisheng
  2021-07-19 10:39 ` Abel Vesa
@ 2021-08-06  1:12 ` Stephen Boyd
  1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2021-08-06  1:12 UTC (permalink / raw)
  To: Dong Aisheng, linux-clk
  Cc: linux-arm-kernel, dongas86, shawnguo, kernel, abel.vesa,
	aford173, Dong Aisheng, stable

Quoting Dong Aisheng (2021-07-02 01:54:38)
> The earlycon depends on the bootloader setup UART clocks being retained.
> There're actually two uart clocks (ipg, per) on MX6QDL,
> but the 'Fixes' commit change to register only one which means
> another clock may be disabled during booting phase
> and result in the earlycon unwork.
> 
> Cc: stable@vger.kernel.org # v5.10+
> Fixes: 379c9a24cc23 ("clk: imx: Fix reparenting of UARTs not associated with stdout")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---

Applied to clk-fixes

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-06  1:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02  8:54 [PATCH 1/1] clk: imx6q: fix uart earlycon unwork Dong Aisheng
2021-07-19 10:39 ` Abel Vesa
2021-07-27 20:51   ` Stephen Boyd
2021-07-28  8:28     ` Abel Vesa
2021-08-06  1:12 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).