From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Frieder Schrempf <frieder@fris.de>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
stable@vger.kernel.org,
voice INTER connect GmbH <developer@voiceinterconnect.de>,
Alexander Lobakin <alobakin@pm.me>, Felix Fietkau <nbd@nbd.name>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Richard Weinberger <richard@nod.at>,
YouChing Lin <ycllin@mxic.com.tw>
Subject: Re: [PATCH v2 5.10.x] mtd: spinand: Fix incorrect parameters for on-die ECC
Date: Wed, 1 Sep 2021 10:17:59 +0200 [thread overview]
Message-ID: <YS83NzasS7jExTya@kroah.com> (raw)
In-Reply-To: <20210830130211.445728-1-frieder@fris.de>
On Mon, Aug 30, 2021 at 03:02:10PM +0200, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> The new generic NAND ECC framework stores the configuration and
> requirements in separate places since commit 93ef92f6f422 ("mtd: nand: Use
> the new generic ECC object"). In 5.10.x The SPI NAND layer still uses only
> the requirements to track the ECC properties. This mismatch leads to
> values of zero being used for ECC strength and step_size in the SPI NAND
> layer wherever nanddev_get_ecc_conf() is used and therefore breaks the SPI
> NAND on-die ECC support in 5.10.x.
>
> By using nanddev_get_ecc_requirements() instead of nanddev_get_ecc_conf()
> for SPI NAND, we make sure that the correct parameters for the detected
> chip are used. In later versions (5.11.x) this is fixed anyway with the
> implementation of the SPI NAND on-die ECC engine.
>
> Cc: stable@vger.kernel.org # 5.10.x
> Reported-by: voice INTER connect GmbH <developer@voiceinterconnect.de>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> Changes in v2:
> * Fix checkpatch error/warnings for commit message style
> * Add Miquel's A-b tag
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2021-09-01 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 13:02 [PATCH v2 5.10.x] mtd: spinand: Fix incorrect parameters for on-die ECC Frieder Schrempf
2021-09-01 8:17 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS83NzasS7jExTya@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alobakin@pm.me \
--cc=developer@voiceinterconnect.de \
--cc=frieder.schrempf@kontron.de \
--cc=frieder@fris.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=nbd@nbd.name \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=ycllin@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).