* Apply a52f8a59aef46b59753e583bf4b28fccb069ce64 to 5.15 through 4.19
@ 2021-11-15 18:39 Nathan Chancellor
2021-11-19 12:35 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Nathan Chancellor @ 2021-11-15 18:39 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sasha Levin, Kees Cook, Nick Desaulniers; +Cc: stable, llvm
Hi Greg and Sasha,
There is a build error with newer versions of clang due to a broken
FORTIFY_SOURCE implementation, which has never worked:
https://github.com/ClangBuiltLinux/linux/issues/1496
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1457787760
Please apply upstream commit a52f8a59aef4 ("fortify: Explicitly disable
Clang support") to 5.15 through 4.19 to resolve this. It should apply
cleanly.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Apply a52f8a59aef46b59753e583bf4b28fccb069ce64 to 5.15 through 4.19
2021-11-15 18:39 Apply a52f8a59aef46b59753e583bf4b28fccb069ce64 to 5.15 through 4.19 Nathan Chancellor
@ 2021-11-19 12:35 ` Greg Kroah-Hartman
2021-11-19 16:16 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2021-11-19 12:35 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: Sasha Levin, Kees Cook, Nick Desaulniers, stable, llvm
On Mon, Nov 15, 2021 at 11:39:18AM -0700, Nathan Chancellor wrote:
> Hi Greg and Sasha,
>
> There is a build error with newer versions of clang due to a broken
> FORTIFY_SOURCE implementation, which has never worked:
>
> https://github.com/ClangBuiltLinux/linux/issues/1496
> https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1457787760
>
> Please apply upstream commit a52f8a59aef4 ("fortify: Explicitly disable
> Clang support") to 5.15 through 4.19 to resolve this. It should apply
> cleanly.
Hah! Oh the Android people are going to _LOVE_ this one...
{sigh}
I'll go do this now...
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Apply a52f8a59aef46b59753e583bf4b28fccb069ce64 to 5.15 through 4.19
2021-11-19 12:35 ` Greg Kroah-Hartman
@ 2021-11-19 16:16 ` Kees Cook
0 siblings, 0 replies; 3+ messages in thread
From: Kees Cook @ 2021-11-19 16:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Nathan Chancellor, Sasha Levin, Nick Desaulniers, stable, llvm
On Fri, Nov 19, 2021 at 01:35:22PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 15, 2021 at 11:39:18AM -0700, Nathan Chancellor wrote:
> > Hi Greg and Sasha,
> >
> > There is a build error with newer versions of clang due to a broken
> > FORTIFY_SOURCE implementation, which has never worked:
> >
> > https://github.com/ClangBuiltLinux/linux/issues/1496
> > https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1457787760
> >
> > Please apply upstream commit a52f8a59aef4 ("fortify: Explicitly disable
> > Clang support") to 5.15 through 4.19 to resolve this. It should apply
> > cleanly.
>
> Hah! Oh the Android people are going to _LOVE_ this one...
They (we) are already aware[1]. Fortify has always been broken under
Clang, so really this doesn't change anything for Android builds. :P
But yes, one of many motivations of the recent memcpy and fortify work
has been to get fortify fixed for Clang. Hopefully this will be all done
by 5.17.
-Kees
[1] https://github.com/KSPP/linux/issues/77
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-19 16:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15 18:39 Apply a52f8a59aef46b59753e583bf4b28fccb069ce64 to 5.15 through 4.19 Nathan Chancellor
2021-11-19 12:35 ` Greg Kroah-Hartman
2021-11-19 16:16 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).