[PATCH 1/2] block: Add a helper to validate the block size

* [PATCH 1/2] block: Add a helper to validate the block size
@ 2022-03-30 11:01 Lee Jones
  2022-03-30 11:01 ` [PATCH 2/2] virtio-blk: Use blk_validate_block_size() to validate " Lee Jones
  2022-03-30 11:08 ` [PATCH 1/2] block: Add a helper to validate the " Lee Jones
  0 siblings, 2 replies; 5+ messages in thread
From: Lee Jones @ 2022-03-30 11:01 UTC (permalink / raw)
  To: lee.jones; +Cc: stable, Xie Yongji, Jens Axboe

From: Xie Yongji <xieyongji@bytedance.com>

[ Upstream commit 570b1cac477643cbf01a45fa5d018430a1fddbce ]

There are some duplicated codes to validate the block
size in block drivers. This limitation actually comes
from block layer, so this patch tries to add a new block
layer helper for that.

Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Link: https://lore.kernel.org/r/20211026144015.188-2-xieyongji@bytedance.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 include/linux/blkdev.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index d5338b9ee5502..8cc766743270f 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -59,6 +59,14 @@ struct blk_stat_callback;
  */
 #define BLKCG_MAX_POLS		5
 
+static inline int blk_validate_block_size(unsigned int bsize)
+{
+	if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize))
+		return -EINVAL;
+
+	return 0;
+}
+
 typedef void (rq_end_io_fn)(struct request *, blk_status_t);
 
 /*
-- 
2.35.1.1021.g381101b075-goog


^ permalink raw reply related	[flat|nested] 5+ messages in thread