* btrfs warning fixes for 5.15 and 5.17
@ 2022-04-14 20:29 Nathan Chancellor
2022-04-15 4:57 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2022-04-14 20:29 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sasha Levin
Cc: stable, llvm, Nick Desaulniers, linux-btrfs
Hi Greg and Sasha,
Please apply
ad3fc7946b18 ("btrfs: remove no longer used counter when reading data page")
6d4a6b515c39 ("btrfs: remove unused variable in btrfs_{start,write}_dirty_block_groups()")
to 5.15 and 5.17 and
cd9255be6980 ("btrfs: remove unused parameter nr_pages in add_ra_bio_pages()")
to 5.15 (it landed in 5.16), as they all resolve build errors with
CONFIG_WERROR=y and tip of tree clang, which recently added support for
unary operations in -Wunused-but-set-variable. They all apply cleanly
and I do not see any additional build warnings and errors.
Commit 6d4a6b515c39 was specifically tagged for stable back to 5.4,
which should be fine, but it really only needs to go back to 5.12+, as
btrfs turned on W=1 (which includes this warning) for itself in commit
e9aa7c285d20 ("btrfs: enable W=1 checks for btrfs"), which landed in
5.12-rc1. Prior that that change, none of these warnings will be
visible under a normal build.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: btrfs warning fixes for 5.15 and 5.17
2022-04-14 20:29 btrfs warning fixes for 5.15 and 5.17 Nathan Chancellor
@ 2022-04-15 4:57 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2022-04-15 4:57 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Sasha Levin, stable, llvm, Nick Desaulniers, linux-btrfs
On Thu, Apr 14, 2022 at 01:29:45PM -0700, Nathan Chancellor wrote:
> Hi Greg and Sasha,
>
> Please apply
>
> ad3fc7946b18 ("btrfs: remove no longer used counter when reading data page")
> 6d4a6b515c39 ("btrfs: remove unused variable in btrfs_{start,write}_dirty_block_groups()")
>
> to 5.15 and 5.17 and
>
> cd9255be6980 ("btrfs: remove unused parameter nr_pages in add_ra_bio_pages()")
>
> to 5.15 (it landed in 5.16), as they all resolve build errors with
> CONFIG_WERROR=y and tip of tree clang, which recently added support for
> unary operations in -Wunused-but-set-variable. They all apply cleanly
> and I do not see any additional build warnings and errors.
>
> Commit 6d4a6b515c39 was specifically tagged for stable back to 5.4,
> which should be fine, but it really only needs to go back to 5.12+, as
> btrfs turned on W=1 (which includes this warning) for itself in commit
> e9aa7c285d20 ("btrfs: enable W=1 checks for btrfs"), which landed in
> 5.12-rc1. Prior that that change, none of these warnings will be
> visible under a normal build.
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-15 5:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 20:29 btrfs warning fixes for 5.15 and 5.17 Nathan Chancellor
2022-04-15 4:57 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).