stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"
@ 2019-01-29 16:57 Alex Deucher
  2019-01-29 17:38 ` Greg KH
  2019-01-29 18:28 ` Wentland, Harry
  0 siblings, 2 replies; 5+ messages in thread
From: Alex Deucher @ 2019-01-29 16:57 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alex Deucher, stable

This reverts commit 10117450735c7a7c0858095fb46a860e7037cb9a.

Causes a crash.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109487
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org # 4.19
---
 drivers/gpu/drm/amd/display/dc/calcs/Makefile | 2 +-
 drivers/gpu/drm/amd/display/dc/dml/Makefile   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/calcs/Makefile b/drivers/gpu/drm/amd/display/dc/calcs/Makefile
index dc85a3c088af..95f332ee3e7e 100644
--- a/drivers/gpu/drm/amd/display/dc/calcs/Makefile
+++ b/drivers/gpu/drm/amd/display/dc/calcs/Makefile
@@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),)
 	cc_stack_align := -mstack-alignment=16
 endif
 
-calcs_ccflags := -mhard-float -msse -msse2 $(cc_stack_align)
+calcs_ccflags := -mhard-float -msse $(cc_stack_align)
 
 CFLAGS_dcn_calcs.o := $(calcs_ccflags)
 CFLAGS_dcn_calc_auto.o := $(calcs_ccflags)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Makefile
index 33c7d7588712..d97ca6528f9d 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/Makefile
+++ b/drivers/gpu/drm/amd/display/dc/dml/Makefile
@@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),)
 	cc_stack_align := -mstack-alignment=16
 endif
 
-dml_ccflags := -mhard-float -msse -msse2 $(cc_stack_align)
+dml_ccflags := -mhard-float -msse $(cc_stack_align)
 
 CFLAGS_display_mode_lib.o := $(dml_ccflags)
 CFLAGS_display_pipe_clocks.o := $(dml_ccflags)
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"
  2019-01-29 16:57 [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines" Alex Deucher
@ 2019-01-29 17:38 ` Greg KH
  2019-01-29 18:07   ` Alex Deucher
  2019-01-29 18:28 ` Wentland, Harry
  1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-01-29 17:38 UTC (permalink / raw)
  To: Alex Deucher; +Cc: amd-gfx, Alex Deucher, stable

On Tue, Jan 29, 2019 at 11:57:25AM -0500, Alex Deucher wrote:
> This reverts commit 10117450735c7a7c0858095fb46a860e7037cb9a.

$ git show  10117450735c7a7c0858095fb46a860e7037cb9a
fatal: bad object 10117450735c7a7c0858095fb46a860e7037cb9a

odd...


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"
  2019-01-29 17:38 ` Greg KH
@ 2019-01-29 18:07   ` Alex Deucher
  0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2019-01-29 18:07 UTC (permalink / raw)
  To: Greg KH; +Cc: amd-gfx list, Alex Deucher, for 3.8

On Tue, Jan 29, 2019 at 12:38 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jan 29, 2019 at 11:57:25AM -0500, Alex Deucher wrote:
> > This reverts commit 10117450735c7a7c0858095fb46a860e7037cb9a.
>
> $ git show  10117450735c7a7c0858095fb46a860e7037cb9a
> fatal: bad object 10117450735c7a7c0858095fb46a860e7037cb9a
>
> odd...
>

Sorry, it's queued up for drm-next, but hasn't made it to mainline yet.

Alex

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"
  2019-01-29 16:57 [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines" Alex Deucher
  2019-01-29 17:38 ` Greg KH
@ 2019-01-29 18:28 ` Wentland, Harry
  2019-01-30 10:35   ` Christian König
  1 sibling, 1 reply; 5+ messages in thread
From: Wentland, Harry @ 2019-01-29 18:28 UTC (permalink / raw)
  To: Alex Deucher, amd-gfx; +Cc: Deucher, Alexander, stable

On 2019-01-29 11:57 a.m., Alex Deucher wrote:
> This reverts commit 10117450735c7a7c0858095fb46a860e7037cb9a.
> 
> Causes a crash.
> 
> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109487
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org # 4.19

Thanks for finding and reverting.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/calcs/Makefile | 2 +-
>  drivers/gpu/drm/amd/display/dc/dml/Makefile   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/calcs/Makefile b/drivers/gpu/drm/amd/display/dc/calcs/Makefile
> index dc85a3c088af..95f332ee3e7e 100644
> --- a/drivers/gpu/drm/amd/display/dc/calcs/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/calcs/Makefile
> @@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),)
>  	cc_stack_align := -mstack-alignment=16
>  endif
>  
> -calcs_ccflags := -mhard-float -msse -msse2 $(cc_stack_align)
> +calcs_ccflags := -mhard-float -msse $(cc_stack_align)
>  
>  CFLAGS_dcn_calcs.o := $(calcs_ccflags)
>  CFLAGS_dcn_calc_auto.o := $(calcs_ccflags)
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Makefile
> index 33c7d7588712..d97ca6528f9d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dml/Makefile
> @@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),)
>  	cc_stack_align := -mstack-alignment=16
>  endif
>  
> -dml_ccflags := -mhard-float -msse -msse2 $(cc_stack_align)
> +dml_ccflags := -mhard-float -msse $(cc_stack_align)
>  
>  CFLAGS_display_mode_lib.o := $(dml_ccflags)
>  CFLAGS_display_pipe_clocks.o := $(dml_ccflags)
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"
  2019-01-29 18:28 ` Wentland, Harry
@ 2019-01-30 10:35   ` Christian König
  0 siblings, 0 replies; 5+ messages in thread
From: Christian König @ 2019-01-30 10:35 UTC (permalink / raw)
  To: Wentland, Harry, Alex Deucher, amd-gfx; +Cc: Deucher, Alexander, stable

Am 29.01.19 um 19:28 schrieb Wentland, Harry:
> On 2019-01-29 11:57 a.m., Alex Deucher wrote:
>> This reverts commit 10117450735c7a7c0858095fb46a860e7037cb9a.
>>
>> Causes a crash.
>>
>> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109487
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>> Cc: stable@vger.kernel.org # 4.19
> Thanks for finding and reverting.
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

I find it really troubling that we run into so many issues with that.

Christian.

>
> Harry
>
>> ---
>>   drivers/gpu/drm/amd/display/dc/calcs/Makefile | 2 +-
>>   drivers/gpu/drm/amd/display/dc/dml/Makefile   | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/calcs/Makefile b/drivers/gpu/drm/amd/display/dc/calcs/Makefile
>> index dc85a3c088af..95f332ee3e7e 100644
>> --- a/drivers/gpu/drm/amd/display/dc/calcs/Makefile
>> +++ b/drivers/gpu/drm/amd/display/dc/calcs/Makefile
>> @@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),)
>>   	cc_stack_align := -mstack-alignment=16
>>   endif
>>   
>> -calcs_ccflags := -mhard-float -msse -msse2 $(cc_stack_align)
>> +calcs_ccflags := -mhard-float -msse $(cc_stack_align)
>>   
>>   CFLAGS_dcn_calcs.o := $(calcs_ccflags)
>>   CFLAGS_dcn_calc_auto.o := $(calcs_ccflags)
>> diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Makefile
>> index 33c7d7588712..d97ca6528f9d 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dml/Makefile
>> +++ b/drivers/gpu/drm/amd/display/dc/dml/Makefile
>> @@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),)
>>   	cc_stack_align := -mstack-alignment=16
>>   endif
>>   
>> -dml_ccflags := -mhard-float -msse -msse2 $(cc_stack_align)
>> +dml_ccflags := -mhard-float -msse $(cc_stack_align)
>>   
>>   CFLAGS_display_mode_lib.o := $(dml_ccflags)
>>   CFLAGS_display_pipe_clocks.o := $(dml_ccflags)
>>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-30 10:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 16:57 [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines" Alex Deucher
2019-01-29 17:38 ` Greg KH
2019-01-29 18:07   ` Alex Deucher
2019-01-29 18:28 ` Wentland, Harry
2019-01-30 10:35   ` Christian König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).