* [PATCH] drm/i915: Mark AML 0x87CA as ULX
@ 2019-03-22 20:49 Ville Syrjala
2019-03-22 21:37 ` Souza, Jose
0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjala @ 2019-03-22 20:49 UTC (permalink / raw)
To: intel-gfx
Cc: stable, José Roberto de Souza, Rodrigo Vivi, Tvrtko Ursulin
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
If I'm reading the spec right AML 0x87CA is a Y SKU, so it
should be marked as ULX in our old style terminology.
Cc: stable@vger.kernel.org
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: c0c46ca461f1 ("drm/i915/aml: Add new Amber Lake PCI ID")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index f723b15527f8..428279fd88a0 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2361,7 +2361,8 @@ static inline unsigned int i915_sg_segment_size(void)
INTEL_DEVID(dev_priv) == 0x5915 || \
INTEL_DEVID(dev_priv) == 0x591E)
#define IS_AML_ULX(dev_priv) (INTEL_DEVID(dev_priv) == 0x591C || \
- INTEL_DEVID(dev_priv) == 0x87C0)
+ INTEL_DEVID(dev_priv) == 0x87C0 || \
+ INTEL_DEVID(dev_priv) == 0x87CA)
#define IS_SKL_GT2(dev_priv) (IS_SKYLAKE(dev_priv) && \
INTEL_INFO(dev_priv)->gt == 2)
#define IS_SKL_GT3(dev_priv) (IS_SKYLAKE(dev_priv) && \
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Mark AML 0x87CA as ULX
2019-03-22 20:49 [PATCH] drm/i915: Mark AML 0x87CA as ULX Ville Syrjala
@ 2019-03-22 21:37 ` Souza, Jose
2019-03-25 7:03 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: Souza, Jose @ 2019-03-22 21:37 UTC (permalink / raw)
To: ville.syrjala, intel-gfx; +Cc: Vivi, Rodrigo, stable, Ursulin, Tvrtko
[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]
On Fri, 2019-03-22 at 22:49 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> If I'm reading the spec right AML 0x87CA is a Y SKU, so it
> should be marked as ULX in our old style terminology.
You are right, only the CPU is based on CFL.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Cc: stable@vger.kernel.org
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Fixes: c0c46ca461f1 ("drm/i915/aml: Add new Amber Lake PCI ID")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h
> b/drivers/gpu/drm/i915/i915_drv.h
> index f723b15527f8..428279fd88a0 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2361,7 +2361,8 @@ static inline unsigned int
> i915_sg_segment_size(void)
> INTEL_DEVID(dev_priv) == 0x5915 || \
> INTEL_DEVID(dev_priv) == 0x591E)
> #define IS_AML_ULX(dev_priv) (INTEL_DEVID(dev_priv) == 0x591C || \
> - INTEL_DEVID(dev_priv) == 0x87C0)
> + INTEL_DEVID(dev_priv) == 0x87C0 || \
> + INTEL_DEVID(dev_priv) == 0x87CA)
> #define IS_SKL_GT2(dev_priv) (IS_SKYLAKE(dev_priv) && \
> INTEL_INFO(dev_priv)->gt == 2)
> #define IS_SKL_GT3(dev_priv) (IS_SKYLAKE(dev_priv) && \
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Mark AML 0x87CA as ULX
2019-03-22 21:37 ` Souza, Jose
@ 2019-03-25 7:03 ` Ville Syrjälä
0 siblings, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2019-03-25 7:03 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx, Vivi, Rodrigo, stable, Ursulin, Tvrtko
On Fri, Mar 22, 2019 at 09:37:48PM +0000, Souza, Jose wrote:
> On Fri, 2019-03-22 at 22:49 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > If I'm reading the spec right AML 0x87CA is a Y SKU, so it
> > should be marked as ULX in our old style terminology.
>
> You are right, only the CPU is based on CFL.
>
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Thanks. Pushed.
>
> >
> > Cc: stable@vger.kernel.org
> > Cc: José Roberto de Souza <jose.souza@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Fixes: c0c46ca461f1 ("drm/i915/aml: Add new Amber Lake PCI ID")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h
> > index f723b15527f8..428279fd88a0 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2361,7 +2361,8 @@ static inline unsigned int
> > i915_sg_segment_size(void)
> > INTEL_DEVID(dev_priv) == 0x5915 || \
> > INTEL_DEVID(dev_priv) == 0x591E)
> > #define IS_AML_ULX(dev_priv) (INTEL_DEVID(dev_priv) == 0x591C || \
> > - INTEL_DEVID(dev_priv) == 0x87C0)
> > + INTEL_DEVID(dev_priv) == 0x87C0 || \
> > + INTEL_DEVID(dev_priv) == 0x87CA)
> > #define IS_SKL_GT2(dev_priv) (IS_SKYLAKE(dev_priv) && \
> > INTEL_INFO(dev_priv)->gt == 2)
> > #define IS_SKL_GT3(dev_priv) (IS_SKYLAKE(dev_priv) && \
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-25 7:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 20:49 [PATCH] drm/i915: Mark AML 0x87CA as ULX Ville Syrjala
2019-03-22 21:37 ` Souza, Jose
2019-03-25 7:03 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).