From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: "Jürgen Groß" <jgross@suse.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
<stable@vger.kernel.org>, Julien Grall <julien@xen.org>,
Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending
Date: Tue, 9 Mar 2021 08:57:23 +0000 [thread overview]
Message-ID: <b6d41422-47cf-956c-9c4a-98998c64b103@citrix.com> (raw)
In-Reply-To: <d6a1ab2e-4b77-7b14-e397-74aa71efb70d@suse.com>
On 2021-03-09 05:14, Jürgen Groß wrote:
> On 08.03.21 21:33, Boris Ostrovsky wrote:
>>
>> On 3/6/21 11:18 AM, Juergen Gross wrote:
>>> An event channel should be kept masked when an eoi is pending for it.
>>> When being migrated to another cpu it might be unmasked, though.
>>>
>>> In order to avoid this keep three different flags for each event channel
>>> to be able to distinguish "normal" masking/unmasking from eoi related
>>> masking/unmasking and temporary masking. The event channel should only
>>> be able to generate an interrupt if all flags are cleared.
>>>
>>> Cc: stable@vger.kernel.org
>>> Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework")
>>> Reported-by: Julien Grall <julien@xen.org>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>> Reviewed-by: Julien Grall <jgrall@amazon.com>
>>> ---
>>> V2:
>>> - introduce a lock around masking/unmasking
>>> - merge patch 3 into this one (Jan Beulich)
>>> V4:
>>> - don't set eoi masking flag in lateeoi_mask_ack_dynirq()
>>
>>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>
>>
>> Ross, are you planning to test this?
>
> Just as another data point: With the previous version of the patches
> a reboot loop of a guest needed max 33 reboots to loose network in
> my tests (those were IIRC 6 test runs). With this patch version I
> stopped the test after about 1300 reboots without having seen any
> problems.
>
Thanks, I'll test it today and get back to you.
Ross
next prev parent reply other threads:[~2021-03-09 9:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 16:18 [PATCH v4 0/3] xen/events: bug fixes and some diagnostic aids Juergen Gross
2021-03-06 16:18 ` [PATCH v4 1/3] xen/events: reset affinity of 2-level event when tearing it down Juergen Gross
2021-03-06 16:18 ` [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending Juergen Gross
2021-03-08 20:33 ` Boris Ostrovsky
2021-03-09 5:14 ` Jürgen Groß
2021-03-09 8:57 ` Ross Lagerwall [this message]
2021-03-10 9:08 ` Ross Lagerwall
2021-03-06 16:18 ` [PATCH v4 3/3] xen/events: avoid handling the same event on two cpus at the same time Juergen Gross
2021-03-11 14:36 ` [PATCH v4 0/3] xen/events: bug fixes and some diagnostic aids Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6d41422-47cf-956c-9c4a-98998c64b103@citrix.com \
--to=ross.lagerwall@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgrall@amazon.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).