From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
ross.lagerwall@citrix.com
Cc: Stefano Stabellini <sstabellini@kernel.org>,
stable@vger.kernel.org, Julien Grall <julien@xen.org>,
Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending
Date: Mon, 8 Mar 2021 15:33:33 -0500 [thread overview]
Message-ID: <ff9fb99f-12ca-c04e-e4bc-1b1c67381cc2@oracle.com> (raw)
In-Reply-To: <20210306161833.4552-3-jgross@suse.com>
On 3/6/21 11:18 AM, Juergen Gross wrote:
> An event channel should be kept masked when an eoi is pending for it.
> When being migrated to another cpu it might be unmasked, though.
>
> In order to avoid this keep three different flags for each event channel
> to be able to distinguish "normal" masking/unmasking from eoi related
> masking/unmasking and temporary masking. The event channel should only
> be able to generate an interrupt if all flags are cleared.
>
> Cc: stable@vger.kernel.org
> Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework")
> Reported-by: Julien Grall <julien@xen.org>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Julien Grall <jgrall@amazon.com>
> ---
> V2:
> - introduce a lock around masking/unmasking
> - merge patch 3 into this one (Jan Beulich)
> V4:
> - don't set eoi masking flag in lateeoi_mask_ack_dynirq()
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Ross, are you planning to test this?
-boris
next prev parent reply other threads:[~2021-03-08 20:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 16:18 [PATCH v4 0/3] xen/events: bug fixes and some diagnostic aids Juergen Gross
2021-03-06 16:18 ` [PATCH v4 1/3] xen/events: reset affinity of 2-level event when tearing it down Juergen Gross
2021-03-06 16:18 ` [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending Juergen Gross
2021-03-08 20:33 ` Boris Ostrovsky [this message]
2021-03-09 5:14 ` Jürgen Groß
2021-03-09 8:57 ` Ross Lagerwall
2021-03-10 9:08 ` Ross Lagerwall
2021-03-06 16:18 ` [PATCH v4 3/3] xen/events: avoid handling the same event on two cpus at the same time Juergen Gross
2021-03-11 14:36 ` [PATCH v4 0/3] xen/events: bug fixes and some diagnostic aids Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff9fb99f-12ca-c04e-e4bc-1b1c67381cc2@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jgrall@amazon.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).