* [PATCH] soc: mediatek: cmdq: fixup wrong input order of write api
@ 2019-11-28 9:14 Matthias Brugger
2019-11-28 9:32 ` Matthias Brugger
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Brugger @ 2019-11-28 9:14 UTC (permalink / raw)
To: mbrugger; +Cc: Bibby Hsieh, stable, CK Hu, Matthias Brugger
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
Fixup a issue was caused by the previous fixup patch.
Fixes: 1a92f989126e ("soc: mediatek: cmdq: reorder the parameter")
Cc: <stable@vger.kernel.org>
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 7aa0517ff2f3..3c82de5f9417 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -155,7 +155,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask);
offset_mask |= CMDQ_WRITE_ENABLE_MASK;
}
- err |= cmdq_pkt_write(pkt, value, subsys, offset_mask);
+ err |= cmdq_pkt_write(pkt, subsys, offset_mask, value);
return err;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: cmdq: fixup wrong input order of write api
2019-11-28 9:14 [PATCH] soc: mediatek: cmdq: fixup wrong input order of write api Matthias Brugger
@ 2019-11-28 9:32 ` Matthias Brugger
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2019-11-28 9:32 UTC (permalink / raw)
To: mbrugger; +Cc: Bibby Hsieh, stable, CK Hu
I resend the patch by accident.
Please ignore this one.
Regards,
Matthias
On 28/11/2019 10:14, Matthias Brugger wrote:
> From: Bibby Hsieh <bibby.hsieh@mediatek.com>
>
> Fixup a issue was caused by the previous fixup patch.
>
> Fixes: 1a92f989126e ("soc: mediatek: cmdq: reorder the parameter")
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 7aa0517ff2f3..3c82de5f9417 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -155,7 +155,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
> err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask);
> offset_mask |= CMDQ_WRITE_ENABLE_MASK;
> }
> - err |= cmdq_pkt_write(pkt, value, subsys, offset_mask);
> + err |= cmdq_pkt_write(pkt, subsys, offset_mask, value);
>
> return err;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] soc: mediatek: cmdq: fixup wrong input order of write api
@ 2019-11-27 16:54 Matthias Brugger
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2019-11-27 16:54 UTC (permalink / raw)
To: soc
Cc: linux-mediatek, linux-arm-kernel, bibby.hsieh, stable, CK Hu,
Matthias Brugger
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
Fixup a issue was caused by the previous fixup patch.
Fixes: 1a92f989126e ("soc: mediatek: cmdq: reorder the parameter")
Cc: <stable@vger.kernel.org>
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 7aa0517ff2f3..3c82de5f9417 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -155,7 +155,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask);
offset_mask |= CMDQ_WRITE_ENABLE_MASK;
}
- err |= cmdq_pkt_write(pkt, value, subsys, offset_mask);
+ err |= cmdq_pkt_write(pkt, subsys, offset_mask, value);
return err;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-28 9:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-28 9:14 [PATCH] soc: mediatek: cmdq: fixup wrong input order of write api Matthias Brugger
2019-11-28 9:32 ` Matthias Brugger
-- strict thread matches above, loose matches on Subject: below --
2019-11-27 16:54 Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).